From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Kalle Valo <kvalo@kernel.org>, Lingbo Kong <quic_lingbok@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] wifi: ath12k: add processing for TWT enable event
Date: Thu, 11 Jan 2024 08:55:45 -0800 [thread overview]
Message-ID: <f4ef8b0c-e2ee-4ced-b00a-8e58fc77ded4@quicinc.com> (raw)
In-Reply-To: <170498978118.916301.14993323516499040896.kvalo@kernel.org>
On 1/11/2024 8:16 AM, Kalle Valo wrote:
> Lingbo Kong <quic_lingbok@quicinc.com> wrote:
>
>> When ath12k send TWT enable command to firmware, firmware will return a TWT
>> enable event to ath12k. Through the analysis of TWT enable event status, we
>> can easily obtain the status of TWT enable command. It can be more
>> convenient to debug TWT.
>>
>> This patch works with WCN7850 and QCN9274.
>>
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
>>
>> Signed-off-by: Lingbo Kong <quic_lingbok@quicinc.com>
>> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>
> Fails to compile:
>
> drivers/net/wireless/ath/ath12k/wmi.c: In function 'ath12k_wmi_twt_enable_event':
> drivers/net/wireless/ath/ath12k/wmi.c:6675:48: error: passing argument 2 of 'ath12k_wmi_tlv_parse_alloc' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 6675 | tb = ath12k_wmi_tlv_parse_alloc(ab, skb->data, skb->len, GFP_ATOMIC);
> | ~~~^~~~~~
> | |
> | unsigned char *
> drivers/net/wireless/ath/ath12k/wmi.c:367:44: note: expected 'struct sk_buff *' but argument is of type 'unsigned char *'
> 367 | struct sk_buff *skb, gfp_t gfp)
> | ~~~~~~~~~~~~~~~~^~~
> drivers/net/wireless/ath/ath12k/wmi.c:6675:14: error: too many arguments to function 'ath12k_wmi_tlv_parse_alloc'
> 6675 | tb = ath12k_wmi_tlv_parse_alloc(ab, skb->data, skb->len, GFP_ATOMIC);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath12k/wmi.c:366:1: note: declared here
> 366 | ath12k_wmi_tlv_parse_alloc(struct ath12k_base *ab,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath12k/wmi.c: In function 'ath12k_wmi_twt_disable_event':
> drivers/net/wireless/ath/ath12k/wmi.c:6704:48: error: passing argument 2 of 'ath12k_wmi_tlv_parse_alloc' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 6704 | tb = ath12k_wmi_tlv_parse_alloc(ab, skb->data, skb->len, GFP_ATOMIC);
> | ~~~^~~~~~
> | |
> | unsigned char *
> drivers/net/wireless/ath/ath12k/wmi.c:367:44: note: expected 'struct sk_buff *' but argument is of type 'unsigned char *'
> 367 | struct sk_buff *skb, gfp_t gfp)
> | ~~~~~~~~~~~~~~~~^~~
> drivers/net/wireless/ath/ath12k/wmi.c:6704:14: error: too many arguments to function 'ath12k_wmi_tlv_parse_alloc'
> 6704 | tb = ath12k_wmi_tlv_parse_alloc(ab, skb->data, skb->len, GFP_ATOMIC);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath12k/wmi.c:366:1: note: declared here
> 366 | ath12k_wmi_tlv_parse_alloc(struct ath12k_base *ab,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[7]: *** [scripts/Makefile.build:243: drivers/net/wireless/ath/ath12k/wmi.o] Error 1
> make[7]: *** Waiting for unfinished jobs....
> make[6]: *** [scripts/Makefile.build:480: drivers/net/wireless/ath/ath12k] Error 2
> make[5]: *** [scripts/Makefile.build:480: drivers/net/wireless/ath] Error 2
> make[4]: *** [scripts/Makefile.build:480: drivers/net/wireless] Error 2
> make[3]: *** [scripts/Makefile.build:480: drivers/net] Error 2
> make[2]: *** [scripts/Makefile.build:480: drivers] Error 2
> make[1]: *** [/home/kvalo/projects/atheros/ath10k/src/ath/Makefile:1911: .] Error 2
> make: *** [Makefile:234: __sub-make] Error 2
>
> 2 patches set to Changes Requested.
>
> 13509671 [1/2] wifi: ath12k: add processing for TWT enable event
> 13509673 [2/2] wifi: ath12k: add processing for TWT disable event
>
This became a victim of the interface change in:
wifi: ath12k: refactor ath12k_wmi_tlv_parse_alloc()
next prev parent reply other threads:[~2024-01-11 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 5:09 [PATCH 0/2] wifi: ath12k: add processing for TWT enable/disable event Lingbo Kong
2024-01-03 5:09 ` [PATCH 1/2] wifi: ath12k: add processing for TWT enable event Lingbo Kong
2024-01-03 17:05 ` Jeff Johnson
2024-01-11 16:16 ` Kalle Valo
2024-01-11 16:55 ` Jeff Johnson [this message]
2024-01-03 5:09 ` [PATCH 2/2] wifi: ath12k: add processing for TWT disable event Lingbo Kong
2024-01-03 17:06 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4ef8b0c-e2ee-4ced-b00a-8e58fc77ded4@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_lingbok@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.