From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA0DAC433E0 for ; Mon, 11 Jan 2021 08:20:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A2AF22AAA for ; Mon, 11 Jan 2021 08:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727347AbhAKIUT (ORCPT ); Mon, 11 Jan 2021 03:20:19 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:35911 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbhAKIUS (ORCPT ); Mon, 11 Jan 2021 03:20:18 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610353202; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=qw/c4lu6kAigwWBL51ikONX2GIaFw4LqTFQWJ2iKgGs=; b=d0LPbmcVNKPg4PDkAWOHIqGPGJ8esT2MGxFkmzbeivUvEcpGWSiOUtiHvKQ9u6Grybul7Efq NDgvsDuksO2dXfUQDAhqdQ5wOnPojriq7e3FQ6Nq3xD82RTMEu1u2XUBtDr/glTveg4OIGGT 2cmUArmvlEfzH1mjdedJ9n9RwYo= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyJlNmU5NiIsICJsaW51eC1zY3NpQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 5ffc0a0a4dcca12475f03fbc (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 11 Jan 2021 08:19:22 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CBD47C43462; Mon, 11 Jan 2021 08:19:21 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4ABCCC433C6; Mon, 11 Jan 2021 08:19:21 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 11 Jan 2021 16:19:21 +0800 From: Can Guo To: Avri Altman Cc: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, kernel-team@android.com, alim.akhtar@samsung.com, bvanassche@acm.org, martin.petersen@oracle.com, stanley.chu@mediatek.com, Jaegeuk Kim Subject: Re: [PATCH] scsi: ufs: should not override buffer lengh In-Reply-To: References: <20210111044443.1405049-1-jaegeuk@kernel.org> <6551e7d6dd7dc4132dc69e77a51f6f21@codeaurora.org> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2021-01-11 16:15, Avri Altman wrote: >> >> Sorry, typo corrected. >> >> Hi Jaegeuk, >> >> I think the problem is that func ufshcd_read_desc_param() is not >> expecting >> one access unsupported descriptors on RPMB LU. > Correct. > This is about wb introducing a new constraint: wb buffer is only > allowed in lu 0..7. > And this is why, IMHO, the fix should be in ufs_is_valid_unit_desc_lun, > To include param offset, as it is only called in contingency of > ufshcd_read_desc_param. > > Thanks, > Avri Yeah... Fixing it in ufs-sysfs.c also works. Anyways, the math in ufshcd_read_desc_param is already complex. Let's fix it somewhere close to the source/initiator. Thanks, Can Guo.