From: Alex Hung <alex.hung@amd.com>
To: Leonardo Gomes <leonardodasigomes@gmail.com>,
harry.wentland@amd.com, sunpeng.li@amd.com,
alexander.deucher@amd.com, christian.koenig@amd.com,
airlied@gmail.com, simona@ffwll.ch
Cc: derick.william.moraes@gmail.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH RESEND] drm/amd/display: Adjust prefix of dcn31_apg construct function name
Date: Mon, 26 May 2025 20:50:46 -0600 [thread overview]
Message-ID: <f4fa1065-ff9e-4721-9f5f-55a87faeb6c2@amd.com> (raw)
In-Reply-To: <20250521135851.11110-1-leonardodasigomes@gmail.com>
Hi Leonardo,
Thank you for this patch, but unfortunately some unit test suites depend
on the names.
On 5/21/25 07:58, Leonardo Gomes wrote:
> From: Leonardo da Silva Gomes <leonardodasigomes@gmail.com>
>
> Adjust the dcn31_apg construct function name from
> 'apg31_construct' to 'dcn31_apg_construct'.
> This helps the ftrace to detect the file by the function name.
>
> Signed-off-by: Leonardo da Silva Gomes <leonardodasigomes@gmail.com>
> Co-developed-by: Derick Frias <derick.william.moraes@gmail.com>
> Signed-off-by: Derick Frias <derick.william.moraes@gmail.com>
> ---
> drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.h | 2 +-
> drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c | 2 +-
> .../gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c | 2 +-
> .../gpu/drm/amd/display/dc/resource/dcn315/dcn315_resource.c | 2 +-
> .../gpu/drm/amd/display/dc/resource/dcn316/dcn316_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c | 2 +-
> .../gpu/drm/amd/display/dc/resource/dcn321/dcn321_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c | 2 +-
> .../gpu/drm/amd/display/dc/resource/dcn351/dcn351_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/resource/dcn36/dcn36_resource.c | 2 +-
> .../gpu/drm/amd/display/dc/resource/dcn401/dcn401_resource.c | 2 +-
> 12 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.c
> index 05aac3e444b4..d1ccc9a34b2e 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.c
> @@ -101,7 +101,7 @@ static struct apg_funcs dcn31_apg_funcs = {
> .disable_apg = apg31_disable,
> };
>
> -void apg31_construct(struct dcn31_apg *apg31,
> +void dcn31_apg_construct(struct dcn31_apg *apg31,
> struct dc_context *ctx,
> uint32_t inst,
> const struct dcn31_apg_registers *apg_regs,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.h b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.h
> index 1b81f6773c53..54c6b62195c2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.h
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_apg.h
> @@ -100,7 +100,7 @@ struct dcn31_apg {
> const struct dcn31_apg_mask *apg_mask;
> };
>
> -void apg31_construct(struct dcn31_apg *apg3,
> +void dcn31_apg_construct(struct dcn31_apg *apg3,
> struct dc_context *ctx,
> uint32_t inst,
> const struct dcn31_apg_registers *apg_regs,
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c
> index dddddbfef85f..b3553ae26d7c 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn31/dcn31_resource.c
> @@ -1207,7 +1207,7 @@ static struct apg *dcn31_apg_create(
> if (!apg31)
> return NULL;
>
> - apg31_construct(apg31, ctx, inst,
> + dcn31_apg_construct(apg31, ctx, inst,
> &apg_regs[inst],
> &apg_shift,
> &apg_mask);
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c
> index 26becc4cb804..be55a3c36a78 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn314/dcn314_resource.c
> @@ -1263,7 +1263,7 @@ static struct apg *dcn31_apg_create(
> if (!apg31)
> return NULL;
>
> - apg31_construct(apg31, ctx, inst,
> + dcn31_apg_construct(apg31, ctx, inst,
> &apg_regs[inst],
> &apg_shift,
> &apg_mask);
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn315/dcn315_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn315/dcn315_resource.c
> index 6c2bb3f63be1..b9847b4bb0f3 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn315/dcn315_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn315/dcn315_resource.c
> @@ -1205,7 +1205,7 @@ static struct apg *dcn31_apg_create(
> if (!apg31)
> return NULL;
>
> - apg31_construct(apg31, ctx, inst,
> + dcn31_apg_construct(apg31, ctx, inst,
> &apg_regs[inst],
> &apg_shift,
> &apg_mask);
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn316/dcn316_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn316/dcn316_resource.c
> index 568094827212..b6cf2a296ab4 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn316/dcn316_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn316/dcn316_resource.c
> @@ -1200,7 +1200,7 @@ static struct apg *dcn31_apg_create(
> if (!apg31)
> return NULL;
>
> - apg31_construct(apg31, ctx, inst,
> + dcn31_apg_construct(apg31, ctx, inst,
> &apg_regs[inst],
> &apg_shift,
> &apg_mask);
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c
> index 2a59cc61ed8c..66fef6f6000e 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn32/dcn32_resource.c
> @@ -1187,7 +1187,7 @@ static struct apg *dcn31_apg_create(
> apg_regs_init(2),
> apg_regs_init(3);
>
> - apg31_construct(apg31, ctx, inst,
> + dcn31_apg_construct(apg31, ctx, inst,
> &apg_regs[inst],
> &apg_shift,
> &apg_mask);
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn321/dcn321_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn321/dcn321_resource.c
> index 38d76434683e..9be23da216d0 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn321/dcn321_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn321/dcn321_resource.c
> @@ -1170,7 +1170,7 @@ static struct apg *dcn321_apg_create(
> apg_regs_init(2),
> apg_regs_init(3);
>
> - apg31_construct(apg31, ctx, inst,
> + dcn31_apg_construct(apg31, ctx, inst,
> &apg_regs[inst],
> &apg_shift,
> &apg_mask);
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c
> index ffd2b816cd02..27affafb14f1 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c
> @@ -1252,7 +1252,7 @@ static struct apg *dcn31_apg_create(
> apg_regs_init(2),
> apg_regs_init(3);
>
> - apg31_construct(apg31, ctx, inst,
> + dcn31_apg_construct(apg31, ctx, inst,
> &apg_regs[inst],
> &apg_shift,
> &apg_mask);
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn351/dcn351_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn351/dcn351_resource.c
> index 98f5bc1b929e..d5341b0d59f3 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn351/dcn351_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn351/dcn351_resource.c
> @@ -1232,7 +1232,7 @@ static struct apg *dcn31_apg_create(
> apg_regs_init(2),
> apg_regs_init(3);
>
> - apg31_construct(apg31, ctx, inst,
> + dcn31_apg_construct(apg31, ctx, inst,
> &apg_regs[inst],
> &apg_shift,
> &apg_mask);
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn36/dcn36_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn36/dcn36_resource.c
> index b6468573dc33..6fb2261c554d 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn36/dcn36_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn36/dcn36_resource.c
> @@ -1233,7 +1233,7 @@ static struct apg *dcn31_apg_create(
> apg_regs_init(2),
> apg_regs_init(3);
>
> - apg31_construct(apg31, ctx, inst,
> + dcn31_apg_construct(apg31, ctx, inst,
> &apg_regs[inst],
> &apg_shift,
> &apg_mask);
> diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn401/dcn401_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn401/dcn401_resource.c
> index 7436dfbdf927..ef4d758bfb5a 100644
> --- a/drivers/gpu/drm/amd/display/dc/resource/dcn401/dcn401_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn401/dcn401_resource.c
> @@ -1162,7 +1162,7 @@ static struct apg *dcn401_apg_create(
> apg_regs_init(2),
> apg_regs_init(3);
>
> - apg31_construct(apg31, ctx, inst,
> + dcn31_apg_construct(apg31, ctx, inst,
> &apg_regs[inst],
> &apg_shift,
> &apg_mask);
next prev parent reply other threads:[~2025-05-27 2:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 13:58 [PATCH RESEND] drm/amd/display: Adjust prefix of dcn31_apg construct function name Leonardo Gomes
2025-05-27 2:50 ` Alex Hung [this message]
2025-05-27 10:15 ` Leonardo Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4fa1065-ff9e-4721-9f5f-55a87faeb6c2@amd.com \
--to=alex.hung@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=derick.william.moraes@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=leonardodasigomes@gmail.com \
--cc=simona@ffwll.ch \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.