From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A91C64ED6 for ; Mon, 27 Feb 2023 14:58:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbjB0O6j (ORCPT ); Mon, 27 Feb 2023 09:58:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbjB0O6h (ORCPT ); Mon, 27 Feb 2023 09:58:37 -0500 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6958C5262; Mon, 27 Feb 2023 06:58:36 -0800 (PST) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id B2CBF8339E; Mon, 27 Feb 2023 15:58:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1677509914; bh=r/XTzrYSTfxQc9R6KeDw695Bi854lHCpElV1s8nh8zI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=B61E42Rlo4Qbn6uODr49/NrHqZtDV6G2b4N5nZEpnn2AW4+IbG8wgrr/hxciTsicb NlAQ9q5LW+JKbq1Q+qLwAmFrX894HlPPcbUri5KCfBhcf0GT5KYh1dRxjaXGKo9RMi R8p2MoyhFHPHU1hwYnB4xK+aZy1D78LtNPFw3fdsid+MLAhXpiWOLqXWKht8n4lE6K VndDJMufqNL8k5pXKMHEfM3ah2gL3tSoPg78bsubhW1k+8SCZKOvdQHCBAh0RbieuN cyvq3JqauOs6gZSnqiIoqy6vCp/bi2IzDHb0gsqScKVGD5Z07g/SOxjZd7kAsbconp h86Hx7j3fmLcA== Message-ID: Date: Mon, 27 Feb 2023 14:53:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 4/5] arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX Content-Language: en-US To: Alexander Stein , linux-clk@vger.kernel.org Cc: Luca Ceresoli , Abel Vesa , Fabio Estevam , Jacky Bai , Krzysztof Kozlowski , Laurent Pinchart , Lucas Stach , Marco Felsch , Michael Turquette , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230223171114.59164-1-marex@denx.de> <20230223171114.59164-4-marex@denx.de> <3160821.5fSG56mABF@steina-w> From: Marek Vasut In-Reply-To: <3160821.5fSG56mABF@steina-w> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 2/27/23 10:08, Alexander Stein wrote: [...] >> + sdma2: dma-controller@30e10000 { >> + compatible = "fsl,imx8mp-sdma", > "fsl,imx8mq-sdma"; >> + reg = <0x30e10000 0x10000>; >> + interrupts = IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&audio_blk_ctrl > IMX8MP_CLK_AUDIOMIX_SDMA2_ROOT>, >> + <&clk > IMX8MP_CLK_AUDIO_ROOT>; >> + clock-names = "ipg", "ahb"; >> + #dma-cells = <3>; >> + fsl,sdma-ram-script-name = "imx/sdma/ > sdma-imx7d.bin"; >> + }; >> + >> + audio_blk_ctrl: blk-ctrl@30e20000 { > > Shouldn't the node name be 'clock-controller@30e20000' as mentioned in the > bindings? > But for the whole series: > Testes-by: Alexander Stein It should be clock-controller indeed, fixed in V5, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F419EC7EE23 for ; Mon, 27 Feb 2023 14:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kcyE6K48WkocS+tLezUJxzpaK9wzb8gAfxHhjLcii4c=; b=pJtvsPKMXvHd0a YMckA83ojm/IUiMOOZ9IRx+o/b/frhmlJlpMD/1Bh8JhUGfHC/EwNN6Fm5XJ4DSAsRRS18iczdzuw yGyF1XDTtd/e+iVHG9GsN/INK11AZtSAcWvmfKbaGAOWHzWMcCZUDse+ohECiAg9nk4eBvaV/xm56 lz1nk5S+i24YmkBGAa8GNTYRlmodhoE+hhagB+AzoQgTgHOtJm24t6PKmACAmLmVTzOv51eflTPiB dRU6+DDrAKoLxbfK/Cvn8opJ0HHBy6iffVH7xK5pmLd0IBPwHSkgzOa0UbKlQdifuD2Ztl0qT1ara wS705ZTY1nGd1/LwgRzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWexl-00A6KY-K4; Mon, 27 Feb 2023 14:58:49 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWexa-00A6Ef-HJ for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 14:58:39 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id B2CBF8339E; Mon, 27 Feb 2023 15:58:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1677509914; bh=r/XTzrYSTfxQc9R6KeDw695Bi854lHCpElV1s8nh8zI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=B61E42Rlo4Qbn6uODr49/NrHqZtDV6G2b4N5nZEpnn2AW4+IbG8wgrr/hxciTsicb NlAQ9q5LW+JKbq1Q+qLwAmFrX894HlPPcbUri5KCfBhcf0GT5KYh1dRxjaXGKo9RMi R8p2MoyhFHPHU1hwYnB4xK+aZy1D78LtNPFw3fdsid+MLAhXpiWOLqXWKht8n4lE6K VndDJMufqNL8k5pXKMHEfM3ah2gL3tSoPg78bsubhW1k+8SCZKOvdQHCBAh0RbieuN cyvq3JqauOs6gZSnqiIoqy6vCp/bi2IzDHb0gsqScKVGD5Z07g/SOxjZd7kAsbconp h86Hx7j3fmLcA== Message-ID: Date: Mon, 27 Feb 2023 14:53:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 4/5] arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX Content-Language: en-US To: Alexander Stein , linux-clk@vger.kernel.org Cc: Luca Ceresoli , Abel Vesa , Fabio Estevam , Jacky Bai , Krzysztof Kozlowski , Laurent Pinchart , Lucas Stach , Marco Felsch , Michael Turquette , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230223171114.59164-1-marex@denx.de> <20230223171114.59164-4-marex@denx.de> <3160821.5fSG56mABF@steina-w> From: Marek Vasut In-Reply-To: <3160821.5fSG56mABF@steina-w> X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_065838_773509_DB6793CF X-CRM114-Status: GOOD ( 10.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/27/23 10:08, Alexander Stein wrote: [...] >> + sdma2: dma-controller@30e10000 { >> + compatible = "fsl,imx8mp-sdma", > "fsl,imx8mq-sdma"; >> + reg = <0x30e10000 0x10000>; >> + interrupts = IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&audio_blk_ctrl > IMX8MP_CLK_AUDIOMIX_SDMA2_ROOT>, >> + <&clk > IMX8MP_CLK_AUDIO_ROOT>; >> + clock-names = "ipg", "ahb"; >> + #dma-cells = <3>; >> + fsl,sdma-ram-script-name = "imx/sdma/ > sdma-imx7d.bin"; >> + }; >> + >> + audio_blk_ctrl: blk-ctrl@30e20000 { > > Shouldn't the node name be 'clock-controller@30e20000' as mentioned in the > bindings? > But for the whole series: > Testes-by: Alexander Stein It should be clock-controller indeed, fixed in V5, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel