From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C748C54E76 for ; Fri, 6 Jan 2023 07:19:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231810AbjAFHS5 (ORCPT ); Fri, 6 Jan 2023 02:18:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbjAFHSj (ORCPT ); Fri, 6 Jan 2023 02:18:39 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA5977814F for ; Thu, 5 Jan 2023 23:18:24 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id bt23so893847lfb.5 for ; Thu, 05 Jan 2023 23:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fwNOkK/619F6kwc/0Tj1pDo4Y9cxK12cXZ8QRlsLr6c=; b=JYJ70ritw2cx4/IvR9IiIbsgwqw4HWs/g4hPHX5vB+Fsokz0YvbAkV+WT8PMDX3Yrv o1pI0tIcLqzWLHzSWTosiOtxcIE2Q79xD3r2kBD1KlCfS8P3OreyFq39ARAthzF7dUaW 0k44EHlzwnAMW1ZhKTHumoJz/TemXhH3+CVxBLTUW4Vsv9U5tGm8VrmLXp/aVXFRRJwu chqKdo7ZT5FExXxJSE3ck4oltx83rsKafIBfjQ2enm2ymVH5Idk6bRj1o/DeWE0jVxo5 yJlgrF3e1cGCBjesc0AZACf9j7oRegCzyHa+PjrvlX01fjVSHEw0eKJu5MuCuuXRctO0 /y0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fwNOkK/619F6kwc/0Tj1pDo4Y9cxK12cXZ8QRlsLr6c=; b=UMsAmL35tZEUODNAd2TsINMn435zIyFtmzg7bdoI3krgtqltDyDrRCA/wkMlTk3UrF vTqIJdmK4rKp4v8IIheijfk2pcJAQPP5VrYXPDNiBlFIzidj+EFB8ZtEOJ9ie772Jhvi Xk0Ol9qd4wcX2nPbe5na5VAzUa5kx+6WW7osm17dTIBe6JesKcpYl1Kz9FqwGhiQzJAB hp0cp8JFxQtz3OHAqYDIIpikK/4Z5GwjElerrpq/Ak3XOaXpbt0OkKI50JFUyhl/Z1EJ kAfqI4iihEKVGWG9p5mNasLt8AzKG7fHB3XmWYdElVz83IAwy6L0aKJ8BIzDphYY1SwT CLkA== X-Gm-Message-State: AFqh2kojeyTjhkhdrCLGmGnsIY1z6hi9VduMb5nnF69FNKx3ixEQC13y abHECYuIBKoep54K79mPnvVMhQ== X-Google-Smtp-Source: AMrXdXtkBlNpkecak93UASBcKEuMXUx4GuG2RT59y+bG+p5w0zFuJUEV6ziyHNppyL41uyZ+n65U3g== X-Received: by 2002:a05:6512:3c9e:b0:4b6:a6e4:ab7a with SMTP id h30-20020a0565123c9e00b004b6a6e4ab7amr17977799lfv.8.1672989503149; Thu, 05 Jan 2023 23:18:23 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id y8-20020ac255a8000000b004a9b9ccfbe6sm57707lfg.51.2023.01.05.23.18.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jan 2023 23:18:22 -0800 (PST) Message-ID: Date: Fri, 6 Jan 2023 09:18:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] drm/msm: Set preferred depth. Content-Language: en-GB To: Steev Klimaszewski Cc: Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230106071609.3948-1-steev@kali.org> From: Dmitry Baryshkov In-Reply-To: <20230106071609.3948-1-steev@kali.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 06/01/2023 09:16, Steev Klimaszewski wrote: > As of commit 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format > selection"), if no supported color formats are found, it tries to use the > driver provided default, which msm didn't have set and leads to the > following output: > > msm_dpu ae01000.display-controller: [drm] bpp/depth value of 32/0 not supported > msm_dpu ae01000.display-controller: [drm] bpp/depth value of 32/0 not supported > msm_dpu ae01000.display-controller: [drm] bpp/depth value of 32/0 not supported > msm_dpu ae01000.display-controller: [drm] No compatible format found > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 73 at drivers/gpu/drm/drm_atomic.c:1604 __drm_atomic_helper_set_config+0x240/0x33c > Modules linked in: ext4 mbcache jbd2 msm mdt_loader ocmem gpu_sched llcc_qcom gpio_keys qrtr > CPU: 0 PID: 73 Comm: kworker/u16:2 Not tainted 6.2.0-rc2-next-20230106 #53 > Hardware name: LENOVO 21BX0015US/21BX0015US, BIOS N3HET74W (1.46 ) 10/12/2022 > Workqueue: events_unbound deferred_probe_work_func > pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : __drm_atomic_helper_set_config+0x240/0x33c > lr : __drm_atomic_helper_set_config+0x68/0x33c > sp : ffff800008a7b790 > x29: ffff800008a7b790 x28: ffff73ee3e130a00 x27: 0000000000000000 > x26: ffff73ee3d256e00 x25: 0000000000000038 x24: ffff73e6c0d65e00 > x23: ffff73e6c17a7800 x22: ffff73e6c0d64e00 x21: ffff73e79c025e00 > x20: 00000000c0d64e00 x19: ffff73ee3e130a00 x18: ffffffffffffffff > x17: 662074616d726f66 x16: 20656c6269746170 x15: 0000000000000000 > x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > x11: 0000000000000000 x10: 0000000000000000 x9 : ffffa829144ff8bc > x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000 > x5 : ffff73e6c0d65f50 x4 : ffff73ee3d254950 x3 : ffff73e6c0d65ec0 > x2 : ffff73ee3c953a00 x1 : ffff73e79c025580 x0 : 0000000000000000 > Call trace: > __drm_atomic_helper_set_config+0x240/0x33c > drm_client_modeset_commit_atomic+0x160/0x280 > drm_client_modeset_commit_locked+0x64/0x194 > drm_client_modeset_commit+0x38/0x60 > __drm_fb_helper_initial_config_and_unlock+0x528/0x63c > drm_fb_helper_initial_config+0x54/0x64 > msm_fbdev_init+0x94/0xfc [msm] > msm_drm_bind+0x548/0x614 [msm] > try_to_bring_up_aggregate_device+0x1e4/0x2d0 > __component_add+0xc4/0x1c0 > component_add+0x1c/0x2c > dp_display_probe+0x2a4/0x460 [msm] > platform_probe+0x70/0xcc > really_probe+0xc8/0x3e0 > __driver_probe_device+0x84/0x190 > driver_probe_device+0x44/0x120 > __device_attach_driver+0xc4/0x160 > bus_for_each_drv+0x84/0xe0 > __device_attach+0xa4/0x1cc > device_initial_probe+0x1c/0x2c > bus_probe_device+0xa4/0xb0 > deferred_probe_work_func+0xc0/0x114 > process_one_work+0x1ec/0x470 > worker_thread+0x74/0x410 > kthread+0xfc/0x110 > ret_from_fork+0x10/0x20 > ---[ end trace 0000000000000000 ]--- > > Signed-off-by: Steev Klimaszewski > --- > drivers/gpu/drm/msm/msm_drv.c | 1 + > 1 file changed, 1 insertion(+) Suggested-by: Dmitry Baryshkov Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AD80C54E76 for ; Fri, 6 Jan 2023 07:18:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 31DE910E2E3; Fri, 6 Jan 2023 07:18:27 +0000 (UTC) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD7DF10E2CE for ; Fri, 6 Jan 2023 07:18:24 +0000 (UTC) Received: by mail-lf1-x130.google.com with SMTP id b3so911382lfv.2 for ; Thu, 05 Jan 2023 23:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fwNOkK/619F6kwc/0Tj1pDo4Y9cxK12cXZ8QRlsLr6c=; b=JYJ70ritw2cx4/IvR9IiIbsgwqw4HWs/g4hPHX5vB+Fsokz0YvbAkV+WT8PMDX3Yrv o1pI0tIcLqzWLHzSWTosiOtxcIE2Q79xD3r2kBD1KlCfS8P3OreyFq39ARAthzF7dUaW 0k44EHlzwnAMW1ZhKTHumoJz/TemXhH3+CVxBLTUW4Vsv9U5tGm8VrmLXp/aVXFRRJwu chqKdo7ZT5FExXxJSE3ck4oltx83rsKafIBfjQ2enm2ymVH5Idk6bRj1o/DeWE0jVxo5 yJlgrF3e1cGCBjesc0AZACf9j7oRegCzyHa+PjrvlX01fjVSHEw0eKJu5MuCuuXRctO0 /y0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fwNOkK/619F6kwc/0Tj1pDo4Y9cxK12cXZ8QRlsLr6c=; b=5h9LEs6r8qFqLXQ5VZHF+e3jYD+WcyFLaws6vhBZLkAVgG+WKcL5aiwaBJk8GSBl73 3ZEMzkjh2mxCDtndk1YgBxha2JZxXinu9Vmo3iMmcSzm4MT/zWqRbGChedrazzncFn9n hl91LJpk5yGtKDnfB1+gThD3/7/XHT6ULmVEmwbp9uOyOMWs0TMBokIO4JgH/15zNP/Y 0kSqKjDJuc1Dt2+lWWMK/Ga3mE2aqutWhca6aB8SfAn5BvweuGncOYQusm/XlDlcFJ91 h4t6oPIREybNrmZDybl9x3gPyAI/0OhB8S2X9gZE5d8cVg2Cryg1j2OUx+OmLcCSC8ET 5qVQ== X-Gm-Message-State: AFqh2kqyx/yrAlzEbgyyK/mIwwBlOP3vRShg8fRaJZVagLd7bTzpzDB+ DzABhcBtB+EJM60MxCHgX9p07g== X-Google-Smtp-Source: AMrXdXtkBlNpkecak93UASBcKEuMXUx4GuG2RT59y+bG+p5w0zFuJUEV6ziyHNppyL41uyZ+n65U3g== X-Received: by 2002:a05:6512:3c9e:b0:4b6:a6e4:ab7a with SMTP id h30-20020a0565123c9e00b004b6a6e4ab7amr17977799lfv.8.1672989503149; Thu, 05 Jan 2023 23:18:23 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id y8-20020ac255a8000000b004a9b9ccfbe6sm57707lfg.51.2023.01.05.23.18.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jan 2023 23:18:22 -0800 (PST) Message-ID: Date: Fri, 6 Jan 2023 09:18:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] drm/msm: Set preferred depth. Content-Language: en-GB To: Steev Klimaszewski References: <20230106071609.3948-1-steev@kali.org> From: Dmitry Baryshkov In-Reply-To: <20230106071609.3948-1-steev@kali.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Sean Paul , Abhinav Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 06/01/2023 09:16, Steev Klimaszewski wrote: > As of commit 37c90d589dc0 ("drm/fb-helper: Fix single-probe color-format > selection"), if no supported color formats are found, it tries to use the > driver provided default, which msm didn't have set and leads to the > following output: > > msm_dpu ae01000.display-controller: [drm] bpp/depth value of 32/0 not supported > msm_dpu ae01000.display-controller: [drm] bpp/depth value of 32/0 not supported > msm_dpu ae01000.display-controller: [drm] bpp/depth value of 32/0 not supported > msm_dpu ae01000.display-controller: [drm] No compatible format found > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 73 at drivers/gpu/drm/drm_atomic.c:1604 __drm_atomic_helper_set_config+0x240/0x33c > Modules linked in: ext4 mbcache jbd2 msm mdt_loader ocmem gpu_sched llcc_qcom gpio_keys qrtr > CPU: 0 PID: 73 Comm: kworker/u16:2 Not tainted 6.2.0-rc2-next-20230106 #53 > Hardware name: LENOVO 21BX0015US/21BX0015US, BIOS N3HET74W (1.46 ) 10/12/2022 > Workqueue: events_unbound deferred_probe_work_func > pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : __drm_atomic_helper_set_config+0x240/0x33c > lr : __drm_atomic_helper_set_config+0x68/0x33c > sp : ffff800008a7b790 > x29: ffff800008a7b790 x28: ffff73ee3e130a00 x27: 0000000000000000 > x26: ffff73ee3d256e00 x25: 0000000000000038 x24: ffff73e6c0d65e00 > x23: ffff73e6c17a7800 x22: ffff73e6c0d64e00 x21: ffff73e79c025e00 > x20: 00000000c0d64e00 x19: ffff73ee3e130a00 x18: ffffffffffffffff > x17: 662074616d726f66 x16: 20656c6269746170 x15: 0000000000000000 > x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > x11: 0000000000000000 x10: 0000000000000000 x9 : ffffa829144ff8bc > x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000 > x5 : ffff73e6c0d65f50 x4 : ffff73ee3d254950 x3 : ffff73e6c0d65ec0 > x2 : ffff73ee3c953a00 x1 : ffff73e79c025580 x0 : 0000000000000000 > Call trace: > __drm_atomic_helper_set_config+0x240/0x33c > drm_client_modeset_commit_atomic+0x160/0x280 > drm_client_modeset_commit_locked+0x64/0x194 > drm_client_modeset_commit+0x38/0x60 > __drm_fb_helper_initial_config_and_unlock+0x528/0x63c > drm_fb_helper_initial_config+0x54/0x64 > msm_fbdev_init+0x94/0xfc [msm] > msm_drm_bind+0x548/0x614 [msm] > try_to_bring_up_aggregate_device+0x1e4/0x2d0 > __component_add+0xc4/0x1c0 > component_add+0x1c/0x2c > dp_display_probe+0x2a4/0x460 [msm] > platform_probe+0x70/0xcc > really_probe+0xc8/0x3e0 > __driver_probe_device+0x84/0x190 > driver_probe_device+0x44/0x120 > __device_attach_driver+0xc4/0x160 > bus_for_each_drv+0x84/0xe0 > __device_attach+0xa4/0x1cc > device_initial_probe+0x1c/0x2c > bus_probe_device+0xa4/0xb0 > deferred_probe_work_func+0xc0/0x114 > process_one_work+0x1ec/0x470 > worker_thread+0x74/0x410 > kthread+0xfc/0x110 > ret_from_fork+0x10/0x20 > ---[ end trace 0000000000000000 ]--- > > Signed-off-by: Steev Klimaszewski > --- > drivers/gpu/drm/msm/msm_drv.c | 1 + > 1 file changed, 1 insertion(+) Suggested-by: Dmitry Baryshkov Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry