From mboxrd@z Thu Jan 1 00:00:00 1970 From: shuah at kernel.org (Shuah Khan) Date: Mon, 26 Feb 2018 09:54:37 -0700 Subject: [PATCH 1/2] selftests: ion: Remove some prints In-Reply-To: <20180216012445.17264-2-labbott@redhat.com> References: <20180216012445.17264-1-labbott@redhat.com> <20180216012445.17264-2-labbott@redhat.com> Message-ID: On 02/15/2018 06:24 PM, Laura Abbott wrote: > There's no need to print messages each time we alloc and free. Remove them. > > Signed-off-by: Laura Abbott > --- > tools/testing/selftests/android/ion/ionutils.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/tools/testing/selftests/android/ion/ionutils.c b/tools/testing/selftests/android/ion/ionutils.c > index ce69c14f51fa..7d1d37c4ef6a 100644 > --- a/tools/testing/selftests/android/ion/ionutils.c > +++ b/tools/testing/selftests/android/ion/ionutils.c > @@ -80,11 +80,6 @@ int ion_export_buffer_fd(struct ion_buffer_info *ion_info) > heap_id = MAX_HEAP_COUNT + 1; > for (i = 0; i < query.cnt; i++) { > if (heap_data[i].type == ion_info->heap_type) { > - printf("--------------------------------------\n"); > - printf("heap type: %d\n", heap_data[i].type); > - printf(" heap id: %d\n", heap_data[i].heap_id); > - printf("heap name: %s\n", heap_data[i].name); > - printf("--------------------------------------\n"); > heap_id = heap_data[i].heap_id; > break; > } > @@ -204,7 +199,6 @@ void ion_close_buffer_fd(struct ion_buffer_info *ion_info) > /* Finally, close the client fd */ > if (ion_info->ionfd > 0) > close(ion_info->ionfd); > - printf("<%s>: buffer release successfully....\n", __func__); > } > } > > Thanks Laura. I will queue this up for 4.17-rc1. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: shuah@kernel.org (Shuah Khan) Date: Mon, 26 Feb 2018 09:54:37 -0700 Subject: [PATCH 1/2] selftests: ion: Remove some prints In-Reply-To: <20180216012445.17264-2-labbott@redhat.com> References: <20180216012445.17264-1-labbott@redhat.com> <20180216012445.17264-2-labbott@redhat.com> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20180226165437.heq3Ifbgxl2WqA0p5Xuvdvykk6dcqdJVsxhPXcMn3As@z> On 02/15/2018 06:24 PM, Laura Abbott wrote: > There's no need to print messages each time we alloc and free. Remove them. > > Signed-off-by: Laura Abbott > --- > tools/testing/selftests/android/ion/ionutils.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/tools/testing/selftests/android/ion/ionutils.c b/tools/testing/selftests/android/ion/ionutils.c > index ce69c14f51fa..7d1d37c4ef6a 100644 > --- a/tools/testing/selftests/android/ion/ionutils.c > +++ b/tools/testing/selftests/android/ion/ionutils.c > @@ -80,11 +80,6 @@ int ion_export_buffer_fd(struct ion_buffer_info *ion_info) > heap_id = MAX_HEAP_COUNT + 1; > for (i = 0; i < query.cnt; i++) { > if (heap_data[i].type == ion_info->heap_type) { > - printf("--------------------------------------\n"); > - printf("heap type: %d\n", heap_data[i].type); > - printf(" heap id: %d\n", heap_data[i].heap_id); > - printf("heap name: %s\n", heap_data[i].name); > - printf("--------------------------------------\n"); > heap_id = heap_data[i].heap_id; > break; > } > @@ -204,7 +199,6 @@ void ion_close_buffer_fd(struct ion_buffer_info *ion_info) > /* Finally, close the client fd */ > if (ion_info->ionfd > 0) > close(ion_info->ionfd); > - printf("<%s>: buffer release successfully....\n", __func__); > } > } > > Thanks Laura. I will queue this up for 4.17-rc1. thanks, -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH 1/2] selftests: ion: Remove some prints Date: Mon, 26 Feb 2018 09:54:37 -0700 Message-ID: References: <20180216012445.17264-1-labbott@redhat.com> <20180216012445.17264-2-labbott@redhat.com> Reply-To: shuah@kernel.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180216012445.17264-2-labbott@redhat.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Laura Abbott , Sumit Semwal Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Todd Kjos , dri-devel@lists.freedesktop.org, Chris Wilson , Liam Mark , linux-kselftest@vger.kernel.org, Shuah Khan , Shuah Khan List-Id: dri-devel@lists.freedesktop.org On 02/15/2018 06:24 PM, Laura Abbott wrote: > There's no need to print messages each time we alloc and free. Remove them. > > Signed-off-by: Laura Abbott > --- > tools/testing/selftests/android/ion/ionutils.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/tools/testing/selftests/android/ion/ionutils.c b/tools/testing/selftests/android/ion/ionutils.c > index ce69c14f51fa..7d1d37c4ef6a 100644 > --- a/tools/testing/selftests/android/ion/ionutils.c > +++ b/tools/testing/selftests/android/ion/ionutils.c > @@ -80,11 +80,6 @@ int ion_export_buffer_fd(struct ion_buffer_info *ion_info) > heap_id = MAX_HEAP_COUNT + 1; > for (i = 0; i < query.cnt; i++) { > if (heap_data[i].type == ion_info->heap_type) { > - printf("--------------------------------------\n"); > - printf("heap type: %d\n", heap_data[i].type); > - printf(" heap id: %d\n", heap_data[i].heap_id); > - printf("heap name: %s\n", heap_data[i].name); > - printf("--------------------------------------\n"); > heap_id = heap_data[i].heap_id; > break; > } > @@ -204,7 +199,6 @@ void ion_close_buffer_fd(struct ion_buffer_info *ion_info) > /* Finally, close the client fd */ > if (ion_info->ionfd > 0) > close(ion_info->ionfd); > - printf("<%s>: buffer release successfully....\n", __func__); > } > } > > Thanks Laura. I will queue this up for 4.17-rc1. thanks, -- Shuah