Re: [PATCH net] selftests: net: update netfilter netlink config

[Fernando Fernandez Mancera <fmancera@suse.de>]

On 9/17/26 4:17 AM, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
> 
> Since commit d4349ba9872d ("netfilter: allow nfnetlink built-in only"),
> NETFILTER_NETLINK was changed to a bool. Use 'y' instead of 'm'.
> Otherwise the build emits:
> 
>    .config:5688:warning: symbol value 'm' invalid for NETFILTER_NETLINK
> 
> Fixes: d4349ba9872d ("netfilter: allow nfnetlink built-in only")
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>

Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>

Thanks!

> ---
> This is a simple update addressing the same issue, so I’d like to post it
> directly to netdev instead of bothering two separate subsystems
> (mptcp and netfilter).
> ---
>   tools/testing/selftests/net/mptcp/config     | 2 +-
>   tools/testing/selftests/net/netfilter/config | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
> index 59051ee2a986..bb9c4c97c620 100644
> --- a/tools/testing/selftests/net/mptcp/config
> +++ b/tools/testing/selftests/net/mptcp/config
> @@ -18,7 +18,7 @@ CONFIG_NET_CLS_ACT=y
>   CONFIG_NET_CLS_FW=m
>   CONFIG_NETFILTER=y
>   CONFIG_NETFILTER_ADVANCED=y
> -CONFIG_NETFILTER_NETLINK=m
> +CONFIG_NETFILTER_NETLINK=y
>   CONFIG_NETFILTER_XTABLES=m
>   CONFIG_NETFILTER_XTABLES_LEGACY=y
>   CONFIG_NETFILTER_XT_MATCH_BPF=m
> diff --git a/tools/testing/selftests/net/netfilter/config b/tools/testing/selftests/net/netfilter/config
> index c3c121b6f300..629b2b29ed1a 100644
> --- a/tools/testing/selftests/net/netfilter/config
> +++ b/tools/testing/selftests/net/netfilter/config
> @@ -44,7 +44,7 @@ CONFIG_NET_CLS_U32=m
>   CONFIG_NETDEVSIM=m
>   CONFIG_NETFILTER=y
>   CONFIG_NETFILTER_ADVANCED=y
> -CONFIG_NETFILTER_NETLINK=m
> +CONFIG_NETFILTER_NETLINK=y
>   CONFIG_NETFILTER_NETLINK_QUEUE=m
>   CONFIG_NETFILTER_SYNPROXY=m
>   CONFIG_NETFILTER_XTABLES=m
> 
> ---
> base-commit: 1dd85662fee6e2ac580b1c4f9a0c0a7ae6e31f0e
> change-id: 20260917-selftest_config-286bdd44b22b
> 
> Best regards,