From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC6FBC63777 for ; Mon, 30 Nov 2020 18:20:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96309206F9 for ; Mon, 30 Nov 2020 18:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729421AbgK3SUP (ORCPT ); Mon, 30 Nov 2020 13:20:15 -0500 Received: from mga17.intel.com ([192.55.52.151]:56796 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727692AbgK3SUO (ORCPT ); Mon, 30 Nov 2020 13:20:14 -0500 IronPort-SDR: FepOsq3Q86AJGB4QAwLSxw9M1P3xKZUG+FPKrrCmbaOrxtLHJbyZZxA+1S38d4grrsBCA/7MmC KYK0qPyisyhQ== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="152517672" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="152517672" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 10:19:33 -0800 IronPort-SDR: XS1ISZYLRuHr2DP6wa+hnr2WbMlBroaPLFVMDoyVIDoBZGj3fB2+pzVl69W66H0oG/Gb4RGpz7 zALQS1ilcxMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="314662861" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 30 Nov 2020 10:19:33 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 30 Nov 2020 10:19:33 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 30 Nov 2020 10:19:32 -0800 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.1713.004; Mon, 30 Nov 2020 10:19:32 -0800 From: "Derrick, Jonathan" To: "helgaas@kernel.org" , "David.Laight@ACULAB.COM" CC: "heiko@sntech.de" , "f.fainelli@gmail.com" , "kw@linux.com" , "robh@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "thomas.petazzoni@bootlin.com" , "toan@os.amperecomputing.com" , "rjui@broadcom.com" , "Jonathan.Cameron@huawei.com" , "jonnyc@amazon.com" , "bcm-kernel-feedback-list@broadcom.com" , "sbranden@broadcom.com" , "nsaenzjulienne@suse.de" , "wangzhou1@hisilicon.com" , "rrichter@marvell.com" , "will@kernel.org" , "shawn.lin@rock-chips.com" , "linux-rpi-kernel@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "lorenzo.pieralisi@arm.com" , "linux-pci@vger.kernel.org" , "linux-rockchip@lists.infradead.org" , "paulus@samba.org" , "bhelgaas@google.com" , "michal.simek@xilinx.com" Subject: Re: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Thread-Topic: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Thread-Index: AQHWxqR5T+KTElL2ckS1iiGCxL3tTang6SEAgACKCACAABBbgA== Date: Mon, 30 Nov 2020 18:19:32 +0000 Message-ID: References: <20201130172058.GA1088391@bjorn-Precision-5520> In-Reply-To: <20201130172058.GA1088391@bjorn-Precision-5520> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.132] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org T24gTW9uLCAyMDIwLTExLTMwIGF0IDExOjIwIC0wNjAwLCBCam9ybiBIZWxnYWFzIHdyb3RlOg0K PiBPbiBNb24sIE5vdiAzMCwgMjAyMCBhdCAwOTowNjo1NkFNICswMDAwLCBEYXZpZCBMYWlnaHQg d3JvdGU6DQo+ID4gRnJvbTogS3J6eXN6dG9mIFdpbGN6eW5za2kNCj4gPiA+IFNlbnQ6IDI5IE5v dmVtYmVyIDIwMjAgMjM6MDgNCj4gPiA+IA0KPiA+ID4gVXNlICJ2b2lkIF9faW9tZW0iIGluc3Rl YWQgImNoYXIgX19pb21lbSIgcG9pbnRlciB0eXBlIHdoZW4gd29ya2luZyB3aXRoDQo+ID4gPiB0 aGUgYWNjZXNzb3IgZnVuY3Rpb25zICh3aXRoIG5hbWVzIGxpa2UgcmVhZGIoKSBvciB3cml0ZWwo KSwgZXRjLikgdG8NCj4gPiA+IGJldHRlciBtYXRjaCBhIGdpdmVuIGFjY2Vzc29yIGZ1bmN0aW9u IHNpZ25hdHVyZSB3aGVyZSBjb21tb25seSB0aGUNCj4gPiA+IGFkZHJlc3MgcG9pbnRpbmcgdG8g YW4gSS9PIG1lbW9yeSByZWdpb24gd291bGQgYmUgYSAidm9pZCBfX2lvbWVtIg0KPiA+ID4gcG9p bnRlci4NCj4gPiANCj4gPiBJU1RNIHRoYXQgaXMgaGVhZGluZyBpbiB0aGUgd3JvbmcgZGlyZWN0 aW9uLg0KPiA+IA0KPiA+IEkgdGhpbmsgKGZvcm0gdGhlIHZhcmlhYmxlIG5hbWVzIGV0YykgdGhh dCB0aGVzZSBhcmUgcG9pbnRlcnMNCj4gPiB0byBzcGVjaWZpYyByZWdpc3RlcnMuDQo+ID4gDQo+ ID4gU28gd2hhdCB5b3Ugb3VnaHQgdG8gaGF2ZSBpcyBhIHR5cGUgZm9yIHRoYXQgcmVnaXN0ZXIg YmxvY2suDQo+ID4gVHlwaWNhbGx5IHRoaXMgaXMgYWN0dWFsbHkgYSBzdHJ1Y3R1cmUgLSB0byBn aXZlIHNvbWUgdHlwZQ0KPiA+IGNoZWNraW5nIHRoYXQgdGhlIG9mZnNldHMgYXJlIGJlaW5nIHVz ZWQgd2l0aCB0aGUgY29ycmVjdA0KPiA+IGJhc2UgYWRkcmVzcy4NCj4gDQo+IEluIHRoaXMgY2Fz ZSwgImNmZ2JhciIgaXMgbm90IHJlYWxseSBhIHBvaW50ZXIgdG8gYSByZWdpc3RlcjsgaXQncyB0 aGUNCj4gYWRkcmVzcyBvZiBtZW1vcnktbWFwcGVkIGNvbmZpZyBzcGFjZS4gIFRoZSBWTUQgaGFy ZHdhcmUgdHVybnMNCj4gYWNjZXNzZXMgdG8gdGhhdCBzcGFjZSBpbnRvIFBDSSBjb25maWcgdHJh bnNhY3Rpb25zIG9uIGl0cyBzZWNvbmRhcnkNCj4gc2lkZS4gIHhnZW5lX3BjaWVfZ2V0X2NmZ19i YXNlKCkgYW5kIGJyY21fcGNpZV9tYXBfY29uZigpIGFyZSBzaW1pbGFyDQo+IHNpdHVhdGlvbnMg YW5kIHVzZSAidm9pZCAqIi4NCj4gDQo+IEJqb3JuDQoNClllcyBpdCdzIGp1c3QgdGhlIHBhc3N0 aHJvdWdoIHdpbmRvdyBmb3IgUENJIGNvbmZpZyBidXMgb3BzLg0KDQpSZXZpZXdlZC1ieTogSm9u IERlcnJpY2sgPGpvbmF0aGFuLmRlcnJpY2tAaW50ZWwuY29tPg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13683C63777 for ; Mon, 30 Nov 2020 18:19:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAFB5206F9 for ; Mon, 30 Nov 2020 18:19:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VTzJvUqt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAFB5206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7eQj5+w+b1mkaZb9Kq7Ae5npsL2W6plr3+hMaHjolf4=; b=VTzJvUqt03H5C0RLoTkybsZx1 YcLSyk1P0lZvjmoZVbkJUXhUEzcsCN9ZibGifq1kcQGJj8uhusBCNXwXzMh5rc+94OFKA4+CfkhEs BTUBiKU1qngsGlWzqIFklG9dabJCSKTDLbtFSGFm7Xtpm6Zw1n/j0SY/1Q3Ono5jsw6wrSzvtSHJ+ sNnzu75T7Dy9V09wrWB/wYTlSALkYNITB1/QOOb+iS7qXzdcson95hOR/vpBzrrxVgx15j6Qrh6M8 aASu/rkjQOFJvWJaNT2wlxnznKHEk5BgdMoQ2+0bCyqlJJT95iA0co1sQnzZvCrCQYb45XAKfg3lk bZBlUFtIw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjnm0-0001y4-9n; Mon, 30 Nov 2020 18:19:40 +0000 Received: from mga09.intel.com ([134.134.136.24]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjnly-0001xB-CM; Mon, 30 Nov 2020 18:19:39 +0000 IronPort-SDR: oBlkrvXrjXBlrYGizjqLOmAlGz/NXMnDHjknTp9dVMb7Cfyo6n8GBsxTHBY2m0zOcK4ZaJjhBv Wu2p9FX+XytQ== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="172843615" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="172843615" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 10:19:34 -0800 IronPort-SDR: XS1ISZYLRuHr2DP6wa+hnr2WbMlBroaPLFVMDoyVIDoBZGj3fB2+pzVl69W66H0oG/Gb4RGpz7 zALQS1ilcxMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="314662861" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 30 Nov 2020 10:19:33 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 30 Nov 2020 10:19:33 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 30 Nov 2020 10:19:32 -0800 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.1713.004; Mon, 30 Nov 2020 10:19:32 -0800 From: "Derrick, Jonathan" To: "helgaas@kernel.org" , "David.Laight@ACULAB.COM" Subject: Re: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Thread-Topic: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Thread-Index: AQHWxqR5T+KTElL2ckS1iiGCxL3tTang6SEAgACKCACAABBbgA== Date: Mon, 30 Nov 2020 18:19:32 +0000 Message-ID: References: <20201130172058.GA1088391@bjorn-Precision-5520> In-Reply-To: <20201130172058.GA1088391@bjorn-Precision-5520> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.132] Content-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_131938_567573_2CC7FEFF X-CRM114-Status: GOOD ( 23.57 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "kw@linux.com" , "heiko@sntech.de" , "linux-pci@vger.kernel.org" , "shawn.lin@rock-chips.com" , "paulus@samba.org" , "thomas.petazzoni@bootlin.com" , "jonnyc@amazon.com" , "toan@os.amperecomputing.com" , "will@kernel.org" , "robh@kernel.org" , "f.fainelli@gmail.com" , "michal.simek@xilinx.com" , "linux-rockchip@lists.infradead.org" , "bcm-kernel-feedback-list@broadcom.com" , "rjui@broadcom.com" , "lorenzo.pieralisi@arm.com" , "linux-rpi-kernel@lists.infradead.org" , "Jonathan.Cameron@huawei.com" , "bhelgaas@google.com" , "linux-arm-kernel@lists.infradead.org" , "sbranden@broadcom.com" , "wangzhou1@hisilicon.com" , "rrichter@marvell.com" , "linuxppc-dev@lists.ozlabs.org" , "nsaenzjulienne@suse.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Mon, 2020-11-30 at 11:20 -0600, Bjorn Helgaas wrote: > On Mon, Nov 30, 2020 at 09:06:56AM +0000, David Laight wrote: > > From: Krzysztof Wilczynski > > > Sent: 29 November 2020 23:08 > > > > > > Use "void __iomem" instead "char __iomem" pointer type when working with > > > the accessor functions (with names like readb() or writel(), etc.) to > > > better match a given accessor function signature where commonly the > > > address pointing to an I/O memory region would be a "void __iomem" > > > pointer. > > > > ISTM that is heading in the wrong direction. > > > > I think (form the variable names etc) that these are pointers > > to specific registers. > > > > So what you ought to have is a type for that register block. > > Typically this is actually a structure - to give some type > > checking that the offsets are being used with the correct > > base address. > > In this case, "cfgbar" is not really a pointer to a register; it's the > address of memory-mapped config space. The VMD hardware turns > accesses to that space into PCI config transactions on its secondary > side. xgene_pcie_get_cfg_base() and brcm_pcie_map_conf() are similar > situations and use "void *". > > Bjorn Yes it's just the passthrough window for PCI config bus ops. Reviewed-by: Jon Derrick _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1736CC63777 for ; Mon, 30 Nov 2020 18:22:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FC78206F9 for ; Mon, 30 Nov 2020 18:22:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FC78206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4ClD8l5f6vzDqT3 for ; Tue, 1 Dec 2020 05:21:59 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=intel.com (client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=jonathan.derrick@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4ClD685jyczDqkP for ; Tue, 1 Dec 2020 05:19:35 +1100 (AEDT) IronPort-SDR: UnQvwOUE3GNdPLwxqqn/3fffwZBLor9hzxlIPPyefBIPDyRwNyECogU550rIwy9FFvVDO5Dz13 VKIHBr5vUSQw== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="169187609" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="169187609" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 10:19:33 -0800 IronPort-SDR: XS1ISZYLRuHr2DP6wa+hnr2WbMlBroaPLFVMDoyVIDoBZGj3fB2+pzVl69W66H0oG/Gb4RGpz7 zALQS1ilcxMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="314662861" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 30 Nov 2020 10:19:33 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 30 Nov 2020 10:19:33 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 30 Nov 2020 10:19:32 -0800 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.1713.004; Mon, 30 Nov 2020 10:19:32 -0800 From: "Derrick, Jonathan" To: "helgaas@kernel.org" , "David.Laight@ACULAB.COM" Subject: Re: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Thread-Topic: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Thread-Index: AQHWxqR5T+KTElL2ckS1iiGCxL3tTang6SEAgACKCACAABBbgA== Date: Mon, 30 Nov 2020 18:19:32 +0000 Message-ID: References: <20201130172058.GA1088391@bjorn-Precision-5520> In-Reply-To: <20201130172058.GA1088391@bjorn-Precision-5520> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.132] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "kw@linux.com" , "heiko@sntech.de" , "linux-pci@vger.kernel.org" , "shawn.lin@rock-chips.com" , "paulus@samba.org" , "thomas.petazzoni@bootlin.com" , "jonnyc@amazon.com" , "toan@os.amperecomputing.com" , "will@kernel.org" , "robh@kernel.org" , "f.fainelli@gmail.com" , "michal.simek@xilinx.com" , "linux-rockchip@lists.infradead.org" , "bcm-kernel-feedback-list@broadcom.com" , "rjui@broadcom.com" , "lorenzo.pieralisi@arm.com" , "linux-rpi-kernel@lists.infradead.org" , "Jonathan.Cameron@huawei.com" , "bhelgaas@google.com" , "linux-arm-kernel@lists.infradead.org" , "sbranden@broadcom.com" , "wangzhou1@hisilicon.com" , "rrichter@marvell.com" , "linuxppc-dev@lists.ozlabs.org" , "nsaenzjulienne@suse.de" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" T24gTW9uLCAyMDIwLTExLTMwIGF0IDExOjIwIC0wNjAwLCBCam9ybiBIZWxnYWFzIHdyb3RlOg0K PiBPbiBNb24sIE5vdiAzMCwgMjAyMCBhdCAwOTowNjo1NkFNICswMDAwLCBEYXZpZCBMYWlnaHQg d3JvdGU6DQo+ID4gRnJvbTogS3J6eXN6dG9mIFdpbGN6eW5za2kNCj4gPiA+IFNlbnQ6IDI5IE5v dmVtYmVyIDIwMjAgMjM6MDgNCj4gPiA+IA0KPiA+ID4gVXNlICJ2b2lkIF9faW9tZW0iIGluc3Rl YWQgImNoYXIgX19pb21lbSIgcG9pbnRlciB0eXBlIHdoZW4gd29ya2luZyB3aXRoDQo+ID4gPiB0 aGUgYWNjZXNzb3IgZnVuY3Rpb25zICh3aXRoIG5hbWVzIGxpa2UgcmVhZGIoKSBvciB3cml0ZWwo KSwgZXRjLikgdG8NCj4gPiA+IGJldHRlciBtYXRjaCBhIGdpdmVuIGFjY2Vzc29yIGZ1bmN0aW9u IHNpZ25hdHVyZSB3aGVyZSBjb21tb25seSB0aGUNCj4gPiA+IGFkZHJlc3MgcG9pbnRpbmcgdG8g YW4gSS9PIG1lbW9yeSByZWdpb24gd291bGQgYmUgYSAidm9pZCBfX2lvbWVtIg0KPiA+ID4gcG9p bnRlci4NCj4gPiANCj4gPiBJU1RNIHRoYXQgaXMgaGVhZGluZyBpbiB0aGUgd3JvbmcgZGlyZWN0 aW9uLg0KPiA+IA0KPiA+IEkgdGhpbmsgKGZvcm0gdGhlIHZhcmlhYmxlIG5hbWVzIGV0YykgdGhh dCB0aGVzZSBhcmUgcG9pbnRlcnMNCj4gPiB0byBzcGVjaWZpYyByZWdpc3RlcnMuDQo+ID4gDQo+ ID4gU28gd2hhdCB5b3Ugb3VnaHQgdG8gaGF2ZSBpcyBhIHR5cGUgZm9yIHRoYXQgcmVnaXN0ZXIg YmxvY2suDQo+ID4gVHlwaWNhbGx5IHRoaXMgaXMgYWN0dWFsbHkgYSBzdHJ1Y3R1cmUgLSB0byBn aXZlIHNvbWUgdHlwZQ0KPiA+IGNoZWNraW5nIHRoYXQgdGhlIG9mZnNldHMgYXJlIGJlaW5nIHVz ZWQgd2l0aCB0aGUgY29ycmVjdA0KPiA+IGJhc2UgYWRkcmVzcy4NCj4gDQo+IEluIHRoaXMgY2Fz ZSwgImNmZ2JhciIgaXMgbm90IHJlYWxseSBhIHBvaW50ZXIgdG8gYSByZWdpc3RlcjsgaXQncyB0 aGUNCj4gYWRkcmVzcyBvZiBtZW1vcnktbWFwcGVkIGNvbmZpZyBzcGFjZS4gIFRoZSBWTUQgaGFy ZHdhcmUgdHVybnMNCj4gYWNjZXNzZXMgdG8gdGhhdCBzcGFjZSBpbnRvIFBDSSBjb25maWcgdHJh bnNhY3Rpb25zIG9uIGl0cyBzZWNvbmRhcnkNCj4gc2lkZS4gIHhnZW5lX3BjaWVfZ2V0X2NmZ19i YXNlKCkgYW5kIGJyY21fcGNpZV9tYXBfY29uZigpIGFyZSBzaW1pbGFyDQo+IHNpdHVhdGlvbnMg YW5kIHVzZSAidm9pZCAqIi4NCj4gDQo+IEJqb3JuDQoNClllcyBpdCdzIGp1c3QgdGhlIHBhc3N0 aHJvdWdoIHdpbmRvdyBmb3IgUENJIGNvbmZpZyBidXMgb3BzLg0KDQpSZXZpZXdlZC1ieTogSm9u IERlcnJpY2sgPGpvbmF0aGFuLmRlcnJpY2tAaW50ZWwuY29tPg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4525FC64E7B for ; Mon, 30 Nov 2020 18:20:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6110206F9 for ; Mon, 30 Nov 2020 18:20:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wQuki51L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6110206F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9ESmqH5hXh3oyf6Huexf0Hd6Y1odcAmBekbyenFxVg4=; b=wQuki51LPPH/Nrjqn176yVWgk 1+P0BVVKlthVC3S6lXj3WKf4FYJP4XLn38CtEAHCZThS4g8VLlIqkKfiUUAk+KLGpmP9vPSMkCxzh SZ2yS+7v8wkIvPyJ98XdNUiWIbF2qruPa3Mf2LQW7gPBerd0C82HzLDKmW5yBVwLCSxu1FM9Kgu+e LYqQJPjADJXLEe7RWtNyihhrx2luFJINTuv9eobS+LfpPRkyQGyprbVjwJj2lRSyGCpupWRdvd7EH z/WKoQCDoUfDeyjNH6Smy8k1YXljyVbUsmF1wwirWUBbB96mlkDy/QQhOB8zP0fMsMXNLymANbyJj SMhWmGi9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjnm1-0001yC-N3; Mon, 30 Nov 2020 18:19:41 +0000 Received: from mga09.intel.com ([134.134.136.24]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjnly-0001xB-CM; Mon, 30 Nov 2020 18:19:39 +0000 IronPort-SDR: oBlkrvXrjXBlrYGizjqLOmAlGz/NXMnDHjknTp9dVMb7Cfyo6n8GBsxTHBY2m0zOcK4ZaJjhBv Wu2p9FX+XytQ== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="172843615" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="172843615" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 10:19:34 -0800 IronPort-SDR: XS1ISZYLRuHr2DP6wa+hnr2WbMlBroaPLFVMDoyVIDoBZGj3fB2+pzVl69W66H0oG/Gb4RGpz7 zALQS1ilcxMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="314662861" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 30 Nov 2020 10:19:33 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 30 Nov 2020 10:19:33 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 30 Nov 2020 10:19:32 -0800 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.1713.004; Mon, 30 Nov 2020 10:19:32 -0800 From: "Derrick, Jonathan" To: "helgaas@kernel.org" , "David.Laight@ACULAB.COM" Subject: Re: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Thread-Topic: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Thread-Index: AQHWxqR5T+KTElL2ckS1iiGCxL3tTang6SEAgACKCACAABBbgA== Date: Mon, 30 Nov 2020 18:19:32 +0000 Message-ID: References: <20201130172058.GA1088391@bjorn-Precision-5520> In-Reply-To: <20201130172058.GA1088391@bjorn-Precision-5520> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.132] Content-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_131938_567573_2CC7FEFF X-CRM114-Status: GOOD ( 23.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "kw@linux.com" , "heiko@sntech.de" , "linux-pci@vger.kernel.org" , "shawn.lin@rock-chips.com" , "paulus@samba.org" , "thomas.petazzoni@bootlin.com" , "jonnyc@amazon.com" , "toan@os.amperecomputing.com" , "will@kernel.org" , "robh@kernel.org" , "f.fainelli@gmail.com" , "michal.simek@xilinx.com" , "linux-rockchip@lists.infradead.org" , "bcm-kernel-feedback-list@broadcom.com" , "rjui@broadcom.com" , "lorenzo.pieralisi@arm.com" , "linux-rpi-kernel@lists.infradead.org" , "Jonathan.Cameron@huawei.com" , "bhelgaas@google.com" , "linux-arm-kernel@lists.infradead.org" , "sbranden@broadcom.com" , "wangzhou1@hisilicon.com" , "rrichter@marvell.com" , "linuxppc-dev@lists.ozlabs.org" , "nsaenzjulienne@suse.de" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-11-30 at 11:20 -0600, Bjorn Helgaas wrote: > On Mon, Nov 30, 2020 at 09:06:56AM +0000, David Laight wrote: > > From: Krzysztof Wilczynski > > > Sent: 29 November 2020 23:08 > > > > > > Use "void __iomem" instead "char __iomem" pointer type when working with > > > the accessor functions (with names like readb() or writel(), etc.) to > > > better match a given accessor function signature where commonly the > > > address pointing to an I/O memory region would be a "void __iomem" > > > pointer. > > > > ISTM that is heading in the wrong direction. > > > > I think (form the variable names etc) that these are pointers > > to specific registers. > > > > So what you ought to have is a type for that register block. > > Typically this is actually a structure - to give some type > > checking that the offsets are being used with the correct > > base address. > > In this case, "cfgbar" is not really a pointer to a register; it's the > address of memory-mapped config space. The VMD hardware turns > accesses to that space into PCI config transactions on its secondary > side. xgene_pcie_get_cfg_base() and brcm_pcie_map_conf() are similar > situations and use "void *". > > Bjorn Yes it's just the passthrough window for PCI config bus ops. Reviewed-by: Jon Derrick _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel