All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arun KS <arunks@codeaurora.org>
To: Oscar Salvador <osalvador@techadventures.net>
Cc: kys@microsoft.com, haiyangz@microsoft.com,
	sthemmin@microsoft.com, boris.ostrovsky@oracle.com,
	jgross@suse.com, akpm@linux-foundation.org,
	dan.j.williams@intel.com, mhocko@suse.com, vbabka@suse.cz,
	iamjoonsoo.kim@lge.com, gregkh@linuxfoundation.org,
	osalvador@suse.de, malat@debian.org,
	kirill.shutemov@linux.intel.com, jrdr.linux@gmail.com,
	yasu.isimatu@gmail.com, mgorman@techsingularity.net,
	aaron.lu@intel.com, devel@linuxdriverproject.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	xen-devel@lists.xenproject.org, vatsa@codeaurora.org,
	vinmenon@codeaurora.org, getarunks@gmail.com
Subject: Re: [PATCH v3] memory_hotplug: Free pages as higher order
Date: Thu, 27 Sep 2018 13:39:41 +0530	[thread overview]
Message-ID: <f56a750a54eadf76c45d3065622d4cbf@codeaurora.org> (raw)
In-Reply-To: <20180927070957.GA19369@techadventures.net>

On 2018-09-27 12:39, Oscar Salvador wrote:
> On Thu, Sep 27, 2018 at 12:28:50PM +0530, Arun KS wrote:
>> +	__free_pages_boot_core(page, order);
> 
Hi,

> I am not sure, but if we are going to use that function from the
> memory-hotplug code,
> we might want to rename that function to something more generic?
> The word "boot" suggests that this is only called from the boot stage.
I ll rename it to __free_pages_core()

> 
> And what about the prefetch operations?
> I saw that you removed them in your previous patch and that had some
> benefits [1].
> 
> Should we remove them here as well?
Sure. Will update this as well.

Thanks,
Arun
> 
> [1] https://patchwork.kernel.org/patch/10613359/
> 
> Thanks

  parent reply	other threads:[~2018-09-27  8:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-27  6:58 [PATCH v3] memory_hotplug: Free pages as higher order Arun KS
2018-09-27  7:09 ` Oscar Salvador
2018-09-27  7:09 ` Oscar Salvador
2018-09-27  8:09   ` Arun KS
2018-09-27  8:09   ` Arun KS [this message]
2018-09-27  7:11 ` Juergen Gross
2018-09-27  8:11   ` Arun KS
2018-09-27  8:11   ` Arun KS
2018-09-27  7:11 ` Juergen Gross
  -- strict thread matches above, loose matches on Subject: below --
2018-09-27  6:58 Arun KS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f56a750a54eadf76c45d3065622d4cbf@codeaurora.org \
    --to=arunks@codeaurora.org \
    --cc=aaron.lu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=dan.j.williams@intel.com \
    --cc=devel@linuxdriverproject.org \
    --cc=getarunks@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jgross@suse.com \
    --cc=jrdr.linux@gmail.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=malat@debian.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=osalvador@techadventures.net \
    --cc=sthemmin@microsoft.com \
    --cc=vatsa@codeaurora.org \
    --cc=vbabka@suse.cz \
    --cc=vinmenon@codeaurora.org \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yasu.isimatu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.