From: Hayes Wang <hayeswang@realtek.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
nic_swsd <nic_swsd@realtek.com>
Subject: RE: [RFC PATCH 3/4] r8169: support CMAC
Date: Fri, 3 Dec 2021 07:57:09 +0000 [thread overview]
Message-ID: <f56cc112d886490792fcb98c8faadff6@realtek.com> (raw)
In-Reply-To: <3b610e64-9013-5c8c-93e9-95994d79f128@gmail.com>
Heiner Kallweit <hkallweit1@gmail.com>
> Sent: Tuesday, November 30, 2021 4:47 AM
> To: Hayes Wang <hayeswang@realtek.com>; Jakub Kicinski <kuba@kernel.org>;
[...]
> > +struct rtl_dash {
> > + struct rtl8169_private *tp;
> > + struct pci_dev *pdev_cmac;
> > + void __iomem *cmac_ioaddr;
> > + struct cmac_desc *tx_desc, *rx_desc;
> > + struct page *tx_buf, *rx_buf;
> > + struct dash_tx_info tx_info[CMAC_DESC_NUM];
> > + struct tasklet_struct tl;
>
> Please see the following in include/linux/interrupt.h:
>
> /* Tasklets --- multithreaded analogue of BHs.
>
> This API is deprecated. Please consider using threaded IRQs instead:
How about replacing the tasklet with work?
It seems that the bottom half of threaded IRQ
is the work, too.
Best Regards,
Hayes
next prev parent reply other threads:[~2021-12-03 7:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 10:13 [RFC PATCH 0/4] r8169: support dash Hayes Wang
2021-11-29 10:13 ` [RFC PATCH 1/4] r8169: remove the relative code about dash Hayes Wang
2021-11-29 10:13 ` [RFC PATCH 2/4] r8169: add type2 access functions Hayes Wang
2021-11-29 10:13 ` [RFC PATCH 3/4] r8169: support CMAC Hayes Wang
2021-11-29 15:47 ` kernel test robot
2021-11-29 20:46 ` Heiner Kallweit
2021-12-03 7:57 ` Hayes Wang [this message]
2021-12-03 11:37 ` Heiner Kallweit
2021-11-29 10:13 ` [RFC PATCH 4/4] r8169: add sysfs for dash Hayes Wang
2021-12-03 15:15 ` Heiner Kallweit
2021-12-07 6:53 ` Hayes Wang
2021-12-07 7:38 ` Heiner Kallweit
2021-12-07 8:20 ` Hayes Wang
2021-11-29 17:59 ` [Intel-wired-lan] [RFC PATCH 0/4] r8169: support dash Jakub Kicinski
2021-11-29 17:59 ` Jakub Kicinski
2021-12-01 2:57 ` [Intel-wired-lan] " Hayes Wang
2021-12-01 2:57 ` Hayes Wang
2021-12-01 3:09 ` [Intel-wired-lan] " Jakub Kicinski
2021-12-01 3:09 ` Jakub Kicinski
2021-12-03 7:57 ` [Intel-wired-lan] " Hayes Wang
2021-12-03 7:57 ` Hayes Wang
2021-12-03 15:04 ` [Intel-wired-lan] " Jakub Kicinski
2021-12-03 15:04 ` Jakub Kicinski
2021-12-04 1:08 ` [Intel-wired-lan] " Alexander Lobakin
2021-12-04 1:08 ` Alexander Lobakin
2021-12-04 1:32 ` [Intel-wired-lan] " Jakub Kicinski
2021-12-04 1:32 ` Jakub Kicinski
2021-12-07 7:28 ` [Intel-wired-lan] " Hayes Wang
2021-12-07 7:28 ` Hayes Wang
2021-12-08 4:21 ` [Intel-wired-lan] " Jakub Kicinski
2021-12-08 4:21 ` Jakub Kicinski
2021-12-08 7:53 ` [Intel-wired-lan] " Hayes Wang
2021-12-08 7:53 ` Hayes Wang
2021-12-08 21:37 ` [Intel-wired-lan] " Jakub Kicinski
2021-12-08 21:37 ` Jakub Kicinski
2021-12-09 7:14 ` [Intel-wired-lan] " Hayes Wang
2021-12-09 7:14 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f56cc112d886490792fcb98c8faadff6@realtek.com \
--to=hayeswang@realtek.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.