All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Rosen Penev <rosenp@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Linus Walleij <linusw@kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2] powerpc/44x: Set GPIO chip parent
Date: Wed, 20 May 2026 15:15:31 +0200	[thread overview]
Message-ID: <f58abe7e-acf3-44f5-bdc3-3b60a37126c0@kernel.org> (raw)
In-Reply-To: <20260517063754.21819-1-rosenp@gmail.com>



Le 17/05/2026 à 08:37, Rosen Penev a écrit :
> The PPC4xx GPIO driver stopped assigning an explicit parent
> to the gpio_chip when it moved away from of_mm_gpiochip_add_data().
> 
> Restore that association from the platform device so OF GPIO lookup
> can match phandles to the registered gpiochip.
> 
> Tested on: Cisco MX60W. No more probe deferral.
> 
> Assisted-by: Codex:GPT-5.5
> Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>

> ---
>   arch/powerpc/platforms/44x/gpio.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x/gpio.c
> index aea0d913b59d..4413a94cf7a6 100644
> --- a/arch/powerpc/platforms/44x/gpio.c
> +++ b/arch/powerpc/platforms/44x/gpio.c
> @@ -169,6 +169,7 @@ static int ppc4xx_gpio_probe(struct platform_device *ofdev)
>   
>   	gc = &chip->gc;
>   
> +	gc->parent = dev;
>   	gc->base = -1;
>   	gc->ngpio = 32;
>   	gc->direction_input = ppc4xx_gpio_dir_in;


  parent reply	other threads:[~2026-05-20 13:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17  6:37 [PATCHv2] powerpc/44x: Set GPIO chip parent Rosen Penev
2026-05-17 10:47 ` Linus Walleij
2026-05-20 13:15 ` Christophe Leroy (CS GROUP) [this message]
2026-07-17 19:05 ` Rosen Penev
2026-07-30  5:45   ` Christophe Leroy (CS GROUP)
2026-07-31 11:55     ` Madhavan Srinivasan
2026-08-03  6:57 ` Madhavan Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f58abe7e-acf3-44f5-bdc3-3b60a37126c0@kernel.org \
    --to=chleroy@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=rosenp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.