All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: adam.blank.g@gmail.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 0/7] Remove 'extend_recipe_sysroot' from 'BB_HASHEXCLUDE_COMMON'
Date: Wed, 13 May 2026 16:39:55 +0100	[thread overview]
Message-ID: <f59f44f5584cc54bea8813854aeb88ed10ba4014.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAFAffzxnk+YvferrFbRO2O_rrz8FvGbgKAmGewq0Rf=Mxye-cA@mail.gmail.com>

On Thu, 2026-04-30 at 17:15 +0200, Adam Blank via
lists.openembedded.org wrote:
> > 
> > which is a lot of non-trivial change and a lot of extra data in the
> > sigdata file.
> > 
> > Do we really want all of this data to be added into every signature
> > computation?
> > 
> > Are we 100% sure that add the newly added variable dependencies are
> > "safe" and won't trigger sstate cache reuse issues?
> 
> Well, obviously such increase in the visibility of dependencies is
> not a comforting or welcome thing, but let's not forget, that those
> dependencies truly are there :-)
> I'd ask the opposite question: given the extent and nature of the
> relations exposed by this change, do we want to keep wholesale hiding
> them with the current implementation?
> Or in other words, are those particular dependencies (stemming from
> 'extend_recipe_sysroot') so irrelevant for the overall signature and
> sstate management, that it is justifiable to keep ignoring them in
> such a unique way and on such a fundamental level?
> 
> Unless it is truly a desirable situation and the whole subject can be
> dismissed, what would be the recommended way to tackle it?

FWIW I was finally able to isolate one example of a change here which
isn't desired.

For qemu-helper-native, we saw do_fetch change signatures when it
shouldn't really have done. The change was:

basehash changed from ba2bcd325c42f37db9aa87567dbf0ccd217f4f12910558975a9e52e642dd426c to bd5120be022a43e6fd1273a14f0ceda3b72847308d4c4e65bfe91f9fea21683e
Variable SSTATETASKS value changed:
"do_create_package_spdx do_create_recipe_sbom do_create_recipe_spdx do_create_spdx do_deploy_source_date_epoch do_package do_package_qa [-do_package_write_deb-] do_package_write_ipk [-do_package_write_rpm-] do_packagedata do_populate_lic do_populate_sysroot do_recipe_qa"

which was probably a PACKAGE_CLASSES change in configuration triggering
it.

Whether this is the only undesired change in dependencies, I'm not sure
but we do need to track these kinds of issues down.

Cheers,

Richard


  parent reply	other threads:[~2026-05-13 15:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-18 18:34 [PATCH 0/7] Remove 'extend_recipe_sysroot' from 'BB_HASHEXCLUDE_COMMON' Adam Blank
2026-04-18 18:34 ` [PATCH 1/7] package_pkgdata: fix typo to stop calling undefined function Adam Blank
2026-04-18 18:34 ` [PATCH 2/7] staging: add 'vardepsexclude' to 'staging_populate_sysroot_dir' Adam Blank
2026-04-18 18:34 ` [PATCH 3/7] staging: add 'extend_recipe_sysroot' to 'vardepsexclude' Adam Blank
2026-04-18 18:34 ` [PATCH 4/7] cross: " Adam Blank
2026-04-18 18:34 ` [PATCH 5/7] native: " Adam Blank
2026-04-18 18:34 ` [PATCH 6/7] wic-tool: " Adam Blank
2026-04-18 18:34 ` [PATCH 7/7] bitbake.conf: remove 'extend_recipe_sysroot' from BB_HASHEXCLUDE_COMMON Adam Blank
2026-04-30 14:25 ` [OE-core] [PATCH 0/7] Remove 'extend_recipe_sysroot' from 'BB_HASHEXCLUDE_COMMON' Richard Purdie
2026-04-30 15:15   ` Adam Blank
2026-04-30 22:12     ` Richard Purdie
2026-05-13 15:39     ` Richard Purdie [this message]
2026-05-14  9:06       ` Adam Blank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f59f44f5584cc54bea8813854aeb88ed10ba4014.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=adam.blank.g@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.