From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/5] drm/i915: DDI naming standards cleanup Date: Thu, 06 Dec 2012 13:32:43 +0000 Message-ID: References: <1354799562-4060-1-git-send-email-przanoni@gmail.com> <1354799562-4060-3-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id DCADBE66AA for ; Thu, 6 Dec 2012 05:32:56 -0800 (PST) In-Reply-To: <1354799562-4060-3-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Thu, 6 Dec 2012 11:12:40 -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > A big part of the Haswell display code is called intel_ddi_something > while a small part of it is called haswell_something. Being consistent > with the naming standards is a nice thing, so IMHO we should only use > one of the naming standards for everything. > > So instead of converting everything to haswell_something I converted > to ddi_something, which seems more appropriate IMHO. Now our code > looks a little bit more consistent. > > The next step is to move everything to intel_ddi.c. Nak. Now you are really muddying the waters between generation specific paths and one implementation of a display engine. A few chunks are good; where you are indeed checking for the digital ports, but most look silly. -Chris -- Chris Wilson, Intel Open Source Technology Centre