From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: fixup overlay stolen memory leak Date: Mon, 10 Dec 2012 23:50:44 +0000 Message-ID: References: <1355180865-3455-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 8D46CE629D for ; Mon, 10 Dec 2012 15:50:58 -0800 (PST) In-Reply-To: <1355180865-3455-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Tue, 11 Dec 2012 00:07:45 +0100, Daniel Vetter wrote: > We need to clean up the overlay first, before taking down the > stolen memory allocator. > > This regression has been introducec in > > commit 8040513870399f1cb032cb8bc805df5042fedcdf > Author: Chris Wilson > Date: Thu Nov 15 11:32:29 2012 +0000 > > drm/i915: Allocate overlay registers from stolen memory Time for a philosophical debate; I suggest the bug was latent and that the cleanup order was wrong originally. Here, we probably want to cleanup the overlay earlier, before we start tidying up the [pp]gtt etc. Also you want to move the drm_mm_takedown() into i915_gem_cleanup_stolen() for symmetry. -Chris -- Chris Wilson, Intel Open Source Technology Centre