From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: s/intel_modeset_disable/intel_modeset_hw_freeze/ Date: Mon, 17 Dec 2012 15:10:26 +0000 Message-ID: References: <1355755917-7399-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B696E61AE for ; Mon, 17 Dec 2012 07:10:41 -0800 (PST) In-Reply-To: <1355755917-7399-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Mon, 17 Dec 2012 15:51:57 +0100, Daniel Vetter wrote: > Chris Wilson rightfully complained that the name of this function is > misleading - it suggests that it's a generic means to disable all > outputs (and also update all the sw side tracking of the modeset > state). In effect it only disables the hw to quiescent it in the > freeze callbacks for suspend/hibernate - since thaw will read-out the > entire hw state again anyway and so scrap the sw tracking, we don't > need to update the driver state. > > Also add a comment in the code. > > Signed-off-by: Daniel Vetter A nice improvement and stops me from wanting to call it -- it would have been a nasty mistake. -Chris -- Chris Wilson, Intel Open Source Technology Centre