Re: [PATCH i-g-t] lib/intel_wa: Return false for non-root users

[Jani Nikula <jani.nikula@intel.com>]

On Tue, 26 May 2026, Ashutosh Dixit <ashutosh.dixit@intel.com> wrote:
> Under some circurmstancs debugfs reads are initiated by non-root users. In
> these cases, just return false rather than asserting that debugfs could not
> be read.

Who can read debugfs is a distro policy and configuration decision, and
it's not just a binary root/non-root anyway.


BR,
Jani.

>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
>  lib/intel_wa.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lib/intel_wa.c b/lib/intel_wa.c
> index a16ea62a4c..2d0d664f3c 100644
> --- a/lib/intel_wa.c
> +++ b/lib/intel_wa.c
> @@ -47,6 +47,10 @@ bool igt_has_intel_wa(int drm_fd, const char *check_wa)
>  	unsigned int xe;
>  	char name[256];
>  
> +	/* If we are not root, we can't read debugfs, just return false */
> +	if (getuid() != 0)
> +		return false;
> +
>  	debugfs_fd = igt_debugfs_dir(drm_fd);
>  	igt_assert(debugfs_fd >= 0);

-- 
Jani Nikula, Intel