From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EEA4C4332F for ; Tue, 15 Feb 2022 21:01:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244245AbiBOVBZ (ORCPT ); Tue, 15 Feb 2022 16:01:25 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:59980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235440AbiBOVBY (ORCPT ); Tue, 15 Feb 2022 16:01:24 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FFC927FE3; Tue, 15 Feb 2022 13:01:14 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id c4so282622pfl.7; Tue, 15 Feb 2022 13:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wTa2P1MgBvk9m62qPWIOit490TSiIyPTgJSzWGel9bY=; b=Rs1oCdwMxQfYIGJWKXdRuZnB1Ma80VhEoTYeNZtsDwRds0jVEX5HUNouyWNpmnPRKb HrTm06k3tzmIkSplIDIRp684mUUaOheiW/2QtnudPz20P9C8zBxZYOByhkQ4IovjwnNm gHmN6sHkkNbAviSAEYQRkXI65xNnpBRvYb9v2CvjUk5LzL6CqNDk13QeIt9g9sdrQMO/ B/bhfV5Cd2A4UTggseJf4bvZj70EpYruSXaUY9s1t+/VjpfyHxIpuR9qWDQvNJXHl2NT wKbWwhiOGuuRMHGLMGPAETmWCZpAijdKjM52I71SuZ9GXDQYgLSEykguUq2mYOQQClOn tfng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wTa2P1MgBvk9m62qPWIOit490TSiIyPTgJSzWGel9bY=; b=gttvPXs0JJzkW2KEzGutEgF+BslUPfMQ794H4Q+zItntEQ5UYM3uEyryDtJWItXLWz U4tJrhiosY66N2NN8RNT3xcPWbTpIkB++gwCMXQqs2kkIJ1bYWAqA2qksmN3SFu/FevE 8DJH5RB8BsIq50M5KdTyOcdOsXflEKn/8rUbUrrlR3O3zs7+9KUzj2IHMG5lpZ460epa avIBEm4XepWqL5eOLuIIJpr0eobfq5OgdfkA2cNf+1ORZolTkduW9keJGDFAo+AgSQNi L84RlZHie2adCSQx1u8D/lQUws9IFMCtDU23+jsSOkYpXniGustZzDMMfkpUnG9Nm2oP ucYA== X-Gm-Message-State: AOAM5327KHvc+TjiEVXGHNTbezky5tkculQHv+y9MLAhHBpxq6YPwTok 3g6z4Ia3BIInsauGWQ3x7ynOX1SRwYQ= X-Google-Smtp-Source: ABdhPJxyQSAmCDE8WPMyCfUAI8JQM4Z7dyqZXvdtO7dYQTgEBuIQYkUh24QMtAyo8fvuDu2mO6aCAw== X-Received: by 2002:a63:234d:: with SMTP id u13mr628141pgm.128.1644958873451; Tue, 15 Feb 2022 13:01:13 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id w12sm3306242pgl.64.2022.02.15.13.01.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Feb 2022 13:01:12 -0800 (PST) Subject: Re: [PATCH v3 4/8] ARM: dts: bcm283x: fix ethernet node name To: Oleksij Rempel , =?UTF-8?Q?Beno=c3=aet_Cousson?= , "David S. Miller" , Jakub Kicinski , Krzysztof Kozlowski , Nicolas Saenz Julienne , Ray Jui , Rob Herring , Sascha Hauer , Scott Branden , Shawn Guo , Tony Lindgren Cc: kernel@pengutronix.de, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org References: <20220215080937.2263111-1-o.rempel@pengutronix.de> <20220215080937.2263111-4-o.rempel@pengutronix.de> From: Florian Fainelli Message-ID: Date: Tue, 15 Feb 2022 13:01:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220215080937.2263111-4-o.rempel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 2/15/22 12:09 AM, Oleksij Rempel wrote: > It should be "ethernet@x" instead of "usbether@x" > > Signed-off-by: Oleksij Rempel This looks like, a quick grep on the u-boot source code seems to suggest that only one file is assuming that 'usbether@1' is to be used as a node name and the error message does not even match the code it is patching: board/liebherr/xea/xea.c: #ifdef CONFIG_OF_BOARD_SETUP static int fdt_fixup_l2switch(void *blob) { u8 ethaddr[6]; int ret; if (eth_env_get_enetaddr("ethaddr", ethaddr)) { ret = fdt_find_and_setprop(blob, "/ahb@80080000/switch@800f0000", "local-mac-address", ethaddr, 6, 1); if (ret < 0) printf("%s: can't find usbether@1 node: %d\n", __func__, ret); } return 0; } I will wait for the other maintainers on the other patches to provide some feedback, but if all is well, will apply this one soon. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C206C433F5 for ; Tue, 15 Feb 2022 21:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4tpfJwev/cBURjGJm8qM7n1Zp89sv5xT+jDNEJk0WfI=; b=b3d+sptogX1wZIYdafyhGrdXOz Xs2bqiBomctgViwOM/oZK51YdFvB4oliV7M0QWzIeHomGB9qlHBkJ/6U90eVQelW5s6vOMDD/D2hx MFAD+ANj8Dm+3PEZFCuoUSBr1hDkoOmqnrIoi/ag6KUvMSxI3tUKVIbjfALLYiztEWR7wNLN/de9e rjRypDkRWZMlIjremMFxrqN/DeXtPagMIiv4gyXSJvbOwD7pQuuj664hFEgOY9jKdg5XhgmnCKxWy l6fwQbWIwJ/nTSuCidN698Y1B5xfiQrD4qOBt1qLBT51b4d0pDnK8qDX5a6Jn0XxIh0EZ8PBD8DSZ vVZKtE9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK4wn-004ciG-VP; Tue, 15 Feb 2022 21:01:18 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK4wk-004chO-VN; Tue, 15 Feb 2022 21:01:16 +0000 Received: by mail-pf1-x432.google.com with SMTP id d17so348895pfl.0; Tue, 15 Feb 2022 13:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wTa2P1MgBvk9m62qPWIOit490TSiIyPTgJSzWGel9bY=; b=Rs1oCdwMxQfYIGJWKXdRuZnB1Ma80VhEoTYeNZtsDwRds0jVEX5HUNouyWNpmnPRKb HrTm06k3tzmIkSplIDIRp684mUUaOheiW/2QtnudPz20P9C8zBxZYOByhkQ4IovjwnNm gHmN6sHkkNbAviSAEYQRkXI65xNnpBRvYb9v2CvjUk5LzL6CqNDk13QeIt9g9sdrQMO/ B/bhfV5Cd2A4UTggseJf4bvZj70EpYruSXaUY9s1t+/VjpfyHxIpuR9qWDQvNJXHl2NT wKbWwhiOGuuRMHGLMGPAETmWCZpAijdKjM52I71SuZ9GXDQYgLSEykguUq2mYOQQClOn tfng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wTa2P1MgBvk9m62qPWIOit490TSiIyPTgJSzWGel9bY=; b=LlWjSnGXbQ9bmLu9IcDraNZ4+ojiIeaseIw+pLRrPHRipN7JMbb113zJx7qzjmqW0C ebTQ24K4+Oo6n5tUZ7AKBhHyJbHXW6oMwm7iLjQC96dJP9Gb/PDMpanDMDSq7PDOI3/b OFClnb55rUE2bMDSbGgwH7ac1oZT2vDOSDNJxPfY5Si7xt4AKNG6ihxsjxdKRV8ncryu Q9kfBt1BjPzfiUl1/sZGY+ykB0trikbrtPGwSXU5/Zswnf1UVkiRW/ygdxDhCoq6ce/K oBQpI18fxweX7OksUV9FhwCtgIeEiDA9D5DxEoj7Nff4SoOnl3l6XXkFDXUsNMSocVK1 bd0w== X-Gm-Message-State: AOAM530l7GLjotqCCm8/si40Jq7LApWlxCjUypdxLT+arEeFo/ubRumF /gk6skOsHi9I16Ezr8qsi9Q= X-Google-Smtp-Source: ABdhPJxyQSAmCDE8WPMyCfUAI8JQM4Z7dyqZXvdtO7dYQTgEBuIQYkUh24QMtAyo8fvuDu2mO6aCAw== X-Received: by 2002:a63:234d:: with SMTP id u13mr628141pgm.128.1644958873451; Tue, 15 Feb 2022 13:01:13 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id w12sm3306242pgl.64.2022.02.15.13.01.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Feb 2022 13:01:12 -0800 (PST) Subject: Re: [PATCH v3 4/8] ARM: dts: bcm283x: fix ethernet node name To: Oleksij Rempel , =?UTF-8?Q?Beno=c3=aet_Cousson?= , "David S. Miller" , Jakub Kicinski , Krzysztof Kozlowski , Nicolas Saenz Julienne , Ray Jui , Rob Herring , Sascha Hauer , Scott Branden , Shawn Guo , Tony Lindgren Cc: kernel@pengutronix.de, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org References: <20220215080937.2263111-1-o.rempel@pengutronix.de> <20220215080937.2263111-4-o.rempel@pengutronix.de> From: Florian Fainelli Message-ID: Date: Tue, 15 Feb 2022 13:01:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220215080937.2263111-4-o.rempel@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_130115_065543_26FF0448 X-CRM114-Status: GOOD ( 14.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/15/22 12:09 AM, Oleksij Rempel wrote: > It should be "ethernet@x" instead of "usbether@x" > > Signed-off-by: Oleksij Rempel This looks like, a quick grep on the u-boot source code seems to suggest that only one file is assuming that 'usbether@1' is to be used as a node name and the error message does not even match the code it is patching: board/liebherr/xea/xea.c: #ifdef CONFIG_OF_BOARD_SETUP static int fdt_fixup_l2switch(void *blob) { u8 ethaddr[6]; int ret; if (eth_env_get_enetaddr("ethaddr", ethaddr)) { ret = fdt_find_and_setprop(blob, "/ahb@80080000/switch@800f0000", "local-mac-address", ethaddr, 6, 1); if (ret < 0) printf("%s: can't find usbether@1 node: %d\n", __func__, ret); } return 0; } I will wait for the other maintainers on the other patches to provide some feedback, but if all is well, will apply this one soon. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel