From: Christian Zigotzky <chzigotzky@xenosoft.de>
To: Michael Ellerman <mpe@ellerman.id.au>,
Bjorn Helgaas <helgaas@kernel.org>,
Darren Stevens <darren@stevens-zone.net>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Olof Johansson <olof@lixom.net>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: [PATCH] SB600 for the Nemo board has non-zero devices on non-root bus
Date: Sat, 9 Dec 2017 19:03:24 +0100 [thread overview]
Message-ID: <f5fe03d3-87f8-2a2d-2d83-fbefcd489a77@xenosoft.de> (raw)
In-Reply-To: <877etxh1lf.fsf@concordia.ellerman.id.au>
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
On 08 December 2017 at 12:59PM, Michael Ellerman wrote:
>
>> Darren's idea of doing it at the same time you tweak the SB600 "relax
>> pci-e" bit is ideal because then the two pieces are obviously
>> connected and it wouldn't affect any other systems at all.
>
> Yes that would be ideal. That patch is currently out-of-tree I gather,
> but I guess everyone who's using these machines must have that patch
> anyway.
>
> Darren what does that code look like? Can we get it upstream and close
> the loop on this?
>
> cheers
>
Hi Michael,
Please find attached the code.
Thanks,
Christian
[-- Attachment #2: sb600.patch --]
[-- Type: text/x-patch, Size: 2860 bytes --]
diff -rupN a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c
--- a/arch/powerpc/platforms/pasemi/pci.c 2017-11-16 08:18:35.078874462 +0100
+++ b/arch/powerpc/platforms/pasemi/pci.c 2017-11-16 08:17:22.034367975 +0100
@@ -27,6 +27,7 @@
#include <linux/pci.h>
#include <asm/pci-bridge.h>
+#include <asm/isa-bridge.h>
#include <asm/machdep.h>
#include <asm/ppc-pci.h>
@@ -108,6 +109,69 @@ static int workaround_5945(struct pci_bu
return 1;
}
+#ifdef CONFIG_PPC_PASEMI_NEMO
+static int sb600_bus = 5;
+static void __iomem *iob_mapbase = NULL;
+
+static int pa_pxp_read_config(struct pci_bus *bus, unsigned int devfn,
+ int offset, int len, u32 *val);
+
+static void sb600_set_flag(int bus)
+{
+ struct resource res;
+ struct device_node *dn;
+ struct pci_bus *busp;
+ u32 val;
+ int err;
+
+ if (sb600_bus == -1)
+ {
+ busp = pci_find_bus(0, 0);
+ pa_pxp_read_config(busp, PCI_DEVFN(17,0), PCI_SECONDARY_BUS, 1, &val);
+
+ sb600_bus = val;
+
+ printk(KERN_CRIT "NEMO SB600 on bus %d.\n",sb600_bus);
+ }
+
+ if (iob_mapbase == NULL)
+ {
+ dn = of_find_compatible_node(NULL, "isa", "pasemi,1682m-iob");
+ if (!dn)
+ {
+ printk(KERN_CRIT "NEMO SB600 missing iob node\n");
+ return;
+ }
+
+ err = of_address_to_resource(dn, 0, &res);
+ of_node_put(dn);
+
+ if (err)
+ {
+ printk(KERN_CRIT "NEMO SB600 missing resource\n");
+ return;
+ }
+
+ printk(KERN_CRIT "NEMO SB600 IOB base %08lx\n",res.start);
+
+ iob_mapbase = ioremap(res.start + 0x100, 0x94);
+ }
+
+ if (iob_mapbase != NULL)
+ {
+ if (bus == sb600_bus)
+ {
+ out_le32(iob_mapbase + 4, in_le32(iob_mapbase + 4) | 0x800);
+ }
+ else
+ {
+ out_le32(iob_mapbase + 4, in_le32(iob_mapbase + 4) & ~0x800);
+ }
+ }
+}
+#endif
+
+
static int pa_pxp_read_config(struct pci_bus *bus, unsigned int devfn,
int offset, int len, u32 *val)
{
@@ -126,6 +190,10 @@ static int pa_pxp_read_config(struct pci
addr = pa_pxp_cfg_addr(hose, bus->number, devfn, offset);
+#ifdef CONFIG_PPC_PASEMI_NEMO
+ sb600_set_flag(bus->number);
+#endif
+
/*
* Note: the caller has already checked that offset is
* suitably aligned and that len is 1, 2 or 4.
@@ -210,6 +278,9 @@ static int __init pas_add_bridge(struct
/* Interpret the "ranges" property */
pci_process_bridge_OF_ranges(hose, dev, 1);
+ /* Scan for an isa bridge. */
+ isa_bridge_find_early(hose);
+
return 0;
}
next prev parent reply other threads:[~2017-12-09 18:03 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 7:47 [PATCH] SB600 for the Nemo board has non-zero devices on non-root bus Christian Zigotzky
2017-11-23 13:31 ` Michael Ellerman
2017-11-29 19:28 ` Christian Zigotzky
2017-11-29 19:46 ` Bjorn Helgaas
2017-11-29 20:45 ` Christian Zigotzky
2017-11-29 22:34 ` Bjorn Helgaas
2017-11-29 23:39 ` Christian Zigotzky
2017-11-30 22:42 ` Bjorn Helgaas
2017-12-01 22:08 ` Christian Zigotzky
2017-12-01 23:27 ` Bjorn Helgaas
2017-12-02 12:54 ` Christian Zigotzky
2017-12-02 23:00 ` Olof Johansson
2017-12-02 23:02 ` Olof Johansson
2017-12-03 9:43 ` Christian Zigotzky
2017-12-06 8:37 ` Christian Zigotzky
2017-12-06 11:03 ` Christian Zigotzky
2017-12-06 12:57 ` Michael Ellerman
2017-12-06 21:06 ` Bjorn Helgaas
2017-12-08 11:59 ` Michael Ellerman
2017-12-09 18:03 ` Christian Zigotzky [this message]
2017-12-15 8:04 ` Christian Zigotzky
2017-12-15 20:25 ` Bjorn Helgaas
2017-12-16 7:18 ` Christian Zigotzky
2017-12-22 9:57 ` Christian Zigotzky
2017-12-22 10:22 ` Christian Zigotzky
2017-12-22 11:19 ` Michael Ellerman
2017-12-22 12:11 ` Christian Zigotzky
2018-06-04 14:10 ` Michael Ellerman
2018-06-04 14:10 ` Michael Ellerman
2017-12-06 12:44 ` [PATCH] " Michael Ellerman
2017-12-06 15:53 ` Olof Johansson
2017-12-08 11:57 ` Michael Ellerman
2018-03-16 12:10 ` [PATCH 0/1] PCI set flag PCI_SCAN_ALL_PCIE_DEVS for P.A. Semi boards Christian Zigotzky
2018-03-16 12:55 ` [PATCH 1/1] " Christian Zigotzky
2018-03-19 19:13 ` Bjorn Helgaas
2018-03-19 20:46 ` Christian Zigotzky
2018-03-19 22:32 ` Michael Ellerman
2018-03-21 6:44 ` Christian Zigotzky
2018-03-25 20:55 ` Darren Stevens
2018-04-16 4:29 ` [PATCH 1/1] " Christian Zigotzky
2017-12-04 11:40 ` SB600 for the Nemo board has non-zero devices on non-root bus Darren Stevens
2017-12-04 13:31 ` Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5fe03d3-87f8-2a2d-2d83-fbefcd489a77@xenosoft.de \
--to=chzigotzky@xenosoft.de \
--cc=bhelgaas@google.com \
--cc=darren@stevens-zone.net \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.