All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>,
	Oscar Salvador <osalvador@suse.de>,
	Li Zhe <lizhe.67@bytedance.com>,
	Andrew Popple <apopple@nvidia.com>,
	Balbir Singh <balbirs@nvidia.com>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R . Howlett" <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	James Houghton <jthoughton@google.com>,
	Lance Yang <lance.yang@linux.dev>, Qi Zheng <qi.zheng@linux.dev>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v2 06/14] mm/mm_init: factor out frozen compound page initialization
Date: Tue, 17 Nov 2026 11:11:33 +0800	[thread overview]
Message-ID: <f618fc7e-371e-4f83-92fd-ee97db4b682f@linux.dev> (raw)
In-Reply-To: <179482576829.2379196.14870002582501235383.b4-review@b4>



On 2026/11/16 18:42, Mike Rapoport wrote:
> Hi,

Hi Mike,

>
>> ZONE_DEVICE initializes compound struct pages while their refcounts remain
>> frozen. The setup is open-coded in memmap_init_compound(), including the
>> per-page initialization and compound tail preparation.
>>
>> Factor the common setup into memmap_init_compound_page_frozen(). Keep the
>> pgmap association and MEMORY_DEVICE_GENERIC refcount handling in the
>> ZONE_DEVICE-specific path.
>>
>> This provides an MM-internal helper for other early memmap users to
>> share.
>>
>> No functional change is intended.
>>
>> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>> ---
>> v2:
>> - Rebase on memmap_init_page_from_template().
>> - Rename memmap_init_zone_device_head_page to memmap_init_zone_device_head_fields.
>> ---
>>   mm/mm_init.c | 114 +++++++++++++++++++++++++--------------------------
>>   mm/mm_init.h |   2 +
>>   2 files changed, 59 insertions(+), 57 deletions(-)
>>
>> diff --git a/mm/mm_init.c b/mm/mm_init.c
>> index bf943ae72a3e5..f1e539aec3d91 100644
>> --- a/mm/mm_init.c
>> +++ b/mm/mm_init.c
>> @@ -738,6 +738,28 @@ void __meminit memmap_init_page_from_template(struct page *page,
>>   	vmemmap_optimization_verify_zone(page);
>>   }
>>   
>> +void __meminit memmap_init_compound_page_frozen(struct page *head,
>> +		unsigned long pfn, const struct zone *zone, unsigned int order)
> Do we really need the _frozen suffix here?

Maybe not. I can remove it.

>
>> +{
>> +	unsigned long nr_pages = 1UL << order;
>> +	struct page template;
>> +
>> +	memmap_init_page_common(&template, zone_idx(zone), zone_to_nid(zone));
>> +	prep_compound_tail(&template, head, order);
>> +
>> +	/* Initialize the head page. */
>> +	__init_single_page(head, pfn, zone_idx(zone), zone_to_nid(zone));
>> +	set_page_count(head, 0);
>> +	__SetPageHead(head);
>> +
>> +	if (vmemmap_optimizable_order(pfn_to_section_compound_order(pfn)))
>> +		nr_pages = VMEMMAP_OPTIMIZATION_NR_STRUCT_PAGES;
>> +	/* Initialize the tail pages from PFN-independent template page. */
>> +	for (unsigned long i = 1; i < nr_pages; i++)
>> +		memmap_init_page_from_template(head + i, pfn + i, zone, &template);
>> +	prep_compound_head(head, order);
>> +}
>> +
>>   struct zone __meminit *pfn_to_zone(unsigned long pfn, int nid)
>>   {
>>   	pg_data_t *pgdat = NODE_DATA(nid);
>> @@ -1063,44 +1085,39 @@ static void __init memmap_init(void)
>>   }
>>   
>>   #ifdef CONFIG_ZONE_DEVICE
>> -/*
>> - * With compound page geometry and when struct pages are stored in ram most
>> - * tail pages are reused. Consequently, the amount of unique struct pages to
>> - * initialize is a lot smaller that the total amount of struct pages being
>> - * mapped. This is a paired / mild layering violation with explicit knowledge
>> - * of how the sparse_vmemmap internals handle compound pages in the lack
>> - * of an altmap.
>> - */
>> -static inline unsigned long compound_nr_pages(unsigned long pfn,
>> -					      struct dev_pagemap *pgmap)
>> +static void memmap_init_zone_device_head_fields(struct page *head,
>> +		struct dev_pagemap *pgmap)
> I can't say I like this name. Essentailly we initialize ZONE_DEVICE
> folio here, so maybe it can be
>
> 	memmap_init_zone_device_folio(struct folio *folio)

Make more sense.

>
>>   {
>> -	const struct mem_section *ms = __pfn_to_section(pfn);
>> -
>> -	if (!section_vmemmap_optimizable(ms))
>> -		return pgmap_vmemmap_nr(pgmap);
>> -
>> -	return VMEMMAP_OPTIMIZATION_PAGES * (PAGE_SIZE / sizeof(struct page));
>> +	/*
>> +	 * MEMORY_DEVICE_GENERIC pages start with a refcount of one; other
>> +	 * ZONE_DEVICE pages raise it when handed out. Use atomic_set() because
>> +	 * @head may be a stack template, while init_page_count() expects a
>> +	 * memmap-backed page.
>> +	 */
>> +	if (pgmap->type == MEMORY_DEVICE_GENERIC)
>> +		atomic_set(&head->_refcount, 1);
>> +	/*
>> +	 * ZONE_DEVICE pages union ->lru with a ->pgmap back pointer and
>> +	 * zone_device_data. It is a bug if a ZONE_DEVICE page is ever freed
>> +	 * or placed on a driver-private list.
>> +	 */
>> +	((struct folio *)head)->pgmap = pgmap;
> ... and then we won't need this cast and the caller will just pass
> page_folio() here.

Right. Initially, I thought using page_folio on the template page might
be problematic when compound_info_has_mask() == true. However, I found
that the template page happens to be order-0, which avoids the issue.
So, we can safely use page_folio.

>
>> +	head->zone_device_data = NULL;
>>   }
>>   
>> -static void __ref memmap_init_compound(struct page *head,
>> -				       unsigned long head_pfn,
>> -				       unsigned long zone_idx, int nid,
>> -				       struct dev_pagemap *pgmap,
>> -				       unsigned long nr_pages)
>> +static void memmap_init_zone_device_basepages(unsigned long start, unsigned long end,
>> +		const struct zone *zone, struct dev_pagemap *pgmap)
> _basepages sounds odd for me, maybe _pages will do?
>

Sounds good.

Thanks,
Muchun


  reply	other threads:[~2026-11-17  3:11 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  3:34 [PATCH v2 00/14] mm: Unify memmap initialization for compound pages Muchun Song
2026-11-13  3:34 ` [PATCH v2 01/14] mm/mm_init: factor out memmap_init_page_from_template() Muchun Song
2026-11-16  4:40   ` Lance Yang
2026-11-13  3:34 ` [PATCH v2 02/14] mm/hugetlb: optimize bootmem hugepage tail vmemmap init Muchun Song
2026-11-13  4:07   ` sashiko-bot
2026-11-13  4:10     ` Muchun Song
2026-11-16  7:55       ` Lance Yang
2026-11-16 10:42   ` Mike Rapoport
2026-11-13  3:34 ` [PATCH v2 03/14] mm/mm_init: verify zones for template-initialized pages Muchun Song
2026-11-16  8:41   ` Lance Yang
2026-11-13  3:34 ` [PATCH v2 04/14] mm/mm_init: factor out common struct page initialization Muchun Song
2026-11-16 10:42   ` Mike Rapoport
2026-11-17  2:50     ` Muchun Song
2026-11-17  3:13     ` Muchun Song
2026-11-17 13:21       ` Mike Rapoport
2026-11-13  3:34 ` [PATCH v2 05/14] mm/mm_init: simplify zone device " Muchun Song
2026-11-13  3:34 ` [PATCH v2 06/14] mm/mm_init: factor out frozen compound " Muchun Song
2026-11-16 10:42   ` Mike Rapoport
2026-11-17  3:11     ` Muchun Song [this message]
2026-11-13  3:34 ` [PATCH v2 07/14] mm/hugetlb: drop boot-time HVO handling for gigantic folios Muchun Song
2026-11-13  3:34 ` [PATCH v2 08/14] mm/hugetlb: initialize all struct pages for bootmem hugepages Muchun Song
2026-11-13  3:34 ` [PATCH v2 09/14] mm/hugetlb: use common compound page initialization helper Muchun Song
2026-11-13  3:34 ` [PATCH v2 10/14] mm/mm_init: make __init_single_page() static Muchun Song
2026-11-13  3:34 ` [PATCH v2 11/14] mm/mm_init: make memmap_init_page_from_template() static Muchun Song
2026-11-13  3:34 ` [PATCH v2 12/14] mm/cma: centralize CMA pageblock initialization Muchun Song
2026-11-13  4:07   ` sashiko-bot
2026-11-13  5:47     ` Muchun Song
2026-11-13  3:34 ` [PATCH v2 13/14] mm/cma: localize init_cma_pageblock() to cma.c Muchun Song
2026-11-13  3:34 ` [PATCH v2 14/14] mm/mm_init: move pageblock migratetype init to memmap helpers Muchun Song
2026-11-16  4:20 ` [PATCH v2 00/14] mm: Unify memmap initialization for compound pages Lance Yang
2026-11-16 10:42 ` Mike Rapoport
2026-11-16 11:17   ` Li Zhe
2026-11-17  3:57   ` Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f618fc7e-371e-4f83-92fd-ee97db4b682f@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=balbirs@nvidia.com \
    --cc=david@kernel.org \
    --cc=jthoughton@google.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizhe.67@bytedance.com \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    --cc=qi.zheng@linux.dev \
    --cc=rppt@kernel.org \
    --cc=songmuchun@bytedance.com \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.