From: Baolu Lu <baolu.lu@linux.intel.com>
To: Yi Liu <yi.l.liu@intel.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Nicolin Chen <nicolinc@nvidia.com>
Cc: baolu.lu@linux.intel.com,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Yan Zhao <yan.y.zhao@intel.com>,
iommu@lists.linux.dev, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH v7 06/12] iommu: Remove iommu_[un]register_device_fault_handler()
Date: Tue, 5 Dec 2023 20:09:20 +0800 [thread overview]
Message-ID: <f61dca1b-3de6-4767-96ac-0c20fd730bec@linux.intel.com> (raw)
In-Reply-To: <2516df8c-6d2a-49f7-bbea-123d0763bc00@intel.com>
On 2023/12/4 20:36, Yi Liu wrote:
>> /**
>> * iommu_report_device_fault() - Report fault event to device driver
>> * @dev: the device
>> @@ -1395,10 +1325,6 @@ int iommu_report_device_fault(struct device
>> *dev, struct iommu_fault_event *evt)
>> /* we only report device fault if there is a handler registered */
>> mutex_lock(¶m->lock);
>> fparam = param->fault_param;
>> - if (!fparam || !fparam->handler) {
>
> should it still check the fparam?
Yes.
Best regards,
baolu
next prev parent reply other threads:[~2023-12-05 12:09 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 3:02 [PATCH v7 00/12] iommu: Prepare to deliver page faults to user space Lu Baolu
2023-11-15 3:02 ` [PATCH v7 01/12] iommu: Move iommu fault data to linux/iommu.h Lu Baolu
2023-12-04 10:52 ` Yi Liu
2023-11-15 3:02 ` [PATCH v7 02/12] iommu/arm-smmu-v3: Remove unrecoverable faults reporting Lu Baolu
2023-12-01 15:42 ` Jason Gunthorpe
2023-12-04 10:54 ` Yi Liu
2023-12-05 11:48 ` Baolu Lu
2023-11-15 3:02 ` [PATCH v7 03/12] iommu: Remove unrecoverable fault data Lu Baolu
2023-12-04 10:58 ` Yi Liu
2023-12-05 11:55 ` Baolu Lu
2023-11-15 3:02 ` [PATCH v7 04/12] iommu: Cleanup iopf data structure definitions Lu Baolu
2023-12-04 11:03 ` Yi Liu
2023-11-15 3:02 ` [PATCH v7 05/12] iommu: Merge iopf_device_param into iommu_fault_param Lu Baolu
2023-12-04 12:32 ` Yi Liu
2023-12-05 12:01 ` Baolu Lu
2023-11-15 3:02 ` [PATCH v7 06/12] iommu: Remove iommu_[un]register_device_fault_handler() Lu Baolu
2023-12-04 12:36 ` Yi Liu
2023-12-05 12:09 ` Baolu Lu [this message]
2023-11-15 3:02 ` [PATCH v7 07/12] iommu: Merge iommu_fault_event and iopf_fault Lu Baolu
2023-12-01 19:09 ` Jason Gunthorpe
2023-12-04 12:40 ` Yi Liu
2023-11-15 3:02 ` [PATCH v7 08/12] iommu: Prepare for separating SVA and IOPF Lu Baolu
2023-12-05 7:10 ` Yi Liu
2023-11-15 3:02 ` [PATCH v7 09/12] iommu: Make iommu_queue_iopf() more generic Lu Baolu
2023-12-01 19:14 ` Jason Gunthorpe
2023-12-05 7:13 ` Yi Liu
2023-12-05 12:13 ` Baolu Lu
2023-11-15 3:02 ` [PATCH v7 10/12] iommu: Separate SVA and IOPF Lu Baolu
2023-11-15 3:02 ` [PATCH v7 11/12] iommu: Consolidate per-device fault data management Lu Baolu
2023-12-01 19:46 ` Jason Gunthorpe
2023-12-04 0:58 ` Baolu Lu
2023-11-15 3:02 ` [PATCH v7 12/12] iommu: Improve iopf_queue_flush_dev() Lu Baolu
2023-12-01 20:35 ` Jason Gunthorpe
2023-12-03 8:53 ` Baolu Lu
2023-12-03 14:14 ` Jason Gunthorpe
2023-12-04 1:32 ` Baolu Lu
2023-12-04 5:37 ` Tian, Kevin
2023-12-04 13:25 ` Jason Gunthorpe
2023-12-05 1:32 ` Tian, Kevin
2023-12-05 1:53 ` Jason Gunthorpe
2023-12-05 3:23 ` Tian, Kevin
2023-12-05 15:52 ` Jason Gunthorpe
2023-12-04 13:12 ` Jason Gunthorpe
2023-12-04 3:46 ` Baolu Lu
2023-12-04 13:27 ` Jason Gunthorpe
2023-12-05 1:13 ` Baolu Lu
2023-11-24 6:30 ` [PATCH v7 00/12] iommu: Prepare to deliver page faults to user space liulongfang
2023-11-24 12:01 ` Baolu Lu
2023-11-25 4:05 ` liulongfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f61dca1b-3de6-4767-96ac-0c20fd730bec@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yan.y.zhao@intel.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.