From: Pavel Skripkin <paskripkin@gmail.com>
To: Dongliang Mu <mudongliangabcd@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: Need help in debugging "memory leak in em28xx_init_dev"
Date: Mon, 1 Nov 2021 12:19:45 +0300 [thread overview]
Message-ID: <f622f569-25d5-f38e-e9fb-7f07e12c4b7e@gmail.com> (raw)
In-Reply-To: <CAD-N9QVN7cepUpRu3d-xtr1L3DG90-nLS4gmkjerDZO21F_ejQ@mail.gmail.com>
On 11/1/21 11:55, Dongliang Mu wrote:
>>
>>
>> Looks like missing clean up on error handling path.
>>
>> ->probe()
>> em28xx_init_dev()
>> em28xx_media_device_init() <- dev->media_dev allocated
>> *error somewhere in em28xx_init_dev()*
>>
>
> Hi Pavel,
>
> you're right. In some error handling code (em28xx_audio_setup fails),
> em28xx_init_dev fails to deallocated the media_dev field.
>
Hi, Dongliang,
Did patch attached to my previous email pass syzbot's reproducer test?
Unfortunately, I am not able to test rn :(
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-11-01 9:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 3:02 Need help in debugging "memory leak in em28xx_init_dev" Dongliang Mu
2021-11-01 7:50 ` Pavel Skripkin
2021-11-01 8:55 ` Dongliang Mu
2021-11-01 9:19 ` Pavel Skripkin [this message]
2021-11-01 9:41 ` Dongliang Mu
2021-11-01 9:43 ` Pavel Skripkin
2021-11-01 9:58 ` Dongliang Mu
2021-11-01 12:17 ` Pavel Skripkin
2021-11-01 12:23 ` Dongliang Mu
2021-11-01 12:26 ` Pavel Skripkin
2021-11-01 12:31 ` Dongliang Mu
2021-11-01 14:30 ` Dan Carpenter
2021-11-01 14:33 ` Dongliang Mu
2021-11-01 15:05 ` Randy Dunlap
2021-11-01 18:33 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f622f569-25d5-f38e-e9fb-7f07e12c4b7e@gmail.com \
--to=paskripkin@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mudongliangabcd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.