From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1F7CEB64D7 for ; Fri, 16 Jun 2023 16:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uPtF2N9CD1rjS+dPAorGlsQ7OWETpFljG9fdDWR6tbM=; b=njEcF1DfDYZk1C LhCTwbi+4O+6WtdfIY2ON4c0yWMtskjfUMf8qBGVvlFe6R7U/rK4HyXGX22Tmv42TOf0xf2lpCAcB ZeoF9uydaE7F6X7pF8NfWAG7uCuJj/oHe9VJ6RgEEWMT+CffnfFN6yNakUPi0JWYd9Kl295Asquz1 o/d2vHutmUj2ucojynqZg0m7nrXXtpG6zkKw750uBJrM0FzrPXsFD5LE5yNvXsYigb03Xf8qc3gyN djg/WIgTtB/i94Nfmh6h3xaHd8cT0kJUncXphu7AKxzeuMaos5LzvrEzfhBgstDVjKozWHZkvvdha CZYs4+1wjBcSJ2RWvD+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qACnF-001Czh-1k; Fri, 16 Jun 2023 16:59:25 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qACnC-001CyX-2U for linux-arm-kernel@lists.infradead.org; Fri, 16 Jun 2023 16:59:24 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-51a2661614cso1242245a12.2 for ; Fri, 16 Jun 2023 09:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686934759; x=1689526759; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mx45Gb+XOJkrBIEOQGfyEEPJszl2aIrpIEmyleHuzAA=; b=oRadAW9LWnD262uK2pxmP5H40mzdqIIoSFwtmKhwYhURgjOAF1K+nhkRzojy3cLt3O ZV9QVOCWHeJ70snod2xzhMr++SyUkZCkk52zXtnAV9eYqu5w/I8o0JVQeplagrkNdgJq StAIQKvXLx3Iqb86k6ALjzMlY5FpwqSjSSM+hOHM1S6V3TcahlOrPrRguCogeZBKgCJ/ 67xBYPJv5Yjl78YG54OHJ6mwjHVMoyPzLS71qbAB0F/stMl3MMABgtRk/d69jycvF3Br PP7u6318cEznzU1ynPTb8tVDvPraT22NIWhpZu2VAdPjt7n4DgvnaU8k1IfASnNwG6RH +8Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686934759; x=1689526759; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mx45Gb+XOJkrBIEOQGfyEEPJszl2aIrpIEmyleHuzAA=; b=UaADXPnhNaRglS8UR/grGcwUMXNvCw+a1qjng+bbZ71KH0x+9Ar/2Gb0oIGZ/wF8Mk bcDVsXlVRjoaiDFFZ9RyhCsvghJGVKZfUErkTleQIGhRB4lyOqvqgd39tmdW9GSYYGoU S4HAv2okXoeKS4oXTDuJrGfkeqEIQ/NlNHyKP9N4qFw54SovCib+e7B0ID0RPqEW9xRh iyeSVYPVqH+2opM7UbllmWTpK8n2wCKnLhPwEGnT0LUm7UagKpcjellI1ozZBj+yrboc 23Kby/SaefCu698PGOuQn60xtahKv4l9EpPido1l5dy3GfUc4oJwGL/0T9cII0i6yNBm On2A== X-Gm-Message-State: AC+VfDzE9FNxii9x8mLhgicxQ33gG8Ge6q5WYL0hIAF1BcpqBf4sOJiE DPRXmBuQDT6fqteilYdp/h1UPA== X-Google-Smtp-Source: ACHHUZ7wllev2biqWgYIidoYvTlpr/fZdLupzoU9AbrYoM7SCIfM4LPZ/0xDi5+7EbQ0/3tuQN2dQg== X-Received: by 2002:aa7:c851:0:b0:514:a685:aa3b with SMTP id g17-20020aa7c851000000b00514a685aa3bmr1432750edt.41.1686934759403; Fri, 16 Jun 2023 09:59:19 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id g25-20020a50ee19000000b0050bfeb15049sm9980703eds.60.2023.06.16.09.59.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jun 2023 09:59:18 -0700 (PDT) Message-ID: Date: Fri, 16 Jun 2023 18:59:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board Content-Language: en-US To: Josua Mayer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Li Yang , Marek Vasut , Fabio Estevam , Stefan Wahren , Frieder Schrempf , Marcel Ziswiler , Andreas Kemnade References: <20230616110610.32173-1-josua@solid-run.com> <20230616110610.32173-3-josua@solid-run.com> <5139b72e-cccb-43b3-ba37-35f0011e4a2b@solid-run.com> From: Krzysztof Kozlowski In-Reply-To: <5139b72e-cccb-43b3-ba37-35f0011e4a2b@solid-run.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230616_095922_882137_7D7C2051 X-CRM114-Status: GOOD ( 22.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTYvMDYvMjAyMyAxNTozMiwgSm9zdWEgTWF5ZXIgd3JvdGU6Cj4gSEkgS3J6eXN6dG9mLAo+ IAo+IEFtIDE2LjA2LjIzIHVtIDE0OjM2IHNjaHJpZWIgS3J6eXN6dG9mIEtvemxvd3NraToKPj4g T24gMTYvMDYvMjAyMyAxMzowNiwgSm9zdWEgTWF5ZXIgd3JvdGU6Cj4+PiBBZGQgRFQgY29tcGF0 aWJsZSBmb3IgU29saWRSdW4gTFgyMTYyQSBTb00gYW5kIENsZWFyZm9nIGJvYXJkLgo+Pj4KPj4+ IFNpZ25lZC1vZmYtYnk6IEpvc3VhIE1heWVyIDxqb3N1YUBzb2xpZC1ydW4uY29tPgo+Pj4gLS0t Cj4+PiAgIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vZnNsLnlhbWwgfCAy ICsrCj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPj4+Cj4+PiBkaWZmIC0t Z2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9mc2wueWFtbCBiL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vZnNsLnlhbWwKPj4+IGluZGV4IDE1 ZDQxMTA4NDA2NS4uNDM4YTRlY2U4MTU3IDEwMDY0NAo+Pj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9mc2wueWFtbAo+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9mc2wueWFtbAo+Pj4gQEAgLTEzNzMsOSArMTM3MywxMSBA QCBwcm9wZXJ0aWVzOgo+Pj4gICAgICAgICAtIGRlc2NyaXB0aW9uOiBTb2xpZFJ1biBMWDIxNjBB IGJhc2VkIEJvYXJkcwo+Pj4gICAgICAgICAgIGl0ZW1zOgo+Pj4gICAgICAgICAgICAgLSBlbnVt Ogo+Pj4gKyAgICAgICAgICAgICAgLSBzb2xpZHJ1bixjbGVhcmZvZwo+Pj4gICAgICAgICAgICAg ICAgIC0gc29saWRydW4sY2xlYXJmb2ctY3gKPj4+ICAgICAgICAgICAgICAgICAtIHNvbGlkcnVu LGhvbmV5Y29tYgo+Pj4gICAgICAgICAgICAgLSBjb25zdDogc29saWRydW4sbHgyMTYwYS1jZXg3 Cj4+PiArICAgICAgICAgIC0gY29uc3Q6IHNvbGlkcnVuLGx4MjE2MmEtc29tCj4+PiAgICAgICAg ICAgICAtIGNvbnN0OiBmc2wsbHgyMTYwYQo+PiBZb3UgY2hhbmdlIGV4aXN0aW5nIGVudHJpZXMs IGJyZWFraW5nIGJvYXJkcyBhbmQgY2hhbmdpbmcgdGhlIG1lYW5pbmcsCj4+IHdpdGhvdXQgYW55 IGV4cGxhbmF0aW9uIGluIGNvbW1pdCBtc2cuIFRoYXQncyBub3QgaG93IGl0IGlzIGRvbmUuIFBs ZWFzZQo+PiBwcm92aWRlIHJhdGlvbmFsZSBpbiBjb21taXQgbXNnLgo+IAo+IEknbSBzb3JyeS4g R2l2ZW4geW91ciBjb21tZW50IEkgdGhpbmsgSSBkaWQgbm90IHVuZGVyc3RhbmQgaG93IHRoZXNl IAo+IGVudHJpZXMgYXJlIHN1cHBvc2VkIHRvIHdvcmsuCj4gU28gcGVyaGFwcyB5b3UgY2FuIHBy b3ZpZGUgc29tZSBndWlkYW5jZSBiYXNlZCBvbiBteSBleHBsYW5hdGlvbj86Cj4gCj4gLSBOWFAg TFgyMTYyIGlzIGEgc21hbGxlciBwaHlzaWNhbCBwYWNrYWdlIG9mIHRoZSBzYW1lIExYMjE2MCBT b0MsIHdpdGggCj4gcmVkdWNlZCBJT3MgYW5kIHNvbWUgc2lsaWNvbiBibG9ja3MgZGlzYWJsZWQu Cj4gLSBTb2xpZFJ1biBMWDIxNjIgU29NIGlzIGVzc2VudGlhbGx5IGEgZGlmZmVyZW50IGZvcm0g ZmFjdG9yIG9mIExYMjE2MCBDRVgKPiAtIFNvbGlkUnVuIExYMjE2MiBDbGVhcmZvZyBpcyB0aGUg cmVmZXJlbmNlIHBsYXRmb3JtIGZvciB0aGUgU29NLiAKPiBEZXNwaXRlIGl0J3MgbmFtaW5nIHNp bWlsYXJpdHkgdG8gY2xlYXJmb2ctY3gsIGl0IGhhcyBhIGRpZmZlcmVudCAKPiBmZWF0dXJlIHNl dCBtb3JlIHNpbWlsYXIgdG8gU29saWRSdW4gQXJtYWRhIDM4OCBDbGVhcmZvZyBQcm8KPiAKPiBT byBJIGJlbGlldmVkIEkgY291bGQganVzdCBhZGQgdG8gdGhlIGV4aXN0aW5nIGVudHJ5ICJTb2xp ZFJ1biBMWDIxNjBBIAo+IGJhc2VkIEJvYXJkcyIgYWxzbyB0aGUgbmV3IExYMjE2MiBCb2FyZCAm IFNvTS4KCkJ1dCB5b3UgYWRkZWQgbXVjaCBtb3JlLCBkaWRuJ3QgeW91PwoKPiBJIHNlZSBub3cg dGhhdCBhZGRpbmcgYSBmb3VydGggY29uc3QgbWVzc2VzIHVwdGhlIGV4aXN0aW5nIDMtcGFydCAK PiBjb21wYXRpYmxlIGZvciB0aG9zZSBhbHJlYWR5IGV4aXN0aW5nIGJvYXJkcy4KPiAKPiBQbGVh c2UgY2FuIHlvdSBjb25maXJtIGlmIGl0IHdvdWxkIGhhdmUgYmVlbiBtb3JlIGNvcnJlY3QgdG8g cmVwbGFjZSAKPiAiY29uc3Q6IHNvbGlkcnVuLGx4MjE2MGEtY2V4NyIgd2l0aCBhbiBlbnVtPzoK PiBlbnVtOgo+ICDCoCAtIHNvbGlkcnVuLGx4MjE2MGEtY2V4Nwo+ICDCoCAtIHNvbGlkcnVuLGx4 MjE2MmEtc29tCj4gCj4gRmluYWxseSwgaXMgaXQgb2theSB0byBhZGQgYSAic29saWRydW4sY2xl YXJmb2ciIGdpdmVuIG15IGV4cGxhbmF0aW9uIAo+IGFib3ZlLCBvciBzaG91bGQgaXQgYmUgbW9y ZSBzcGVjaWZpYyAic29saWRydW4sbHgyMTYyYS1jbGVhcmZvZyI/Cj4gCgpUZXN0IHRoZSBiaW5k aW5nIGFuZCB0ZXN0IERUUyBhZ2FpbnN0IGl0OgpQbGVhc2UgcnVuIGBtYWtlIGR0YnNfY2hlY2tg IChzZWUKRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3dyaXRpbmctc2NoZW1hLnJz dCBmb3IgaW5zdHJ1Y3Rpb25zKS4KaHR0cHM6Ly93d3cubGluYXJvLm9yZy9ibG9nL3RpcHMtYW5k LXRyaWNrcy1mb3ItdmFsaWRhdGluZy1kZXZpY2V0cmVlLXNvdXJjZXMtd2l0aC10aGUtZGV2aWNl dHJlZS1zY2hlbWEvCgpJdCBtaWdodCBwb2ludCB5b3UgdG8gYW5zd2VyLgoKV2h5IGRvIHlvdSBt YWtlIHNvbGlkcnVuLGhvbmV5Y29tYiBjb21wYXRpYmxlIHdpdGggY2V4NyBhbmQgc29tPwoKQmVz dCByZWdhcmRzLApLcnp5c3p0b2YKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61DDDEB64DA for ; Fri, 16 Jun 2023 17:00:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345937AbjFPRAu (ORCPT ); Fri, 16 Jun 2023 13:00:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346360AbjFPRAW (ORCPT ); Fri, 16 Jun 2023 13:00:22 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F163B49E7 for ; Fri, 16 Jun 2023 09:59:20 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5196a728d90so1265795a12.0 for ; Fri, 16 Jun 2023 09:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686934759; x=1689526759; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mx45Gb+XOJkrBIEOQGfyEEPJszl2aIrpIEmyleHuzAA=; b=oRadAW9LWnD262uK2pxmP5H40mzdqIIoSFwtmKhwYhURgjOAF1K+nhkRzojy3cLt3O ZV9QVOCWHeJ70snod2xzhMr++SyUkZCkk52zXtnAV9eYqu5w/I8o0JVQeplagrkNdgJq StAIQKvXLx3Iqb86k6ALjzMlY5FpwqSjSSM+hOHM1S6V3TcahlOrPrRguCogeZBKgCJ/ 67xBYPJv5Yjl78YG54OHJ6mwjHVMoyPzLS71qbAB0F/stMl3MMABgtRk/d69jycvF3Br PP7u6318cEznzU1ynPTb8tVDvPraT22NIWhpZu2VAdPjt7n4DgvnaU8k1IfASnNwG6RH +8Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686934759; x=1689526759; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mx45Gb+XOJkrBIEOQGfyEEPJszl2aIrpIEmyleHuzAA=; b=W2ZIiPsV1awhgW5Ngd0EomnGm643NlTlE27yBY4I4JHnjk7kGoOR/9ItPEnKiJCLh0 u6aPpemovwNMbGYOf2UFvBs5FhHkEuG1aWkhUHZRmpbjHttLBUtgv5B6dj1AZ4N7ovFI DXao/aio0KvLTL0kFVdWPPQxUSK+8YOdlQ/2SMgz2Z8mRgkQJZM0gJ8/M/1azuiNZDSl eMYSpty2ycc0/PWHRSryPmAtxrn75HwqH/3naHEufMdsgQc5Awiw+peIG7dt0XovfVqv S2ttj20HIqLqy56nHAwp0XB8/zI1jwnKY5u9G21NFejJTdUBoel4U0nQ0D59SC0aMxjF nwMw== X-Gm-Message-State: AC+VfDx4t6cA1HrYQZIPi5rYs6yaH8bhCheoUXNnmNqZX61dTmP3cBEo 4qgu23mcFmz43YfH2L79n5F8QKJIY0nygL6OPac= X-Google-Smtp-Source: ACHHUZ7wllev2biqWgYIidoYvTlpr/fZdLupzoU9AbrYoM7SCIfM4LPZ/0xDi5+7EbQ0/3tuQN2dQg== X-Received: by 2002:aa7:c851:0:b0:514:a685:aa3b with SMTP id g17-20020aa7c851000000b00514a685aa3bmr1432750edt.41.1686934759403; Fri, 16 Jun 2023 09:59:19 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id g25-20020a50ee19000000b0050bfeb15049sm9980703eds.60.2023.06.16.09.59.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jun 2023 09:59:18 -0700 (PDT) Message-ID: Date: Fri, 16 Jun 2023 18:59:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board Content-Language: en-US To: Josua Mayer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Li Yang , Marek Vasut , Fabio Estevam , Stefan Wahren , Frieder Schrempf , Marcel Ziswiler , Andreas Kemnade References: <20230616110610.32173-1-josua@solid-run.com> <20230616110610.32173-3-josua@solid-run.com> <5139b72e-cccb-43b3-ba37-35f0011e4a2b@solid-run.com> From: Krzysztof Kozlowski In-Reply-To: <5139b72e-cccb-43b3-ba37-35f0011e4a2b@solid-run.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/06/2023 15:32, Josua Mayer wrote: > HI Krzysztof, > > Am 16.06.23 um 14:36 schrieb Krzysztof Kozlowski: >> On 16/06/2023 13:06, Josua Mayer wrote: >>> Add DT compatible for SolidRun LX2162A SoM and Clearfog board. >>> >>> Signed-off-by: Josua Mayer >>> --- >>> Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>> index 15d411084065..438a4ece8157 100644 >>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>> @@ -1373,9 +1373,11 @@ properties: >>> - description: SolidRun LX2160A based Boards >>> items: >>> - enum: >>> + - solidrun,clearfog >>> - solidrun,clearfog-cx >>> - solidrun,honeycomb >>> - const: solidrun,lx2160a-cex7 >>> + - const: solidrun,lx2162a-som >>> - const: fsl,lx2160a >> You change existing entries, breaking boards and changing the meaning, >> without any explanation in commit msg. That's not how it is done. Please >> provide rationale in commit msg. > > I'm sorry. Given your comment I think I did not understand how these > entries are supposed to work. > So perhaps you can provide some guidance based on my explanation?: > > - NXP LX2162 is a smaller physical package of the same LX2160 SoC, with > reduced IOs and some silicon blocks disabled. > - SolidRun LX2162 SoM is essentially a different form factor of LX2160 CEX > - SolidRun LX2162 Clearfog is the reference platform for the SoM. > Despite it's naming similarity to clearfog-cx, it has a different > feature set more similar to SolidRun Armada 388 Clearfog Pro > > So I believed I could just add to the existing entry "SolidRun LX2160A > based Boards" also the new LX2162 Board & SoM. But you added much more, didn't you? > I see now that adding a fourth const messes upthe existing 3-part > compatible for those already existing boards. > > Please can you confirm if it would have been more correct to replace > "const: solidrun,lx2160a-cex7" with an enum?: > enum: >   - solidrun,lx2160a-cex7 >   - solidrun,lx2162a-som > > Finally, is it okay to add a "solidrun,clearfog" given my explanation > above, or should it be more specific "solidrun,lx2162a-clearfog"? > Test the binding and test DTS against it: Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ It might point you to answer. Why do you make solidrun,honeycomb compatible with cex7 and som? Best regards, Krzysztof