From: Oliver Neukum <oneukum@suse.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Oliver Neukum <oneukum@suse.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: USB cdc-acm driver: break and command
Date: Thu, 17 Jul 2025 13:32:01 +0200 [thread overview]
Message-ID: <f63f2b91-a217-41fb-bbbb-1810d98838fd@suse.com> (raw)
In-Reply-To: <927f2d40-1004-4738-a1bc-0000d4d3e179@zytor.com>
On 16.07.25 19:30, H. Peter Anvin wrote:
> ERRORS
>
> The tcsendbreak() function shall fail if:
>
> [EBADF]
> The fildes argument is not a valid file descriptor.
> [EIO]
> The process group of the writing process is orphaned, the
> calling thread is not blocking SIGTTOU, and the process is not ignoring
> SIGTTOU.
> [ENOTTY]
> The file associated with fildes is not a terminal.
I would take this as meaning that we cannot just return -EBUSY or -EWOULDBLOCK.
Hence the generic layer would need to implement some sort of waiting
logic.
> That's why I said if that is what is needed, it really belongs in the
> tty core. That's where the current internal delay is, after all.
Good. Don't get me wrong. I'd love to do this more efficiently,
but the current API is less than optimal.
Regards
Oliver
next prev parent reply other threads:[~2025-07-17 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 21:00 USB cdc-acm driver: break and command H. Peter Anvin
2025-07-16 6:58 ` Greg KH
2025-07-16 8:29 ` Oliver Neukum
2025-07-16 15:06 ` H. Peter Anvin
2025-07-16 16:17 ` Oliver Neukum
2025-07-16 17:30 ` H. Peter Anvin
2025-07-17 11:32 ` Oliver Neukum [this message]
2025-07-16 17:49 ` H. Peter Anvin
2025-07-17 11:28 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f63f2b91-a217-41fb-bbbb-1810d98838fd@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.