From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH V3] net: phy: tja11xx: Add TJA11xx PHY driver Date: Thu, 3 Jan 2019 18:57:49 -0800 Message-ID: References: <20181221233552.3741-1-marex@denx.de> <836d9cec-0175-3cd1-b59b-2021195b8461@gmail.com> <9ae94569-2bef-acea-6b48-18d679060901@denx.de> <61488390-321d-155b-2b7c-e355875507b0@denx.de> <974e1e74-f3a8-1960-d3eb-a60d0614f352@gmail.com> <2796d0aa-daae-aaa0-ca51-59a156d667c6@denx.de> <1731fce4-21c3-aa03-953e-ab4610479431@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Andrew Lunn To: Marek Vasut , Heiner Kallweit , netdev@vger.kernel.org Return-path: Received: from mail-pf1-f195.google.com ([209.85.210.195]:33203 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbfADC5y (ORCPT ); Thu, 3 Jan 2019 21:57:54 -0500 Received: by mail-pf1-f195.google.com with SMTP id c123so17593488pfb.0 for ; Thu, 03 Jan 2019 18:57:52 -0800 (PST) In-Reply-To: <1731fce4-21c3-aa03-953e-ab4610479431@denx.de> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/3/2019 6:53 PM, Marek Vasut wrote: > On 1/4/19 3:19 AM, Marek Vasut wrote: > > [...] > > On a separate note, I was pondering about the master/slave mode of the > TJA11xx PHY. Right now, the driver only operates in Automatic mode, > however the PHY can be force-configured as either master or slave. > Would using .set_tunable with a new tunable type be a good way to expose > this to userspace ? The ethtool can then configure the PHY mode. Using an ethtool u8 tunable would be fine, with something like: 0 -> automatic 1 -> force master 2 -> force slave -- Florian