From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F17C54EAA for ; Mon, 23 Jan 2023 17:11:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232482AbjAWRK7 (ORCPT ); Mon, 23 Jan 2023 12:10:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231938AbjAWRK5 (ORCPT ); Mon, 23 Jan 2023 12:10:57 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AB8AA5ED for ; Mon, 23 Jan 2023 09:10:52 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id q5so6818811wrv.0 for ; Mon, 23 Jan 2023 09:10:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ye4fqaKuWEQ0VBJGa/puIN6G52G7rZfX+7Sp2w5Asa0=; b=AlS6Sy28XmPmahGHyCVVZnddWfq6aZfGYwtLhUOGOyec1e+pMe6bqP7BPl9dY713as MJX4cKz6YOw8bn2XwZiOqmaejGMBWD9m9aFGdI25RYHHbDn/EE0865XGFZPYyimqYEiX Ohw54jWTPZmbkKVbT6kOZmv3U1teLSUv3hD15eDClAkZFwv2/pBt4EeHLlrrlh8ABgnI ddbwTh/KTg+YBE8JZbebMtkU0+2eS4vIbv2MP2wCQKkKt78FWZHJg3J2K/R8gqfuHKjQ A5tdKyucw8DNEzT1X0yXdst2/HdRPMTc0X98ogylsAAukdCZgV7AmBibVI/LVaFkx0Zy MHRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ye4fqaKuWEQ0VBJGa/puIN6G52G7rZfX+7Sp2w5Asa0=; b=R6mNWSbvBgeUOyR5irFfwG12X01S9nvWvU7/clwWdEwHeZCIU6TOmsw3jiC5enJRwy lil0Aq1RGAWSOPY+jXZtmML3QiJI1mbRcZsRIJT8NRNkmmnvv8hWtOMPoWHKZYsOq/y0 sUPyd10+602znFypxrNn/vQ6jI0wttdft2JZ1qrmxGMW1DevDectnqn97FgM1FwE7REs ztQhh8e/jxzvIH4ERAukHnHzo2hlJq3OrQxx2ta0D9n2WMKWqiX3GMyiUNVfL9vIEFho cF5SXwMzudgju3C30MOyFNK4iTovmLNzogNv0JSvWcVtn5xU08oWuljSP/+ntasXeupA r1iA== X-Gm-Message-State: AFqh2kpSZQhRQRVxwDyqMrcV5DvNcv7NenFTxZBVLmJ2h6S6aPMhmulI qxOjyfjSCGGj+fz8oTHQSZ1TvA== X-Google-Smtp-Source: AMrXdXsJQ6qklnvii5yk83hLv4husOGcpBtpe2KAI5knLsCK/7V4f29aoYZQd+RytVPnb8G58WONiA== X-Received: by 2002:adf:f0c1:0:b0:2bd:e7a0:6b5e with SMTP id x1-20020adff0c1000000b002bde7a06b5emr22897157wro.40.1674493850759; Mon, 23 Jan 2023 09:10:50 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h10-20020a05600016ca00b00267bcb1bbe5sm5304137wrf.56.2023.01.23.09.10.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 09:10:50 -0800 (PST) Message-ID: Date: Mon, 23 Jan 2023 18:10:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 2/3] dt-bindings: arm: qcom: Add MSM8926 and Samsung Galaxy Tab 4 10.1 LTE Content-Language: en-US To: Stefan Hansson , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, matti.lehtimaki@gmail.com References: <20230122144749.87597-1-newbyte@postmarketos.org> <20230122144749.87597-3-newbyte@postmarketos.org> From: Krzysztof Kozlowski In-Reply-To: <20230122144749.87597-3-newbyte@postmarketos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 22/01/2023 15:47, Stefan Hansson wrote: > MSM8926 (also known as Snapdragon 400) is very similar to MSM8226 and > APQ8026 with the primary difference being that it features an LTE modem > unlike the former two which feature a 3G modem and a GPS-only modem, > respectively. > > This also documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) > which is a tablet by Samsung based on the MSM8926 SoC. > > Signed-off-by: Stefan Hansson > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 47913a8e3eea..7a0b2088ead9 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -35,6 +35,7 @@ description: | > mdm9615 > msm8226 > msm8916 > + msm8926 > msm8953 > msm8956 > msm8974 > @@ -219,6 +220,11 @@ properties: > - const: qcom,msm8916-v1-qrd/9-v1 > - const: qcom,msm8916 > > + - items: > + - enum: > + - samsung,matisselte 1. matisse is the code name, lte is version/suffix. I don't think they should be together, because then it looks like "matisselte" is a name. It actually sounds like one word. 2. You base on other SoC but you do not include its compatibles. Why? Is it intended? None of the properties applicable to other SoC will match here, thus I actually wonder if you run dtbs_check... Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D8BCC54E94 for ; Mon, 23 Jan 2023 17:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vJyhPRhboPaUDlU//IibFqAJuHCBDhUyus3ZRvM/J2A=; b=aJmuseYB4bJDnM nlIh1Tq7QdD8Vo6tdLvgbX8xkcApU/tBK+m07ZWg2kH0jgxKbqSGSlVBmWKKviuFl8UBnBjEgtAtq S1ncP9Ldj1/8W1qPQSX9jeVDirRTPX+V3DCpp8D/dB9BtjbQpITYef6dJWt1gm0lIrdYGmCtTPkOa 10H3CPG9BNHlbEVxaZi2lVo4t8yOuXkV8I9PwbM8xByFHKBGgDjgJ8t8P0Ck2dkYrW4v088TK334s lDy97sl8JjAHGQYi3wZTB+0KLeQ3KRCoVdmUKLjb0QsSuAiV7ISBBM7bYZiYiOsMzu5ntNsZaQS+K rrNArLYhJPUSVN7yN3ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pK0LR-000mKX-Qv; Mon, 23 Jan 2023 17:10:57 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pK0LO-000mJT-Ik for linux-arm-kernel@lists.infradead.org; Mon, 23 Jan 2023 17:10:56 +0000 Received: by mail-wr1-x42d.google.com with SMTP id bk16so11456153wrb.11 for ; Mon, 23 Jan 2023 09:10:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ye4fqaKuWEQ0VBJGa/puIN6G52G7rZfX+7Sp2w5Asa0=; b=AlS6Sy28XmPmahGHyCVVZnddWfq6aZfGYwtLhUOGOyec1e+pMe6bqP7BPl9dY713as MJX4cKz6YOw8bn2XwZiOqmaejGMBWD9m9aFGdI25RYHHbDn/EE0865XGFZPYyimqYEiX Ohw54jWTPZmbkKVbT6kOZmv3U1teLSUv3hD15eDClAkZFwv2/pBt4EeHLlrrlh8ABgnI ddbwTh/KTg+YBE8JZbebMtkU0+2eS4vIbv2MP2wCQKkKt78FWZHJg3J2K/R8gqfuHKjQ A5tdKyucw8DNEzT1X0yXdst2/HdRPMTc0X98ogylsAAukdCZgV7AmBibVI/LVaFkx0Zy MHRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ye4fqaKuWEQ0VBJGa/puIN6G52G7rZfX+7Sp2w5Asa0=; b=ctHBfyojb7gM4Gvq+T50v92e17sKdHlla2EPVKBzaor1cKc4e0WlSs3QQ+adJ8hpRt +/mY5om79rvZbQgdD0nnDTPnx5cee/arkiLgkFTySg1kqHiL0wd+dNE2jAXbaxgBphAs h0LRZr5BqJM+fVOBE8xTIQDmFGhE7VQQqMibUg48HpjHPO9t4lHNgchssZeRVCC3Tuhz Kpsj7sR8Gkc5KnNhl5GdEQWkujdUNdMW5Ojq1eKtQwrZipcxKdnSrlZHjek3RQw11Q27 w2niRK48csYLNBu7F5+x36gIeXDxCSgxIb78rmHUSttjoA90M/9kAhuAKJeFYrvcrPE5 0MwA== X-Gm-Message-State: AFqh2krz9/Y3zwe786hknqqybaxNbdlGV/yWnTppCvfzaFyD3hUwDdZc Yr2WGsK443t1MhiFp31oLj0pLA== X-Google-Smtp-Source: AMrXdXsJQ6qklnvii5yk83hLv4husOGcpBtpe2KAI5knLsCK/7V4f29aoYZQd+RytVPnb8G58WONiA== X-Received: by 2002:adf:f0c1:0:b0:2bd:e7a0:6b5e with SMTP id x1-20020adff0c1000000b002bde7a06b5emr22897157wro.40.1674493850759; Mon, 23 Jan 2023 09:10:50 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h10-20020a05600016ca00b00267bcb1bbe5sm5304137wrf.56.2023.01.23.09.10.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 09:10:50 -0800 (PST) Message-ID: Date: Mon, 23 Jan 2023 18:10:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 2/3] dt-bindings: arm: qcom: Add MSM8926 and Samsung Galaxy Tab 4 10.1 LTE Content-Language: en-US To: Stefan Hansson , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, matti.lehtimaki@gmail.com References: <20230122144749.87597-1-newbyte@postmarketos.org> <20230122144749.87597-3-newbyte@postmarketos.org> From: Krzysztof Kozlowski In-Reply-To: <20230122144749.87597-3-newbyte@postmarketos.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_091054_672348_51AB48E4 X-CRM114-Status: GOOD ( 18.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/01/2023 15:47, Stefan Hansson wrote: > MSM8926 (also known as Snapdragon 400) is very similar to MSM8226 and > APQ8026 with the primary difference being that it features an LTE modem > unlike the former two which feature a 3G modem and a GPS-only modem, > respectively. > > This also documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) > which is a tablet by Samsung based on the MSM8926 SoC. > > Signed-off-by: Stefan Hansson > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 47913a8e3eea..7a0b2088ead9 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -35,6 +35,7 @@ description: | > mdm9615 > msm8226 > msm8916 > + msm8926 > msm8953 > msm8956 > msm8974 > @@ -219,6 +220,11 @@ properties: > - const: qcom,msm8916-v1-qrd/9-v1 > - const: qcom,msm8916 > > + - items: > + - enum: > + - samsung,matisselte 1. matisse is the code name, lte is version/suffix. I don't think they should be together, because then it looks like "matisselte" is a name. It actually sounds like one word. 2. You base on other SoC but you do not include its compatibles. Why? Is it intended? None of the properties applicable to other SoC will match here, thus I actually wonder if you run dtbs_check... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel