From: "Nicolai Hähnle" <nhaehnle-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Junwei Zhang <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: christian.koenig-5C7GfCeVMHo@public.gmane.org,
nicolai.haehnle-5C7GfCeVMHo@public.gmane.org
Subject: Re: [PATCH 2/2] amdgpu: add REPLACE and CLEAR checking for VA op
Date: Tue, 21 Mar 2017 14:31:27 +0100 [thread overview]
Message-ID: <f697cff5-4d48-0c5f-e4b5-3c9fa203fce3@gmail.com> (raw)
In-Reply-To: <1489730362-31095-3-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
On 17.03.2017 06:59, Junwei Zhang wrote:
> Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com>
> ---
> amdgpu/amdgpu_bo.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
> index 71cd666..8fe3cfd 100644
> --- a/amdgpu/amdgpu_bo.c
> +++ b/amdgpu/amdgpu_bo.c
> @@ -952,7 +952,10 @@ int amdgpu_bo_va_op_raw(amdgpu_device_handle dev,
> struct drm_amdgpu_gem_va va;
> int r;
>
> - if (ops != AMDGPU_VA_OP_MAP && ops != AMDGPU_VA_OP_UNMAP)
> + if (ops != AMDGPU_VA_OP_MAP && ops != AMDGPU_VA_OP_UNMAP &&
> + ops != AMDGPU_VA_OP_REPLACE &&
> + ops != AMDGPU_VA_OP_CLEAR)
The indentation looks wrong. I believe the style is to use spaces so
that the first 'ops' in each row lines up.
Cheers,
Nicolai
> +
> return -EINVAL;
>
> memset(&va, 0, sizeof(va));
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2017-03-21 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 5:59 [PATCH 0/2] *** [libdrm] add REPLACE and CLEAR for VA op *** Junwei Zhang
[not found] ` <1489730362-31095-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
2017-03-17 5:59 ` [PATCH 1/2] amdgpu: add new VA operations CLEAR and REPLACE Junwei Zhang
[not found] ` <1489730362-31095-2-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
2017-03-21 13:30 ` Nicolai Hähnle
[not found] ` <ace47633-adf1-9055-5e08-1803f2f026c4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-22 3:04 ` Zhang, Jerry (Junwei)
2017-03-17 5:59 ` [PATCH 2/2] amdgpu: add REPLACE and CLEAR checking for VA op Junwei Zhang
[not found] ` <1489730362-31095-3-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>
2017-03-21 13:31 ` Nicolai Hähnle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f697cff5-4d48-0c5f-e4b5-3c9fa203fce3@gmail.com \
--to=nhaehnle-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Jerry.Zhang-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=nicolai.haehnle-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.