Re: [dpdk-dev] [PATCH v3 4/8] raw/ioat: create device on probe and destroy on release

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 27-Jun-19 11:40 AM, Bruce Richardson wrote:
> Add the create/destroy driver functions so that we can actually allocate
> a rawdev and destroy it when done. No rawdev API functions are actually
> implemented at this point.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

<snip>

> +	rawdev->driver_name = dev->device.driver->name;
> +
> +	ioat = rawdev->dev_private;
> +	ioat->rawdev = rawdev;
> +	ioat->regs = dev->mem_resource[0].addr;
> +	ioat->ring_size = 0;
> +	ioat->desc_ring = NULL;
> +	ioat->status_addr = rte_malloc_virt2iova(ioat) +
> +			offsetof(struct rte_ioat_rawdev, status);

While reviewing other patch, i remembered that i've seen this here. You 
can't make any guarantees about IOVA addresses in rte_malloc-allocated 
memory. Are you sure you don't require IOVA-contiguous memory here?

-- 
Thanks,
Anatoly