From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41124EB64DD for ; Mon, 7 Aug 2023 04:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A+fZeQJWzvxcIF/G4ccLARXAUtOK9BykxR/0+Dcl+/U=; b=LH6hbKONwf97Zz f02TrDWazHiB2juZ9M9tb+KacA7PNpkhxegmYEVdeL9QUta+G5feLz2b64XckskPqJ+8lrrS7eTj2 oR8DWcKZG6zcJ20XzkqKP6rmkQ8YU6ULJk0340DT6Q+W5TQTAkAW87gRD/+momrykEQPHWbxpb46U nlzMho31ebxxnnSS07fkQSmbzILtWkoyOLxvEeMk5K2orJAGM+8j1DdayLBBnd+ZtJg62m7/74fvP UNDslVjgA0qRpxFj+JQ5gTqnux69BCOkfQuK2Xxk8T8D3DSh6lT4il3LkodCh5lgqwrualZc/35Pm 8di9FFIs1BW3qUuWGIew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSs5U-00G8ev-2V; Mon, 07 Aug 2023 04:43:24 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSs5R-00G8dt-1D for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 04:43:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA2031FB; Sun, 6 Aug 2023 21:43:58 -0700 (PDT) Received: from [10.162.41.6] (a077893.blr.arm.com [10.162.41.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 114EE3F59C; Sun, 6 Aug 2023 21:43:11 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 10:13:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V3 4/4] coresight: trbe: Enable ACPI based TRBE devices Content-Language: en-US To: linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com Cc: Sami Mujawar , Catalin Marinas , Will Deacon , Mark Rutland , Mike Leach , Leo Yan , Alexander Shishkin , James Clark , coresight@lists.linaro.org, linux-kernel@vger.kernel.org References: <20230803055652.1322801-1-anshuman.khandual@arm.com> <20230803055652.1322801-5-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: <20230803055652.1322801-5-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230806_214321_529080_4C35227F X-CRM114-Status: GOOD ( 21.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA4LzMvMjMgMTE6MjYsIEFuc2h1bWFuIEtoYW5kdWFsIHdyb3RlOgo+IFRoaXMgZGV0ZWN0 cyBhbmQgZW5hYmxlcyBBQ1BJIGJhc2VkIFRSQkUgZGV2aWNlcyB2aWEgdGhlIGR1bW15IHBsYXRm b3JtCj4gZGV2aWNlIGNyZWF0ZWQgZWFybGllciBmb3IgdGhpcyBwdXJwb3NlLgo+IAo+IENjOiBT dXp1a2kgSyBQb3Vsb3NlIDxzdXp1a2kucG91bG9zZUBhcm0uY29tPgo+IENjOiBNaWtlIExlYWNo IDxtaWtlLmxlYWNoQGxpbmFyby5vcmc+Cj4gQ2M6IExlbyBZYW4gPGxlby55YW5AbGluYXJvLm9y Zz4KPiBDYzogQWxleGFuZGVyIFNoaXNoa2luIDxhbGV4YW5kZXIuc2hpc2hraW5AbGludXguaW50 ZWwuY29tPgo+IENjOiBjb3Jlc2lnaHRAbGlzdHMubGluYXJvLm9yZwo+IENjOiBsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBDYzogbGludXgta2VybmVsQHZnZXIua2VybmVs Lm9yZwo+IFNpZ25lZC1vZmYtYnk6IEFuc2h1bWFuIEtoYW5kdWFsIDxhbnNodW1hbi5raGFuZHVh bEBhcm0uY29tPgo+IC0tLQo+ICBkcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0 LXRyYmUuYyB8IDkgKysrKysrKysrCj4gIGRyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jl c2lnaHQtdHJiZS5oIHwgMSArCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRy YmUuYyBiL2RyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQtdHJiZS5jCj4gaW5k ZXggZTFkOWQwNmU3NzI1Li5mODg0ODgzZTkwMTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9od3Ry YWNpbmcvY29yZXNpZ2h0L2NvcmVzaWdodC10cmJlLmMKPiArKysgYi9kcml2ZXJzL2h3dHJhY2lu Zy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRyYmUuYwo+IEBAIC0xNTM3LDcgKzE1MzcsMTYgQEAgc3Rh dGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgYXJtX3RyYmVfb2ZfbWF0Y2hbXSA9IHsKPiAg fTsKPiAgTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgYXJtX3RyYmVfb2ZfbWF0Y2gpOwo+ICAKPiAr I2lmZGVmIENPTkZJR19BQ1BJCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl X2lkIGFybV90cmJlX2FjcGlfbWF0Y2hbXSA9IHsKPiArCXsgQVJNVjhfVFJCRV9QREVWX05BTUUs IDAgfSwKPiArCXsgfQo+ICt9Owo+ICtNT0RVTEVfREVWSUNFX1RBQkxFKHBsYXRmb3JtLCBhcm1f dHJiZV9hY3BpX21hdGNoKTsKPiArI2VuZGlmCj4gKwo+ICBzdGF0aWMgc3RydWN0IHBsYXRmb3Jt X2RyaXZlciBhcm1fdHJiZV9kcml2ZXIgPSB7Cj4gKwkuaWRfdGFibGUgPSBhcm1fdHJiZV9hY3Bp X21hdGNoLAoKVGhlIGJ1aWxkIHByb2JsZW0gWzFdIHJlcG9ydGVkIG9uIHRoZSBmaXJzdCB2ZXJz aW9uIG9mIHRoZSBzZXJpZXMgc3RpbGwgZXhpc3RzCmhlcmUgaS5lIGFybV90cmJlX2FjcGlfbWF0 Y2ggaXMgaGlkZGVuIHdpdGhvdXQgQ09ORklHX0FDUEkuIEkgaGFkIGFzc3VtZWQgdGhhdApDT05G SUdfQ09SRVNJR0hUIGFsd2F5cyBlbmFibGVzIENPTkZJR19BQ1BJLCB3aGljaCBpcyBub3QgdGhl IGNhc2UuIEZvbGxvd2luZwpyYW5kb20gY29uZmlnICh3aXRoIENPTkZJR19BQ1BJPW4gYW5kIENP TkZJR19DT1JFU0lHSFRfVFJCRT15KSBlYXNpbHkgdHJpZ2dlcnMKdGhlIGJ1aWxkIHByb2JsZW0u CgpodHRwczovL2Rvd25sb2FkLjAxLm9yZy8wZGF5LWNpL2FyY2hpdmUvMjAyMzA4MDUvMjAyMzA4 MDUyMTIzLnVxUjM1ZDE5LWxrcEBpbnRlbC5jb20vY29uZmlnCgogbWFrZSBDUk9TU19DT01QSUxF PWFhcmNoNjQtbGludXgtZ251LSBBUkNIPWFybTY0IC1zIC1qIDEyOApkcml2ZXJzL2h3dHJhY2lu Zy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRyYmUuYzoxNTYzOjIzOiBlcnJvcjogaW1wbGljaXQgZGVj bGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYQUNQSV9QVFLigJkgWy1XZXJyb3I9aW1wbGljaXQtZnVu Y3Rpb24tZGVjbGFyYXRpb25dCiAxNTYzIHwgICAuYWNwaV9tYXRjaF90YWJsZSA9IEFDUElfUFRS KGFybV90cmJlX2FjcGlfbWF0Y2gpLAogICAgICB8ICAgICAgICAgICAgICAgICAgICAgICBefn5+ fn5+fgpkcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRyYmUuYzoxNTYzOjMy OiBlcnJvcjog4oCYYXJtX3RyYmVfYWNwaV9tYXRjaOKAmSB1bmRlY2xhcmVkIGhlcmUgKG5vdCBp biBhIGZ1bmN0aW9uKTsgZGlkIHlvdSBtZWFuIOKAmGFybV90cmJlX29mX21hdGNo4oCZPwogMTU2 MyB8ICAgLmFjcGlfbWF0Y2hfdGFibGUgPSBBQ1BJX1BUUihhcm1fdHJiZV9hY3BpX21hdGNoKSwK ICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fn5+fn5+fn5+ fgogICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBhcm1fdHJiZV9vZl9tYXRj aAoKRm9sbG93aW5nIGNvbmZpZyB3cmFwIGFyb3VuZCBmaXhlcyB0aGUgcHJvYmxlbS4KCi0tLSBh L2RyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQtdHJiZS5jCisrKyBiL2RyaXZl cnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQtdHJiZS5jCkBAIC0xNTU3LDcgKzE1NTcs OSBAQCBNT0RVTEVfREVWSUNFX1RBQkxFKHBsYXRmb3JtLCBhcm1fdHJiZV9hY3BpX21hdGNoKTsK ICNlbmRpZgogCiBzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciBhcm1fdHJiZV9kcml2ZXIg PSB7CisjaWZkZWYgQ09ORklHX0FDUEkKICAgICAgICAuaWRfdGFibGUgPSBhcm1fdHJiZV9hY3Bp X21hdGNoLAorI2VuZGlmCiAgICAgICAgLmRyaXZlciA9IHsKICAgICAgICAgICAgICAgIC5uYW1l ID0gRFJWTkFNRSwKICAgICAgICAgICAgICAgIC5vZl9tYXRjaF90YWJsZSA9IG9mX21hdGNoX3B0 cihhcm1fdHJiZV9vZl9tYXRjaCksCgpQbGVhc2Ugbm90IHRoYXQgdW5saWtlIG90aGVyIGNvcmVz aWdodCBkcml2ZXJzLCBUUkJFIGlzIG5vdCB1c2luZyAnYWNwaV9kZXZpY2VfaWQnCmJhc2VkICJh Y3BpX21hdGNoX3RhYmxlID0gQUNQSV9QVFIiIGNvbnN0cnVjdC4gQnV0IHJlZ2FyZGxlc3MsIEFD UElfUFRSKCkgc2VlbXMgdG8KYmUgYW4gYWx0ZXJuYXRlIChwcm9iYWJseSBiZXR0ZXIpIHNvbHV0 aW9uIGFzIHdlbGwuCgotLS0gYS9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0 LXRyYmUuYworKysgYi9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRyYmUu YwpAQCAtMTU1Nyw3ICsxNTU3LDcgQEAgTU9EVUxFX0RFVklDRV9UQUJMRShwbGF0Zm9ybSwgYXJt X3RyYmVfYWNwaV9tYXRjaCk7CiAjZW5kaWYKIAogc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2 ZXIgYXJtX3RyYmVfZHJpdmVyID0gewotICAgICAgIC5pZF90YWJsZSA9IGFybV90cmJlX2FjcGlf bWF0Y2gsCisgICAgICAgLmlkX3RhYmxlID0gQUNQSV9QVFIoYXJtX3RyYmVfYWNwaV9tYXRjaCks CiAgICAgICAgLmRyaXZlciA9IHsKICAgICAgICAgICAgICAgIC5uYW1lID0gRFJWTkFNRSwKICAg ICAgICAgICAgICAgIC5vZl9tYXRjaF90YWJsZSA9IG9mX21hdGNoX3B0cihhcm1fdHJiZV9vZl9t YXRjaCksCmRpZmYgLS1naXQgYS9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0 LXRyYmUuaCBiL2RyaXZlcnMvaHd0cmFjaW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQtdHJiZS5oCmlu ZGV4IDk0ZTY3MDA5ODQ4YS4uZmNlMTczNWQ1YzU4IDEwMDY0NAotLS0gYS9kcml2ZXJzL2h3dHJh Y2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRyYmUuaAorKysgYi9kcml2ZXJzL2h3dHJhY2luZy9j b3Jlc2lnaHQvY29yZXNpZ2h0LXRyYmUuaApAQCAtNyw2ICs3LDcgQEAKICAqCiAgKiBBdXRob3I6 IEFuc2h1bWFuIEtoYW5kdWFsIDxhbnNodW1hbi5raGFuZHVhbEBhcm0uY29tPgogICovCisjaW5j bHVkZSA8bGludXgvYWNwaS5oPgogI2luY2x1ZGUgPGxpbnV4L2NvcmVzaWdodC5oPgogI2luY2x1 ZGUgPGxpbnV4L2RldmljZS5oPgogI2luY2x1ZGUgPGxpbnV4L2lycS5oPgoKWzFdIGh0dHBzOi8v bG9yZS5rZXJuZWwub3JnL2FsbC8yMDIzMDgwNTIxMjMudXFSMzVkMTktbGtwQGludGVsLmNvbS8K Cj4gIAkuZHJpdmVyCT0gewo+ICAJCS5uYW1lID0gRFJWTkFNRSwKPiAgCQkub2ZfbWF0Y2hfdGFi bGUgPSBvZl9tYXRjaF9wdHIoYXJtX3RyYmVfb2ZfbWF0Y2gpLAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0LXRyYmUuaCBiL2RyaXZlcnMvaHd0cmFj aW5nL2NvcmVzaWdodC9jb3Jlc2lnaHQtdHJiZS5oCj4gaW5kZXggNzdjYmI1YzYzODc4Li45NGU2 NzAwOTg0OGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9od3RyYWNpbmcvY29yZXNpZ2h0L2NvcmVz aWdodC10cmJlLmgKPiArKysgYi9kcml2ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0 LXRyYmUuaAo+IEBAIC0xMiw2ICsxMiw3IEBACj4gICNpbmNsdWRlIDxsaW51eC9pcnEuaD4KPiAg I2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPgo+ICAjaW5jbHVkZSA8bGludXgvb2YuaD4KPiArI2lu Y2x1ZGUgPGxpbnV4L3BlcmYvYXJtX3BtdS5oPgo+ICAjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1f ZGV2aWNlLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9zbXAuaD4KPiAgCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59FD7EB64DD for ; Mon, 7 Aug 2023 04:43:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbjHGEnU (ORCPT ); Mon, 7 Aug 2023 00:43:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjHGEnS (ORCPT ); Mon, 7 Aug 2023 00:43:18 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8954810FA for ; Sun, 6 Aug 2023 21:43:16 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EA2031FB; Sun, 6 Aug 2023 21:43:58 -0700 (PDT) Received: from [10.162.41.6] (a077893.blr.arm.com [10.162.41.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 114EE3F59C; Sun, 6 Aug 2023 21:43:11 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 10:13:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V3 4/4] coresight: trbe: Enable ACPI based TRBE devices Content-Language: en-US To: linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com Cc: Sami Mujawar , Catalin Marinas , Will Deacon , Mark Rutland , Mike Leach , Leo Yan , Alexander Shishkin , James Clark , coresight@lists.linaro.org, linux-kernel@vger.kernel.org References: <20230803055652.1322801-1-anshuman.khandual@arm.com> <20230803055652.1322801-5-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: <20230803055652.1322801-5-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/3/23 11:26, Anshuman Khandual wrote: > This detects and enables ACPI based TRBE devices via the dummy platform > device created earlier for this purpose. > > Cc: Suzuki K Poulose > Cc: Mike Leach > Cc: Leo Yan > Cc: Alexander Shishkin > Cc: coresight@lists.linaro.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > drivers/hwtracing/coresight/coresight-trbe.c | 9 +++++++++ > drivers/hwtracing/coresight/coresight-trbe.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index e1d9d06e7725..f884883e9018 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -1537,7 +1537,16 @@ static const struct of_device_id arm_trbe_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, arm_trbe_of_match); > > +#ifdef CONFIG_ACPI > +static const struct platform_device_id arm_trbe_acpi_match[] = { > + { ARMV8_TRBE_PDEV_NAME, 0 }, > + { } > +}; > +MODULE_DEVICE_TABLE(platform, arm_trbe_acpi_match); > +#endif > + > static struct platform_driver arm_trbe_driver = { > + .id_table = arm_trbe_acpi_match, The build problem [1] reported on the first version of the series still exists here i.e arm_trbe_acpi_match is hidden without CONFIG_ACPI. I had assumed that CONFIG_CORESIGHT always enables CONFIG_ACPI, which is not the case. Following random config (with CONFIG_ACPI=n and CONFIG_CORESIGHT_TRBE=y) easily triggers the build problem. https://download.01.org/0day-ci/archive/20230805/202308052123.uqR35d19-lkp@intel.com/config make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 -s -j 128 drivers/hwtracing/coresight/coresight-trbe.c:1563:23: error: implicit declaration of function ‘ACPI_PTR’ [-Werror=implicit-function-declaration] 1563 | .acpi_match_table = ACPI_PTR(arm_trbe_acpi_match), | ^~~~~~~~ drivers/hwtracing/coresight/coresight-trbe.c:1563:32: error: ‘arm_trbe_acpi_match’ undeclared here (not in a function); did you mean ‘arm_trbe_of_match’? 1563 | .acpi_match_table = ACPI_PTR(arm_trbe_acpi_match), | ^~~~~~~~~~~~~~~~~~~ | arm_trbe_of_match Following config wrap around fixes the problem. --- a/drivers/hwtracing/coresight/coresight-trbe.c +++ b/drivers/hwtracing/coresight/coresight-trbe.c @@ -1557,7 +1557,9 @@ MODULE_DEVICE_TABLE(platform, arm_trbe_acpi_match); #endif static struct platform_driver arm_trbe_driver = { +#ifdef CONFIG_ACPI .id_table = arm_trbe_acpi_match, +#endif .driver = { .name = DRVNAME, .of_match_table = of_match_ptr(arm_trbe_of_match), Please not that unlike other coresight drivers, TRBE is not using 'acpi_device_id' based "acpi_match_table = ACPI_PTR" construct. But regardless, ACPI_PTR() seems to be an alternate (probably better) solution as well. --- a/drivers/hwtracing/coresight/coresight-trbe.c +++ b/drivers/hwtracing/coresight/coresight-trbe.c @@ -1557,7 +1557,7 @@ MODULE_DEVICE_TABLE(platform, arm_trbe_acpi_match); #endif static struct platform_driver arm_trbe_driver = { - .id_table = arm_trbe_acpi_match, + .id_table = ACPI_PTR(arm_trbe_acpi_match), .driver = { .name = DRVNAME, .of_match_table = of_match_ptr(arm_trbe_of_match), diff --git a/drivers/hwtracing/coresight/coresight-trbe.h b/drivers/hwtracing/coresight/coresight-trbe.h index 94e67009848a..fce1735d5c58 100644 --- a/drivers/hwtracing/coresight/coresight-trbe.h +++ b/drivers/hwtracing/coresight/coresight-trbe.h @@ -7,6 +7,7 @@ * * Author: Anshuman Khandual */ +#include #include #include #include [1] https://lore.kernel.org/all/202308052123.uqR35d19-lkp@intel.com/ > .driver = { > .name = DRVNAME, > .of_match_table = of_match_ptr(arm_trbe_of_match), > diff --git a/drivers/hwtracing/coresight/coresight-trbe.h b/drivers/hwtracing/coresight/coresight-trbe.h > index 77cbb5c63878..94e67009848a 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.h > +++ b/drivers/hwtracing/coresight/coresight-trbe.h > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include >