From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17749E77188 for ; Tue, 14 Jan 2025 08:03:31 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.870976.1282019 (Exim 4.92) (envelope-from ) id 1tXbtI-0004rj-6I; Tue, 14 Jan 2025 08:03:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 870976.1282019; Tue, 14 Jan 2025 08:03:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tXbtI-0004rc-3i; Tue, 14 Jan 2025 08:03:12 +0000 Received: by outflank-mailman (input) for mailman id 870976; Tue, 14 Jan 2025 08:03:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tXbtG-0004rW-J5 for xen-devel@lists.xenproject.org; Tue, 14 Jan 2025 08:03:11 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fdad326e-d24d-11ef-99a4-01e77a169b0f; Tue, 14 Jan 2025 09:03:08 +0100 (CET) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 4B1E54EE0744; Tue, 14 Jan 2025 09:03:07 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdad326e-d24d-11ef-99a4-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bugseng.com; s=mail; t=1736841787; bh=lB5Dbodzl2R3mgxiMRri6BWaGPaB3/93XncFmbd+ax0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hZYNHY2iAYkl69zp44q9NZr9AU0QaYJYRVrTqt/v1mOkN/KXN0Iiszz+2aHNf2L5J 7PSRDH/fRpPBLc0Lpwfh6UgcgfUk6uKleWdYFE6duq/jLOfFcljOvdRe0HY/5AmKyl RHlUpP4MuOI3fAkYGE1hhPVAWbUxNPDy12oy5PjnGYqMtkiL28idnEv3uTpkU4qUbR uy/nxox3T8EIqAJRFEoA13ToHwM20LxYscmJPTPBjiDjSU+TaGX3pRUd5Ue5oJVGQq SV0fLr2bFt5jhAjFqswnuNWL38RalkKg3zuTVAs1sYcMYffD+0CkzmqQZcCRxuV8RH otOZFsVXEShmw== MIME-Version: 1.0 Date: Tue, 14 Jan 2025 09:03:07 +0100 From: Nicola Vetrini To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: Stefano Stabellini , Jan Beulich , Andrew Cooper , xen-devel@lists.xenproject.org, consulting@bugseng.com Subject: Re: [PATCH v2 1/2] x86/uaccess: rework user access speculative harden guards In-Reply-To: References: <20241126093508.6966-1-roger.pau@citrix.com> <20241126093508.6966-2-roger.pau@citrix.com> <8e31daaf77216534c252d371a3251595@bugseng.com> Message-ID: X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025-01-10 09:56, Nicola Vetrini wrote: > On 2025-01-10 09:29, Roger Pau Monné wrote: >> On Thu, Jan 09, 2025 at 03:57:24PM -0800, Stefano Stabellini wrote: >>> On Thu, 9 Jan 2025, Nicola Vetrini wrote: >>> > On 2025-01-04 01:20, Stefano Stabellini wrote: >>> > > Hi Nicola, one question below >>> > >>> > I will update ECLAIR to treat the two forms as the same, so this patch can be >>> > dropped. If you think it's helpful I can send a patch spelling out this - >>> > arbitrary, but reasonable in my opinion - extension to the MISRA rule (which >>> > does not consider the implications related to the use of GNU exensions) so >>> > that contributors have a clear picture of the situation. >>> >>> Thank you Nicola! Yes the patch would be appreciated :-) >> >> So unless the proposed adjustment is considered better for code >> readability patch 1 can be dropped, and patch 2 could be applied after >> the ECLAIR change is in effect? >> > > Yes, exactly > >> How long will it take Nicola to get the ECLAIR change propagated into >> the Gitlab runner? >> >> Thanks, Roger. > > We're still fixing the false positive upstream, but it shouldn't take > too long so I think next week I should be able to refresh the runner. Hi Roger, the runner is updated so, assuming no new violation of Rule 20.7 appeared in the meantime, the rule should now be clean. In the next few days I'll prepare a patch to the docs to document the behaviour. Thanks, Nicola -- Nicola Vetrini, B.Sc. Software Engineer BUGSENG (https://bugseng.com) LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253