All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: Francesco Dolcini <francesco@dolcini.it>, Tom Rini <trini@konsulko.com>
Cc: Nishanth Menon <nm@ti.com>,
	michael@amarulasolutions.com,
	dario.binacchi@amarulasolutions.com, afd@ti.com, vigneshr@ti.com,
	praneeth@ti.com, srk@ti.com, r-gunasekaran@ti.com,
	u-boot@lists.denx.de,
	Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND
Date: Wed, 10 Jan 2024 11:34:11 +0200	[thread overview]
Message-ID: <f6b3cf36-8e33-4e0d-9794-35ea32410c88@kernel.org> (raw)
In-Reply-To: <20240109200053.GA94696@francesco-nb>



On 09/01/2024 22:00, Francesco Dolcini wrote:
> On Tue, Jan 09, 2024 at 02:54:00PM -0500, Tom Rini wrote:
>> On Tue, Jan 09, 2024 at 01:18:59PM -0600, Nishanth Menon wrote:
>>> On 14:26-20240109, Roger Quadros wrote:
>>>>  CONFIG_CMD_PMIC=y
>>>>  CONFIG_CMD_REGULATOR=y
>>>> +CONFIG_CMD_MTDPARTS=y
>>>> +CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0"
>>>> +CONFIG_MTDPARTS_DEFAULT="mtdparts=omap2-nand.0:2m(NAND.tiboot3),2m(NAND.tispl),2m(NAND.tiboot3.backup),4m(NAND.u-boot),256k(NAND.u-boot-env),256k(NAND.u-boot-env.backup),-(NAND.file-system)"
>>>
>>> Why not handle this as device tree partitions?
>>
>> I honestly forget what the preferred way of defining and passing NAND
>> partition information is these days. It might even be the funny case
>> that passing as cmdline args is "best" rather than fixed-partitions
>> binding?
> 
> According to past discussions [1] doing the fixup in U-Boot is not advised.
> 
> Using the command line or having the partition fixed in the DT are both
> valid options.
> 
> [1] https://lore.kernel.org/all/20230206224838.75963-1-francesco@dolcini.it/
> 
> Francesco
> 

This was not about passing mtdparts to kernel but about getting 'mtdparts' command
to work at u-boot. I need to figure out why OF partition parser didn't work here.

For a start I didn't have CONFIG_MTD_PARTITIONS set. Maybe I'm missing something more.

-- 
cheers,
-roger

  parent reply	other threads:[~2024-01-10  9:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09 12:26 [PATCH 0/4] arm: mach-k3: am64: Add NAND configuration Roger Quadros
2024-01-09 12:26 ` [PATCH 1/4] memory: ti-gpmc: Fix build Roger Quadros
2024-01-09 12:26 ` [PATCH 2/4] mtd: rawnand: omap_gpmc: Use DT provided IO address Roger Quadros
2024-01-09 12:26 ` [PATCH 3/4] arm: mach-k3: am642: Define NAND boot device Roger Quadros
2024-01-09 12:26 ` [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND Roger Quadros
2024-01-09 19:16   ` Nishanth Menon
2024-01-09 19:48     ` Tom Rini
2024-01-09 20:00       ` Nishanth Menon
2024-01-09 20:35         ` Tom Rini
2024-01-09 19:18   ` Nishanth Menon
2024-01-09 19:54     ` Tom Rini
2024-01-09 20:00       ` Francesco Dolcini
2024-01-09 20:22         ` Nishanth Menon
2024-01-10  9:34         ` Roger Quadros [this message]
2024-01-10 16:06           ` Roger Quadros
2024-01-10 16:30             ` Tom Rini
2024-01-09 19:17 ` [PATCH 0/4] arm: mach-k3: am64: Add NAND configuration Nishanth Menon
2024-01-11 12:15   ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6b3cf36-8e33-4e0d-9794-35ea32410c88@kernel.org \
    --to=rogerq@kernel.org \
    --cc=afd@ti.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=francesco@dolcini.it \
    --cc=michael@amarulasolutions.com \
    --cc=nm@ti.com \
    --cc=praneeth@ti.com \
    --cc=r-gunasekaran@ti.com \
    --cc=srk@ti.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.