From: Jens Axboe <axboe@kernel.dk>
To: io-uring@vger.kernel.org, linux-block@vger.kernel.org,
Ming Lei <ming.lei@redhat.com>
Cc: David Howells <dhowells@redhat.com>,
Chengming Zhou <zhouchengming@bytedance.com>,
Pavel Begunkov <asml.silence@gmail.com>
Subject: Re: [PATCH V2] io_uring: fix IO hang in io_wq_put_and_exit from do_exit()
Date: Thu, 7 Sep 2023 09:36:10 -0600 [thread overview]
Message-ID: <f6be40a3-38de-41ed-a545-d9063379f8e2@kernel.dk> (raw)
In-Reply-To: <169358121201.335729.4270950770834703042.b4-ty@kernel.dk>
On 9/1/23 9:13 AM, Jens Axboe wrote:
>
> On Fri, 01 Sep 2023 21:49:16 +0800, Ming Lei wrote:
>> io_wq_put_and_exit() is called from do_exit(), but all FIXED_FILE requests
>> in io_wq aren't canceled in io_uring_cancel_generic() called from do_exit().
>> Meantime io_wq IO code path may share resource with normal iopoll code
>> path.
>>
>> So if any HIPRI request is submittd via io_wq, this request may not get resouce
>> for moving on, given iopoll isn't possible in io_wq_put_and_exit().
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] io_uring: fix IO hang in io_wq_put_and_exit from do_exit()
> commit: b484a40dc1f16edb58e5430105a021e1916e6f27
This causes a regression with the test/thread-exit.t test case, as it's
canceling requests from other tasks as well. I will drop this patch for
now.
--
Jens Axboe
next prev parent reply other threads:[~2023-09-07 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 13:49 [PATCH V2] io_uring: fix IO hang in io_wq_put_and_exit from do_exit() Ming Lei
2023-09-01 14:47 ` Jens Axboe
2023-09-01 15:12 ` Ming Lei
2023-09-01 15:13 ` Jens Axboe
2023-09-01 15:13 ` Jens Axboe
2023-09-07 15:36 ` Jens Axboe [this message]
2023-09-08 1:03 ` Pavel Begunkov
2023-09-08 6:22 ` Ming Lei
2023-09-08 16:01 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6be40a3-38de-41ed-a545-d9063379f8e2@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=dhowells@redhat.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.