From: Damien Le Moal <dlemoal@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@infradead.org>
Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
linux-block@vger.kernel.org
Subject: Re: [blktests] zbd/012: Test requeuing of zoned writes and queue freezing
Date: Thu, 28 Nov 2024 08:43:18 +0900 [thread overview]
Message-ID: <f6dde4df-e775-47ea-bcc3-c3a1e6874ca4@kernel.org> (raw)
In-Reply-To: <992ba839-5b7b-4db5-bc64-286ca47b216e@acm.org>
On 11/28/24 08:36, Bart Van Assche wrote:
>
> On 11/27/24 3:18 PM, Damien Le Moal wrote:
>> The BIO that failed is not recovered. The user will see the failure. The error
>> recovery report zones is all about avoiding more failures of plugged zone append
>> BIOs behind that failed BIO. These can succeed with the error recovery.
>>
>> So sure, we can fail all BIOs. The user will see more failures. If that is OK,
>> that's easy to do. But in the end, that is not a solution because we still need
>> to get an updated zone write pointer to be able to restart zone append
>> emulation. Otherwise, we are in the dark and will not know where to send the
>> regular writes emulating zone append. That means that we still need to issue a
>> zone report and that is racing with queue freeze and reception of a new BIO. We
>> cannot have new BIOs "wait" for the zone report as that would create a hang
>> situation again if a queue freeze is started between reception of the new BIO
>> and the zone report. Do we fail these new BIOs too ? That seems extreme.
>
> This patch removes the disk->fops->report_zones() call from the
> blk-zoned.c code:
> https://lore.kernel.org/linux-block/20241119002815.600608-6-bvanassche@acm.org/.
> Is it really not possible to get that
> approach working for SAS SMR drives? If a torn write happens, is the
> residual information in the response from the drive reliable?
Let me dig into this again and see if that can work.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-11-27 23:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 21:10 [blktests] zbd/012: Test requeuing of zoned writes and queue freezing Bart Van Assche
2024-11-26 8:34 ` Damien Le Moal
2024-11-26 13:44 ` Bart Van Assche
2024-11-27 5:18 ` Damien Le Moal
2024-11-27 6:16 ` Christoph Hellwig
2024-11-27 6:21 ` Christoph Hellwig
2024-11-27 6:32 ` Damien Le Moal
2024-11-27 6:33 ` Christoph Hellwig
2024-11-27 6:43 ` Damien Le Moal
2024-11-27 6:45 ` Christoph Hellwig
2024-11-27 7:02 ` Damien Le Moal
2024-11-27 7:19 ` Christoph Hellwig
2024-11-27 8:17 ` Damien Le Moal
2024-11-27 8:58 ` Christoph Hellwig
2024-11-27 11:31 ` Damien Le Moal
2024-11-27 16:58 ` Christoph Hellwig
2024-11-27 23:18 ` Damien Le Moal
2024-11-27 23:36 ` Bart Van Assche
2024-11-27 23:43 ` Damien Le Moal [this message]
2024-11-28 3:20 ` Christoph Hellwig
2024-11-28 4:37 ` Damien Le Moal
2024-11-28 4:39 ` Christoph Hellwig
2024-11-28 4:52 ` Damien Le Moal
2024-11-28 5:00 ` Christoph Hellwig
2024-11-28 5:07 ` Damien Le Moal
2024-11-28 5:16 ` Christoph Hellwig
2024-11-28 5:19 ` Damien Le Moal
2024-11-28 5:21 ` Christoph Hellwig
2024-11-28 5:27 ` Damien Le Moal
2024-11-27 17:10 ` Bart Van Assche
2024-11-27 23:11 ` Damien Le Moal
2024-11-26 11:26 ` Damien Le Moal
2024-11-26 12:49 ` Christoph Hellwig
2024-11-27 2:28 ` Damien Le Moal
2024-11-28 4:35 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6dde4df-e775-47ea-bcc3-c3a1e6874ca4@kernel.org \
--to=dlemoal@kernel.org \
--cc=bvanassche@acm.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.