From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDB35C2D0E2 for ; Tue, 22 Sep 2020 08:28:56 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55848239E5 for ; Tue, 22 Sep 2020 08:28:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="Jv3/baHU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55848239E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKdfG-0005PV-6R; Tue, 22 Sep 2020 08:28:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kKdfE-0005PQ-J9 for xen-devel@lists.xenproject.org; Tue, 22 Sep 2020 08:28:40 +0000 X-Inumbo-ID: 53f17f65-e5df-4428-9181-0eed4a057bac Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 53f17f65-e5df-4428-9181-0eed4a057bac; Tue, 22 Sep 2020 08:28:39 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1600763319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8UKue6UM3k7rs00oRlc4/xqaO5IBn0HQYNhdMcr1kkc=; b=Jv3/baHUr2WE1SNT33DV3G9xiRPB3xAt4Es9XyYOCWpaWWPrR39yftY004Wv5EiIBej8a9 LIC4w4Bhci+CSEnezdnfuBlGpxrm9vxaD1xcp4OQaoRFGvcyyjzPp66UsK160E8muiCPnx wNcYMcmGIjqp2PYAbnsAhLMMw4Oj9Wg= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 81DA4AC82; Tue, 22 Sep 2020 08:29:15 +0000 (UTC) Subject: Re: Ping: [PATCH 1/9] build: use if_changed more consistently (and correctly) for prelink*.o To: Julien Grall , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: <75d94bf1-b419-8a82-2d15-fb02e56109d8@suse.com> <43a4240c-baba-ca52-0a9f-a884c0f297be@xen.org> From: Jan Beulich Message-ID: Date: Tue, 22 Sep 2020 10:28:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <43a4240c-baba-ca52-0a9f-a884c0f297be@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 21.09.2020 13:39, Julien Grall wrote: > On 21/09/2020 11:17, Jan Beulich wrote: >> On 14.09.2020 12:15, Jan Beulich wrote: >>> Switch to $(call if_changed,ld) where possible; presumably not doing so >>> in e321576f4047 ("xen/build: start using if_changed") right away was an >>> oversight, as it did for Arm in (just) one case. It failed to add >>> prelink.o to $(targets), though, causing - judging from the observed >>> behavior on x86 - undue rebuilds of the final binary (because of >>> prelink.o getting rebuild for $(cmd_prelink.o) being empty, in turn >>> because of .prelink.o.cmd not getting read) during "make install-xen". >>> >>> Signed-off-by: Jan Beulich >>> --- >>> xen/arch/arm/Makefile | 4 +++- >>> xen/arch/x86/Makefile | 18 ++++++++++-------- >>> 2 files changed, 13 insertions(+), 9 deletions(-) >> >> May I ask for an Arm-side ack (or otherwise) here, please? > > Acked-by: Julien Grall Thanks. On the Arm side this is actually addressing a (minor) bug, so I wonder whether I should queue this up for backporting. Do you have an opinion either way? Jan