[f2fs-dev] 答复: [PATCH -next] f2fs: add a trace interface for f2fs_update_extent_tree_range_compressed

[zhangqilong via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>]

> On 2022/9/15 21:44, Zhang Qilong wrote:
> > For f2fs_update_extent_tree_range_compressed, keeping the trace
> and
> > function name consistent to distinguish from trace of
> > f2fs_update_extent_tree_range. And we add "c_len" into the trace,
> > result like:
> >
> >    [003] .....   228.568157:
> f2fs_update_extent_tree_range_compressed:
> >                  dev = (8,0), ino = 5, pgofs = 96, blkaddr = 2548760,
> >                  len = 4, c_len = 1
> >
> > Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> > ---
> >   fs/f2fs/extent_cache.c      |  2 +-
> >   include/trace/events/f2fs.h | 36
> ++++++++++++++++++++++++++++++++++++
> >   2 files changed, 37 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c index
> > 761fd42c93f2..df41eca6386a 100644
> > --- a/fs/f2fs/extent_cache.c
> > +++ b/fs/f2fs/extent_cache.c
> > @@ -675,7 +675,7 @@ void
> f2fs_update_extent_tree_range_compressed(struct inode *inode,
> >   	struct rb_node **insert_p = NULL, *insert_parent = NULL;
> >   	bool leftmost = false;
> >
> > -	trace_f2fs_update_extent_tree_range(inode, fofs, blkaddr, llen);
> > +	trace_f2fs_update_extent_tree_range_compressed(inode, fofs,
> blkaddr,
> > +llen, c_len);
> >
> >   	/* it is safe here to check FI_NO_EXTENT w/o et->lock in ro image
> */
> >   	if (is_inode_flag_set(inode, FI_NO_EXTENT)) diff --git
> > a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h index
> > b262985f0c3a..54a9f6feca1b 100644
> > --- a/include/trace/events/f2fs.h
> > +++ b/include/trace/events/f2fs.h
> > @@ -1606,6 +1606,42 @@
> TRACE_EVENT(f2fs_update_extent_tree_range,
> >   		__entry->len)
> >   );
> >
> > +TRACE_EVENT(f2fs_update_extent_tree_range_compressed,
> 
> Why not adding parameter c_len in
> trace_f2fs_update_extent_tree_range()
> to avoid duplicated codes...

That is good, I have send a new patch(f2fs: add "c_len" into trace_f2fs_update_extent_tree_range for compressed file).
This session could be closed :).

Thanks.


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel