From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC8BAC021B0 for ; Wed, 19 Feb 2025 14:59:06 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.893076.1302002 (Exim 4.92) (envelope-from ) id 1tklXL-0007yd-7k; Wed, 19 Feb 2025 14:58:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 893076.1302002; Wed, 19 Feb 2025 14:58:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tklXL-0007yW-4o; Wed, 19 Feb 2025 14:58:55 +0000 Received: by outflank-mailman (input) for mailman id 893076; Wed, 19 Feb 2025 14:58:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tklXJ-0007yQ-RE for xen-devel@lists.xenproject.org; Wed, 19 Feb 2025 14:58:53 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 08abc20a-eed2-11ef-9aa8-95dc52dad729; Wed, 19 Feb 2025 15:58:52 +0100 (CET) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5dedae49c63so2923169a12.0 for ; Wed, 19 Feb 2025 06:58:52 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5dedc94688bsm9216939a12.50.2025.02.19.06.58.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2025 06:58:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08abc20a-eed2-11ef-9aa8-95dc52dad729 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1739977132; x=1740581932; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=QXYyMgXWP4s7LeELnzMyd3+0mGyjlCEWYJ+F5ELMrDE=; b=ZqZLA3zcwr63mJHAPSSThGmq1L/aAeslqX0QCMkEre4OB7CLopC6vKjDzc6sghfHyS 7EVx7lAm2XejOZ4gNPQEOeCare9foQz8K6lzoWIlgnBQH7bYWb/NGUTeeRXQzgUBE80S +MWYmdUT8UJ/oOz5Lh76ueI6T+vh8f04ovOzHXUVKMMvpI2jd1zquy/RauTd+HxR/oSj h12WqIrskXC2y6d/xbP5qpJz3nfse+huTRUJu5eEak7RSjv3OsvKDvjUa9ytmvvzjFoq 0LfhnwHFyPNaKIOHiqdnZzHR/kC3BQDhWZDACK+ng/pIjfSFGr977/kgG6Qaz/YIeDEV tRmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739977132; x=1740581932; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QXYyMgXWP4s7LeELnzMyd3+0mGyjlCEWYJ+F5ELMrDE=; b=wPH2F9ONsktlLkXk0QW3TnNkDyedhMEO2+X2+E6KPpTmwlDHye6Qr2Nqduvf01N5aA 7dSglsLpON94z4uYBIrRQ5Ly9X0tuQVcua2G0UvYXPV3bpR2ZAi6Ihip/ptqiJhamTEu Pjf5srEuGknG2JIXwgYc9xoBIVMYmZQoFeq8z11H9i31A3tRqjavqTsD8ATNzkm6c3qe Qdd49UG0+GKvN1B1+cHlG8kgx0fy2LE+/uTPIdbeQoKrALUStWlVz6ddLf7FHTHwRAT7 M5bezoe7dN2/pTTCMqLczbiYTNLFPmINwxdvxD9m9sbEs/kPXweF8AbBAG+5XDFBgded BWAQ== X-Forwarded-Encrypted: i=1; AJvYcCVPZAnsQq5anged7aCsXfFO60WAbwVVQI+EEhBKlnzE8hcJS4Ou5537zdcB2SF/X7QPXVkcKSvyOf0=@lists.xenproject.org X-Gm-Message-State: AOJu0YxfgsrqrwHKQPg8WsZCioknCE9G1v0w/RXOqF0689nEcohIf/Hb +Xw+AnOSFGe1OLEGX18GoMEbqcnuUBiP+p//jqXaHhWt/vNh632z/5T+fOhTig== X-Gm-Gg: ASbGnctlQ7SromMZvCFT6inEkm4eR4jaLz7EgNruIyL0M1lKCJYOArz4ZtFbm7Meddz NoUjXgW7zH3ViEK9tYm+Z0pukxylrUWg0WuegalUbLInmytumTAM/++LBoEJanu58VlMchBw/Lf kQ2MW4CFkeUYM8fNeFspisApg1NwMmR4HZFgyZ8gbQaevPwOKsMfYtxmTXZ1WbTsdfmaxejdWP0 FWEbwW7rAUwaAc8LmyAl8hXnmjTB5PeWPMSvY7KpWh99qiLv6QZkZmEQc6D8JCUO9AlAJIjk7DB Wqv1VF4S/P6FgmysBmy9F1ysqStBcFv48VqNCX1hyTcYBjWi8hBifbkBaA9EkmUPQQOr8Wz58nw L X-Google-Smtp-Source: AGHT+IEpUh2KXEdycGeyDRUCHqmkhg11R1n2c8dtZUQZ6xZfQYlEWuHUuhJ0KNzJ/NyY9mWh1m0b7w== X-Received: by 2002:a05:6402:a001:b0:5e0:52df:d569 with SMTP id 4fb4d7f45d1cf-5e052dfd7e2mr12470282a12.28.1739977132290; Wed, 19 Feb 2025 06:58:52 -0800 (PST) Message-ID: Date: Wed, 19 Feb 2025 15:58:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] code style: Format ns16550 driver To: Oleksandr Andrushchenko Cc: sstabellini@kernel.org, Artem_Mygaiev@epam.com, Luca.Fancellu@arm.com, roger.pau@citrix.com, marmarek@invisiblethingslab.com, andrew.cooper3@citrix.com, anthony.perard@vates.tech, xen-devel@lists.xenproject.org References: <20250216102108.2665222-1-andr2000@gmail.com> <20250216102108.2665222-2-andr2000@gmail.com> <5ed54fcf-d4fd-4ec0-8c40-1e50d9b16ae2@suse.com> <6f133e51-17b5-4edf-8db3-5c9b91028898@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 19.02.2025 15:23, Oleksandr Andrushchenko wrote: > On 19.02.25 14:39, Oleksandr Andrushchenko wrote: >> On 17.02.25 12:20, Jan Beulich wrote: >>> On 16.02.2025 11:21, Oleksandr Andrushchenko wrote: >>>> --- a/xen/drivers/char/ns16550.c >>>> +++ b/xen/drivers/char/ns16550.c >>>> @@ -14,7 +14,7 @@ >>>>    * abstracted. >>>>    */ >>>>   #if defined(CONFIG_HAS_PCI) && defined(CONFIG_X86) >>>> -# define NS16550_PCI >>>> +#define NS16550_PCI >>>>   #endif >>> Hmm. Either form ought to be okay, so the line would want leaving untouched. > It seems this can actually have 3 forms under IndentPPDirectives control > Please see [1]. I saw that. None of the three variants matches the original above, i.e. here we're again observing a change just for the sake of making a change. The style used is conforming, after all. Jan > I would go with BeforeHash personally > > [1] https://clang.llvm.org/docs/ClangFormatStyleOptions.html#indentppdirectives > >