All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>,
	Mat Martineau <martineau@kernel.org>,
	Geliang Tang <geliang@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
	linux-kernel@vger.kernel.org, Gang Yan <yangang@kylinos.cn>
Subject: Re: [PATCH net-next v3 0/7] mptcp: out-of-order queue pruning
Date: Mon, 10 Aug 2026 12:57:11 +0200	[thread overview]
Message-ID: <f73cfd79-8729-4d99-8dcf-73010437782e@kernel.org> (raw)
In-Reply-To: <9f7f0fa7-52e9-4640-9264-13c98ed4d602@redhat.com>

Hi Paolo,

On 10/08/2026 11:53, Paolo Abeni wrote:
> On 8/7/26 3:49 PM, Matthieu Baerts (NGI0) wrote:
>> Under memory pressure, a pruning of the MPTCP-level OoO queue might be
>> required as last resort, to avoid too long recoveries, or even stalls.
>> Geliang and Gang managed to reproduce this behaviour, and Paolo
>> improved the situation thanks to the following patches:
>>
>> - Patches 1-3: improve the MPTCP-level retransmission schema to make
>>   recoveries from memory pressure/after MPTCP-level drop significantly
>>   faster.
>>
>> - Patches 4-5: make the admission check way stricter for incoming
>>   packets exceeding the memory limits, with some exceptions for fallback
>>   sockets.
>>
>> - Patches 6-7: implement OoO queue pruning for MPTCP.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Sashiko has a few comments on this series, but IMHO only patches 2 and 7
> really need some adjustment, and changes there (fix the stale/retrans
> race, wrong unlikely, and too early OoO prune) should be handled as
> follow-ups.

Thank you for having checked. I agree with you, follow-ups seems better
for fix these "details".

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  reply	other threads:[~2026-08-10 10:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 13:49 [PATCH net-next v3 0/7] mptcp: out-of-order queue pruning Matthieu Baerts (NGI0)
2026-08-07 13:49 ` [PATCH net-next v3 1/7] mptcp: move the retrans loop to a separate helper Matthieu Baerts (NGI0)
2026-08-07 13:49 ` [PATCH net-next v3 2/7] mptcp: move the stale logic out of retrans scheduler Matthieu Baerts (NGI0)
2026-08-07 13:49 ` [PATCH net-next v3 3/7] mptcp: let the retrans scheduler do its job Matthieu Baerts (NGI0)
2026-08-07 13:49 ` [PATCH net-next v3 4/7] mptcp: explicitly drop over memory limits Matthieu Baerts (NGI0)
2026-08-07 13:49 ` [PATCH net-next v3 5/7] mptcp: enforce hard limit on backlog flushing Matthieu Baerts (NGI0)
2026-08-07 13:49 ` [PATCH net-next v3 6/7] mptcp: avoid code duplication in __mptcp_move_skb() Matthieu Baerts (NGI0)
2026-08-07 13:49 ` [PATCH net-next v3 7/7] mptcp: implemented OoO queue pruning Matthieu Baerts (NGI0)
2026-08-10  9:53 ` [PATCH net-next v3 0/7] mptcp: out-of-order " Paolo Abeni
2026-08-10 10:57   ` Matthieu Baerts [this message]
2026-08-12  1:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f73cfd79-8729-4d99-8dcf-73010437782e@kernel.org \
    --to=matttbe@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=geliang@kernel.org \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martineau@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yangang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.