Re: [PATCH v6 09/16] libs/ctrl: Allows writev_exact to change iov array

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 19/06/2026 2:04 pm, Frediano Ziglio wrote:
> diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h
> index b5892ae8dc..3af996e900 100644
> --- a/tools/libs/ctrl/xc_private.h
> +++ b/tools/libs/ctrl/xc_private.h
> @@ -383,7 +383,7 @@ int xc_flush_mmu_updates(xc_interface *xch, struct xc_mmu *mmu);
>  /* Return 0 on success; -1 on error setting errno. */
>  int read_exact(int fd, void *data, size_t size); /* EOF => -1, errno=0 */
>  int write_exact(int fd, const void *data, size_t size);
> -int writev_exact(int fd, const struct iovec *iov, int iovcnt);
> +int writev_exact(int fd, struct iovec *iov, int iovcnt);

No callers care, but this is written with a const pointer to match writev().

If we really do want to take this change, then it needs to come with a
comment saying /* May edit iov to cope with partial writes. */

~Andrew