From: Valentin Kleibel <valentin@vrvis.at>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Justin Sanders <justin@coraid.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: aoe: handle device timeouts atomic-safe
Date: Mon, 28 Mar 2022 17:06:11 +0200 [thread overview]
Message-ID: <f74aa70e-8222-12fc-b44a-880865c9badd@vrvis.at> (raw)
In-Reply-To: <YioZaO21yingv0nD@infradead.org>
On 10/03/2022 16:29, Christoph Hellwig wrote:
> On Thu, Mar 10, 2022 at 04:17:37PM +0100, Valentin Kleibel wrote:
>> If an aoe device does not respond to any packet on the network layer within
>> aoe_deadsecs, the driver tries to mark the device as down, fail all I/O and
>> clean out the queue.
>
> I think the problem is that aoe even tries to queue up request
> internally. It really needs to switch to use BLK_MQ_F_BLOCKING and
> stop queuing up the requests internall at all.
Unfortunately I'm not able to assess this.
It would be a more complicated change than I'd be able to provide and
the proposed patch fixes the existing issue.
Cheers,
Valentin
prev parent reply other threads:[~2022-03-28 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 15:17 [PATCH] block: aoe: handle device timeouts atomic-safe Valentin Kleibel
2022-03-10 15:29 ` Christoph Hellwig
2022-03-28 15:06 ` Valentin Kleibel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f74aa70e-8222-12fc-b44a-880865c9badd@vrvis.at \
--to=valentin@vrvis.at \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=justin@coraid.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.