From: John Snow <jsnow@redhat.com>
To: Nir Soffer <nirsof@gmail.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
qemu-block@nongnu.org, Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] Alignment checks cleanup
Date: Wed, 28 Aug 2019 15:15:41 -0400 [thread overview]
Message-ID: <f75165f2-7b48-560e-13aa-059fdb00a1c0@redhat.com> (raw)
In-Reply-To: <20190827185913.27427-1-nsoffer@redhat.com>
On 8/27/19 2:59 PM, Nir Soffer wrote:
> While working on 4k support, I noticed that there is lot of code using
> BDRV_SECTOR_SIZE (512) for checking alignment. I wonder how this can work with
> 4k storage.
>
> Lets start by cleaning up to make the code easier to understand:
> - Use QEMU_IS_ALIGNED macro to check alignment
> - Remove unneeded masks based on BDRV_SECTOR_SIZE
>
> Nir Soffer (2):
> block: Use QEMU_IS_ALIGNED
> block: Remove unused masks
>
> block/bochs.c | 4 ++--
> block/cloop.c | 4 ++--
> block/dmg.c | 4 ++--
> block/io.c | 8 ++++----
> block/qcow2-cluster.c | 4 ++--
> block/qcow2.c | 4 ++--
> block/vvfat.c | 8 ++++----
> include/block/block.h | 2 --
> migration/block.c | 2 +-
> qemu-img.c | 2 +-
> 10 files changed, 20 insertions(+), 22 deletions(-)
>
V2 changelog?
(Looks like adding patch 2 as a result of changing away users from the
BDRV_SECTOR_MASK.)
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2019-08-28 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 18:59 [Qemu-devel] [PATCH v2 0/2] Alignment checks cleanup Nir Soffer
2019-08-27 18:59 ` [Qemu-devel] [PATCH v2 1/2] block: Use QEMU_IS_ALIGNED Nir Soffer
2019-08-27 18:59 ` [Qemu-devel] [PATCH v2 2/2] block: Remove unused masks Nir Soffer
2019-08-28 10:44 ` Juan Quintela
2019-08-28 19:12 ` [Qemu-devel] [Qemu-block] " John Snow
2019-08-28 19:15 ` John Snow [this message]
2019-08-30 20:25 ` [Qemu-devel] [Qemu-block] [PATCH v2 0/2] Alignment checks cleanup Nir Soffer
2019-09-05 8:45 ` Nir Soffer
2019-09-10 10:42 ` [Qemu-devel] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f75165f2-7b48-560e-13aa-059fdb00a1c0@redhat.com \
--to=jsnow@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=nirsof@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.