From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH liburing] test/lfs-open: less limited test_drained_files
Date: Tue, 20 Oct 2020 08:12:08 -0600 [thread overview]
Message-ID: <f7625f7f-86e5-fd4a-4f71-ae76110dfd68@kernel.dk> (raw)
In-Reply-To: <d6fd0e761f9daafcd4a8092117dfd751c94f2a06.1603122173.git.asml.silence@gmail.com>
On 10/19/20 9:46 AM, Pavel Begunkov wrote:
> close(dup(io_uring)) should not neccessary cancel all requests with
> files, because files are not yet going away. Test that it doesn't hang
> after close() and exits, that's enough.
Applied with the below incremental.
diff --git a/test/lfs-openat.c b/test/lfs-openat.c
index 3fa0b99db1b3..b14238a9a41d 100644
--- a/test/lfs-openat.c
+++ b/test/lfs-openat.c
@@ -133,10 +133,9 @@ static int test_drained_files(int dfd, const char *fn, bool linked, bool prepend
{
struct io_uring ring;
struct io_uring_sqe *sqe;
- struct io_uring_cqe *cqe;
char buffer[128];
struct iovec iov = {.iov_base = buffer, .iov_len = sizeof(buffer), };
- int i, ret, fd, fds[2], to_cancel = 0;
+ int ret, fd, fds[2], to_cancel = 0;
ret = io_uring_queue_init(10, &ring, 0);
if (ret < 0)
--
Jens Axboe
next prev parent reply other threads:[~2020-10-20 14:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 15:46 [PATCH liburing] test/lfs-open: less limited test_drained_files Pavel Begunkov
2020-10-20 14:12 ` Jens Axboe [this message]
2020-10-20 16:15 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7625f7f-86e5-fd4a-4f71-ae76110dfd68@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.