From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23E6FC5AE59 for ; Tue, 3 Jun 2025 13:28:39 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1004456.1384177 (Exim 4.92) (envelope-from ) id 1uMRgq-0005aI-Dt; Tue, 03 Jun 2025 13:28:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1004456.1384177; Tue, 03 Jun 2025 13:28:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uMRgq-0005aB-BI; Tue, 03 Jun 2025 13:28:28 +0000 Received: by outflank-mailman (input) for mailman id 1004456; Tue, 03 Jun 2025 13:28:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1uMRgo-0005a3-IX for xen-devel@lists.xenproject.org; Tue, 03 Jun 2025 13:28:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1uMRgo-000DDd-0B; Tue, 03 Jun 2025 13:28:26 +0000 Received: from [15.248.2.27] (helo=[10.24.67.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uMRgo-005iP7-0l; Tue, 03 Jun 2025 13:28:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=VcHdTJplhFZR3c9y8nV6FDmR2+6su7oR4/sHzBnqvkE=; b=uejBsbj9zqLYEaKSPRqwSkCDsU 0PYKxyzQR1IYxEImYO8jWxYMu2ubWsnK409+lTWVj8TVL3Aq+nG+BVITj0ze5n05BdB2AWJbSrlmk FOMyeu/Dvvxi5YoE8JDd8AUEn7LhdOR3C6sia+3ERoyzvZsj6UDfuXR4xPyGW54/fFAk=; Message-ID: Date: Tue, 3 Jun 2025 14:28:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] device-tree: Move Arm's static-memory feature to common Content-Language: en-GB To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , Anthony PERARD , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= References: <20250603100329.149851-1-michal.orzel@amd.com> <20250603100329.149851-4-michal.orzel@amd.com> From: Julien Grall In-Reply-To: <20250603100329.149851-4-michal.orzel@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 03/06/2025 11:03, Michal Orzel wrote: > This feature is arch agnostic, thus move it to common. > > Signed-off-by: Michal Orzel With one remark below: Acked-by: Julien Grall [...] > diff --git a/xen/arch/arm/include/asm/static-memory.h b/xen/include/xen/static-memory.h > similarity index 93% > rename from xen/arch/arm/include/asm/static-memory.h > rename to xen/include/xen/static-memory.h > index a32a3c6553bc..e445aa80578c 100644 > --- a/xen/arch/arm/include/asm/static-memory.h > +++ b/xen/include/xen/static-memory.h > @@ -1,13 +1,14 @@ > /* SPDX-License-Identifier: GPL-2.0-only */ > > -#ifndef __ASM_STATIC_MEMORY_H_ > -#define __ASM_STATIC_MEMORY_H_ > +#ifndef XEN_STATIC_MEMORY_H > +#define XEN_STATIC_MEMORY_H > > #include > -#include > > #ifdef CONFIG_STATIC_MEMORY > > +#include This change looks a bit odd in the context of the patch. I guess this is moved because the include should not be used if !CONFIG_STATIC_MEMORY? I am fine if you want to keep it here. But it would be worth mentioning in the commit message. > + > static inline void init_staticmem_bank(const struct membank *bank) > { > mfn_t bank_start = _mfn(PFN_UP(bank->start)); > @@ -46,7 +47,7 @@ static inline void init_staticmem_pages(void) {}; > > #endif /* CONFIG_STATIC_MEMORY */ > > -#endif /* __ASM_STATIC_MEMORY_H_ */ > +#endif /* XEN_STATIC_MEMORY_H */ > > /* > * Local variables: Cheers, -- Julien Grall