From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] Revert "drm/i915: mark all device info struct with __initconst"
Date: Mon, 29 Jan 2018 10:34:05 +0000 [thread overview]
Message-ID: <f786d40a-dd3c-3a97-91c2-243d816cdc8d@linux.intel.com> (raw)
In-Reply-To: <151721644127.26642.4145338653340788114@mail.alporthouse.com>
On 29/01/2018 09:00, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2018-01-29 08:33:46)
>> This reverts commit 5b54eddd3920e9f6f1a6d972454baf350cbae77e.
>>
>> Conflicts:
>> drivers/gpu/drm/i915/i915_pci.c
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104805
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>
> Mea culpa, completely didn't realise post-module init loading was a
> thing.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> It's still on the low hanging fruit list for reducing our bloat. Ideas?
> i915_pcidata.ko? How far could we go with that, make all gen specific
> code a separate section and unload them after init?
There is one maybe easy win with DMI_MATCH business. It modpost was
taught to handle string relocs, one could remove the hardcoded string
storage of 4x79 bytes for every DMI_MATCH entry. We have one large-ish
table which is not __initconst in intel_no_lvds, but I haven't looked at
the rest of the kernel - if all other users are mostly __initconst then
the saving wouldn't be that universally interesting.
One larger code re-org could be to move all genX prefixed functions into
separate .kos and load them dynamically. But it is very difficult to
estimate the saving given how much re-use we have. And the extraction
would probably be quite messy.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-29 10:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 8:33 [PATCH] Revert "drm/i915: mark all device info struct with __initconst" Lionel Landwerlin
2018-01-29 8:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-01-29 9:00 ` [PATCH] " Chris Wilson
2018-01-29 10:34 ` Tvrtko Ursulin [this message]
2018-01-29 10:44 ` Chris Wilson
2018-01-29 9:02 ` Chris Wilson
2018-01-29 9:27 ` Lionel Landwerlin
2018-01-29 9:57 ` Lukas Wunner
2018-01-29 10:00 ` Jani Nikula
2018-01-30 8:44 ` Jani Nikula
2018-01-31 2:15 ` Rodrigo Vivi
2018-01-31 17:02 ` Lionel Landwerlin
2018-01-29 10:32 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f786d40a-dd3c-3a97-91c2-243d816cdc8d@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.