Re: [PATCH 1/2] mcspi: Add support for GPIO chip select lines

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

Ben Gamari <bgamari.foss-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

>> Yes, this is a better approach. However, I'd rather see the gpio
>data
>> passed as an array to the spi master platform_device via the
>> private_data structure.
>
>Sorry for my ignorance but I really have no idea how one would hook
>this
>up in the board code (which IMHO is where this sort of chip select
>configuration belongs). Looking at the beagleboard board file I see no
>reference to a spi master platform_device. The SPI devices are
>registered
>through spi_register_board_info. Could you clarify how this would work?

The spi_master platform device is registered somewhere in the inappropriate support code. You need to arrange to make sure the correct pdata is attached to it when it gets registered. There /should/ be a mechanism for doing so.

All spi devices already specify a cs number anyway. What you can do is use the cs number as the lookup index into the gpio table, and remember to reserve a cs# for the 'native' cs line.

g.

-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d