From: Mario Limonciello <mario.limonciello@amd.com>
To: K Prateek Nayak <kprateek.nayak@amd.com>,
"Rafael J . Wysocki" <rafael@kernel.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, x86@kernel.org,
Vishal Badole <Vishal.Badole@amd.com>
Subject: Re: [PATCH 1/3] ACPI: CPPC: Refactor boost ratio handling
Date: Tue, 1 Sep 2026 10:26:24 -0500 [thread overview]
Message-ID: <f7a94d16-348d-46dd-a8b8-e36fa95267d2@amd.com> (raw)
In-Reply-To: <1aab438e-9841-4def-8982-1433f38c0e96@amd.com>
On 8/31/26 23:41, K Prateek Nayak wrote:
> Hello Mario,
>
> On 9/1/2026 1:14 AM, Mario Limonciello wrote:
>> +static const struct amd_max_freq max_freq_zen6_client __initconst = {
>> + .performance = 5025,
>> + .efficiency = 3524,
>> + .low_power = 2399,
>> +};
>> +
>> +static const struct x86_cpu_id amd_zen6_client_ids[] __initconst = {
>> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 0x1A, 0x80, &max_freq_zen6_client),
>> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 0x1A, 0x81, &max_freq_zen6_client),
>> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 0x1A, 0x84, &max_freq_zen6_client),
>> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 0x1A, 0x85, &max_freq_zen6_client),
>> + X86_MATCH_VENDOR_FAM_MODEL(AMD, 0x1A, 0xe0, &max_freq_zen6_client),
>> + {}
>> +};
>
> So I see:
>
> WARNING: modpost: vmlinux: section mismatch in reference: amd_get_max_frequency+0x27 (section: .text) -> amd_zen6_client_ids (section: .init.rodata)
>
> Since amd_get_boost_ratio() can be called post init too, I think
> dropping the __initconst annotation makes sense for these constants
> otherwise we may have issues after initmem is freed.
>
Thanks, will get this fixed. I didn't catch it because I usually step
out during my kernel builds and it didn't make enough noise to stop the
build :P.
next prev parent reply other threads:[~2026-09-01 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 19:44 [PATCH 0/3] Zen6 client CPPC Mario Limonciello
2026-08-31 19:44 ` [PATCH 1/3] ACPI: CPPC: Refactor boost ratio handling Mario Limonciello
2026-09-01 4:41 ` K Prateek Nayak
2026-09-01 15:26 ` Mario Limonciello [this message]
2026-09-01 9:31 ` K Prateek Nayak
2026-09-01 15:28 ` Mario Limonciello
2026-09-01 16:34 ` Rafael J. Wysocki (Intel)
2026-09-01 16:44 ` Mario Limonciello
2026-08-31 19:44 ` [PATCH 2/3] cpufreq/acpi-cpufreq: Use amd_get_boost_ratio() Mario Limonciello
2026-08-31 19:44 ` [PATCH 3/3] cpufreq/amd-pstate: Get Highest Freq for a CPU Mario Limonciello
2026-09-01 9:36 ` [PATCH 0/3] Zen6 client CPPC K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7a94d16-348d-46dd-a8b8-e36fa95267d2@amd.com \
--to=mario.limonciello@amd.com \
--cc=Vishal.Badole@amd.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.