From: Matti Vaittinen <mazziesaccount@gmail.com>
To: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>,
"brgl@bgdev.pl" <brgl@bgdev.pl>
Cc: "bartosz.golaszewski@linaro.org" <bartosz.golaszewski@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/2] gpio: omap: save two lines by using devm_clk_get_prepared()
Date: Mon, 16 Dec 2024 13:14:47 +0200 [thread overview]
Message-ID: <f7c3effb-a7e1-4a24-ac7e-f84e49eefb80@gmail.com> (raw)
In-Reply-To: <72c52d8a-b0f2-4767-9e8c-ce869d203d0b@gmail.com>
On 16/12/2024 13:11, Matti Vaittinen wrote:
> On 16/12/2024 10:57, Sverdlin, Alexander wrote:
...
> This fixes the boot as you assumed.
> I suppose this should be baked in the Bartosz's original patch assumed
> it was dropped from the GPIO tree.
>
> Furthermore, this seems to be a fix to a hidden problem on original
> code.
Just a minor clarification:
"Original code" here refers to the code before the
"gpio: omap: save two lines by using devm_clk_get_prepared()"
> If the original code failed in the clk_prepare() and then deferred
> probe(), this same problem should have appeared, right?
>
> Maybe consider using Fixes - tag even if this and the original change
> got squashed. Feel free to add a:
Yours,
-- Matti
next prev parent reply other threads:[~2024-12-16 11:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 16:41 [PATCH 1/2] gpio: omap: allow building the module with COMPILE_TEST=y Bartosz Golaszewski
2024-12-03 16:41 ` [PATCH 2/2] gpio: omap: save two lines by using devm_clk_get_prepared() Bartosz Golaszewski
2024-12-03 18:19 ` Sverdlin, Alexander
2024-12-13 12:16 ` Matti Vaittinen
2024-12-13 12:29 ` Sverdlin, Alexander
2024-12-13 13:17 ` Bartosz Golaszewski
2024-12-13 13:55 ` Matti Vaittinen
2024-12-16 8:57 ` Sverdlin, Alexander
2024-12-16 11:11 ` Matti Vaittinen
2024-12-16 11:14 ` Matti Vaittinen [this message]
2024-12-16 11:27 ` Sverdlin, Alexander
2024-12-03 18:18 ` [PATCH 1/2] gpio: omap: allow building the module with COMPILE_TEST=y Sverdlin, Alexander
2024-12-03 18:41 ` Andrew Davis
2024-12-03 20:36 ` Bartosz Golaszewski
2024-12-03 21:54 ` Andrew Davis
2024-12-05 10:27 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7c3effb-a7e1-4a24-ac7e-f84e49eefb80@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=alexander.sverdlin@siemens.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.