All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tammana, Gowtham" <g-tammana@ti.com>
To: Denys Dmytriyenko <denis@denix.org>,
	"meta-arago@arago-project.org" <meta-arago@arago-project.org>
Cc: Denys Dmytriyenko <denys@konsulko.com>
Subject: Re: [EXTERNAL] [dunfell/master][PATCH 2/4] images/packagegroups: add extra browser-layer check when including chromium
Date: Wed, 24 Mar 2021 22:44:49 +0000	[thread overview]
Message-ID: <f7dcb2b2616644279a3619ef8f9f92cf@ti.com> (raw)
In-Reply-To: <1616534107-46438-2-git-send-email-denis@denix.org>



>-----Original Message-----
>From: meta-arago-bounces@arago-project.org <meta-arago-bounces@arago-
>project.org> On Behalf Of Denys Dmytriyenko
>Sent: Tuesday, March 23, 2021 4:15 PM
>To: meta-arago@arago-project.org
>Cc: Denys Dmytriyenko <denys@konsulko.com>
>Subject: [EXTERNAL] [meta-arago] [dunfell/master][PATCH 2/4]
>images/packagegroups: add extra browser-layer check when including
>chromium
>
>From: Denys Dmytriyenko <denys@konsulko.com>
>
>When pulling in chromium, check that all conditions are met:
>1. browser-layer layer is present
>2. meta-python2 layer is present
>3. wayland distro feature is enabled
>
>Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>

Reviewed-by: Gowtham Tammana <g-tammana@ti.com>

>---
> meta-arago-distro/recipes-core/images/tisdk-default-image.bb | 2 +-
> meta-arago-distro/recipes-core/packagegroups/ti-world.bb     | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
>b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
>index bc77b97..152f857 100644
>--- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
>+++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb
>@@ -50,7 +50,7 @@ EXTRABROWSERS = " \
>
> PYTHON2APPS = " \
>
>${@bb.utils.contains('MACHINE_FEATURES','gpu',"${EXTRABROWSERS}",'',d)} \
>-    ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', "${CHROMIUM}", '',
>d)} \
>+    ${@bb.utils.contains("BBFILE_COLLECTIONS","browser-
>layer",bb.utils.contains('DISTRO_FEATURES','wayland',"${CHROMIUM}",'',d),'
>',d)} \
> "
>
> DEVTOOLS = " \
>diff --git a/meta-arago-distro/recipes-core/packagegroups/ti-world.bb
>b/meta-arago-distro/recipes-core/packagegroups/ti-world.bb
>index 87f3004..440e9e6 100644
>--- a/meta-arago-distro/recipes-core/packagegroups/ti-world.bb
>+++ b/meta-arago-distro/recipes-core/packagegroups/ti-world.bb
>@@ -23,7 +23,7 @@ EXTRABROWSERS = " \
>
> PYTHON2APPS = " \
>
>${@bb.utils.contains('MACHINE_FEATURES','gpu',"${EXTRABROWSERS}",'',d)} \
>-    ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', "${CHROMIUM}", '',
>d)} \
>+    ${@bb.utils.contains("BBFILE_COLLECTIONS","browser-
>layer",bb.utils.contains('DISTRO_FEATURES','wayland',"${CHROMIUM}",'',d),'
>',d)} \
> "
>
> DEVTOOLS = " \
>--
>2.7.4
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


  reply	other threads:[~2021-03-24 22:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 21:15 [dunfell/master][PATCH 1/4] chromium: apply bbappend with fix dynamically based on "browser-layer" presence Denys Dmytriyenko
2021-03-23 21:15 ` [dunfell/master][PATCH 2/4] images/packagegroups: add extra browser-layer check when including chromium Denys Dmytriyenko
2021-03-24 22:44   ` Tammana, Gowtham [this message]
2021-03-23 21:15 ` [dunfell/master][PATCH 3/4] chromium: fix building of version 75 against more recent pulseaudio Denys Dmytriyenko
2021-03-23 21:15 ` [dunfell/master][PATCH 4/4] qtwebengine: fix building latest qtwebengine with meta-python2 Denys Dmytriyenko
2021-03-24 14:30   ` [EXTERNAL] " Tammana, Gowtham
2021-05-03 21:12 ` [dunfell/master][PATCH 1/4] chromium: apply bbappend with fix dynamically based on "browser-layer" presence Denys Dmytriyenko
2021-05-03 21:29   ` Bajjuri, Praneeth
2021-05-03 21:32     ` Denys Dmytriyenko
2021-05-03 21:37       ` Bajjuri, Praneeth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7dcb2b2616644279a3619ef8f9f92cf@ti.com \
    --to=g-tammana@ti.com \
    --cc=denis@denix.org \
    --cc=denys@konsulko.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.