From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B06C433EF for ; Tue, 5 Oct 2021 15:14:40 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B451F61501 for ; Tue, 5 Oct 2021 15:14:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B451F61501 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DDA1A166A; Tue, 5 Oct 2021 17:13:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DDA1A166A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1633446878; bh=WQjdLaVGfmb29cCmEucMGmn1DBwCCk43ydhYKi278ek=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IHiKUr2Q3ddA26u28c9oBiT7d/T+9GwYHyRXBwqHifZljGv4xD5n7s6KrjAGh0YWA 3L6dGFQNcC9Xq1FXG8LAaulU7uzf8fWlxQo8Eo6KQfaQ3/D5O9/NJbSV7OUv3rB1yC mRx0SCzpwfdXjIyw1lRMoe8Px0SNXQEclUN6wigc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5F974F80259; Tue, 5 Oct 2021 17:13:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E43A2F8027D; Tue, 5 Oct 2021 17:13:45 +0200 (CEST) Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7A1B0F8020D for ; Tue, 5 Oct 2021 17:13:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7A1B0F8020D Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="ci3YUWau" DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1633446824; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=s3Xb4IsSqsYB8Xe3c7qxyiGRJeLbjA3gkFSG8+CibCw=; b=ci3YUWauTTzD3KiMBMK2iQYParPQqQbjJYUMgSsBqwr8OsJX06YBidxPPNXi56ygSwHhdBQ/ rpRHZfqV50i8PRMx6qq4qMYaT0mhPHYF+F4ZqVbawDU/ntBjkzVGZ3DNUHN7Nni1oQWT0exW x6zo2qYTqztgMImU5QI2wYOZlVs= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI4ZmE2ZSIsICJhbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 615c6b937ae92c7fc90fdaba (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 05 Oct 2021 15:13:23 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id DC1AEC43460; Tue, 5 Oct 2021 15:13:22 +0000 (UTC) Received: from [192.168.1.102] (unknown [157.48.255.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: srivasam) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7DCE6C4360C; Tue, 5 Oct 2021 15:13:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 7DCE6C4360C Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Subject: Re: [PATCH] ASoC: qcom: soundwire: Enable soundwire bus clock for version 1.6 To: Pierre-Louis Bossart , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org References: <1633105471-30928-1-git-send-email-srivasam@codeaurora.org> <2c18ff0c-cd24-356c-0104-086837ed7ff0@codeaurora.org> From: Srinivasa Rao Mandadapu Organization: Qualcomm India Private Limited. Message-ID: Date: Tue, 5 Oct 2021 20:43:11 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Cc: Venkata Prasad Potturu X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 10/5/2021 8:33 PM, Pierre-Louis Bossart wrote: > Thanks for Your time Bossart!!! > >>>> +        ctrl->swrm_hctl_reg = devm_ioremap(&pdev->dev, >>>> swrm_hctl_reg, 0x4); >>> if (!ctrl->swrm_hctl_reg) >>>      return -ENODEV; >>> >>> ? >> I think here error check is not required, as this change is required >> only for soundwire version 1.6 and above. > My comment had nothing to do with versions, it's just that ioremap can > fail and in general it's wise to test for errors... Okay. My intention is if offset (swrm_hctl_reg) is zero, devm_ioremap may return error. In that case we need to ignore error. -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.