All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Audra Mitchell <audra@redhat.com>
Cc: linux-kselftest@vger.kernel.org, akpm@linux-foundation.org,
	lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
	vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
	mhocko@suse.com, shuah@kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/mm: Fix soft-dirty kselftest supported check
Date: Fri, 20 Mar 2026 12:26:50 +0100	[thread overview]
Message-ID: <f7fef55d-4334-4d1d-b6c6-b409fea7e2a1@kernel.org> (raw)
In-Reply-To: <abxHibvF8E5dcrUf@fedora>

On 3/19/26 19:59, Audra Mitchell wrote:
>> What about simply testing for success on a test area, wouldn't that be more reliable
>> and clearer?
> 
> Hey I tested your version of this patch and it works fine on s390 and x86_64.
> I have no issue with this version at all!
> 
> Would you prefer to push this fix since you wrote it or do you want me to push
> a v2 and give you credit?

The credit is all yours :) Please polish the patch description to make
it clearer why the current check is problematic.

-- 
Cheers,

David

  reply	other threads:[~2026-03-20 11:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 18:42 [PATCH] selftests/mm: Fix soft-dirty kselftest supported check Audra Mitchell
2026-02-24 16:15 ` David Hildenbrand (Arm)
2026-03-17 15:08   ` Audra Mitchell
2026-03-18  8:17     ` David Hildenbrand (Arm)
2026-03-19 18:59       ` Audra Mitchell
2026-03-20 11:26         ` David Hildenbrand (Arm) [this message]
2026-03-20 18:39           ` [PATCH V2] " Audra Mitchell
2026-03-20 18:39             ` [PATCH] " Audra Mitchell
2026-03-20 20:53               ` Andrew Morton
2026-03-23 11:56               ` David Hildenbrand (Arm)
2026-03-24 23:23                 ` Andrew Morton
2026-03-24 23:24                   ` Andrew Morton
2026-03-25 16:23                     ` Audra Mitchell
2026-03-27 10:08                       ` David Hildenbrand (Arm)
2026-03-27 10:52       ` Lorenzo Stoakes (Oracle)
2026-03-27 10:58         ` Lorenzo Stoakes (Oracle)
2026-03-27 11:15           ` Lorenzo Stoakes (Oracle)
2026-03-27 11:14         ` Lorenzo Stoakes (Oracle)
2026-03-31 16:32           ` Audra Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7fef55d-4334-4d1d-b6c6-b409fea7e2a1@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=audra@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.