From mboxrd@z Thu Jan  1 00:00:00 1970
From: Klaus Heinrich Kiwi <klausk@br.ibm.com>
Subject: Re: [PATCH] Make IPC mode consistent
Date: Mon, 16 Jul 2007 16:11:29 -0300
Message-ID: <f7gft1$9oa$1@sea.gmane.org>
References: <200705291039.45328.sgrubb@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7Bit
Return-path: <linux-audit-bounces@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [172.16.48.31])
	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l6HHPDJJ013878
	for <linux-audit@redhat.com>; Tue, 17 Jul 2007 13:25:13 -0400
Received: from ciao.gmane.org (main.gmane.org [80.91.229.2])
	by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l6HHP4wP018207
	for <linux-audit@redhat.com>; Tue, 17 Jul 2007 13:25:05 -0400
Received: from root by ciao.gmane.org with local (Exim 4.43)
	id 1IAqnG-0005d4-2x
	for linux-audit@redhat.com; Tue, 17 Jul 2007 19:25:02 +0200
Received: from 32.104.18.240 ([32.104.18.240])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <linux-audit@redhat.com>; Tue, 17 Jul 2007 19:25:02 +0200
Received: from klausk by 32.104.18.240 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <linux-audit@redhat.com>; Tue, 17 Jul 2007 19:25:02 +0200
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: linux-audit@redhat.com
List-Id: linux-audit@redhat.com

Steve,

Steve Grubb wrote:

> Hi,
> 
> The mode fields for IPC records are not consistent. Some are hex, others
> are octal. This patch makes them all octal.
> 
> Signed-off-by: Steve Grubb <sgrubb@redhat.com>

Did this patch got through? There is a Novell BZ (#280257 - unfortunatelly
not public at this time) waiting for this to get upstream.

Thanks,

 Klaus

> 
> diff -urp linux-2.6.18.i686.orig/kernel/auditsc.c
> linux-2.6.18.i686/kernel/auditsc.c
> --- linux-2.6.18.i686.orig/kernel/auditsc.c   2007-05-29 10:27:13.000000000
> -0400
> +++ linux-2.6.18.i686/kernel/auditsc.c        2007-05-29 10:33:07.000000000 -0400
> @@ -941,7 +941,7 @@ static void audit_log_exit(struct audit_
>  case AUDIT_IPC: {
>  struct audit_aux_data_ipcctl *axi = (void *)aux;
>  audit_log_format(ab,
> -                              "ouid=%u ogid=%u mode=%x",
> +                              "ouid=%u ogid=%u mode=%#o",
>  axi->uid, axi->gid, axi->mode);
>  if (axi->osid != 0) {
>  char *ctx = NULL;
> @@ -960,7 +960,7 @@ static void audit_log_exit(struct audit_
>  case AUDIT_IPC_SET_PERM: {
>  struct audit_aux_data_ipcctl *axi = (void *)aux;
>  audit_log_format(ab,
> -                             "qbytes=%lx ouid=%u ogid=%u mode=%x",
> +                             "qbytes=%lx ouid=%u ogid=%u mode=%#o",
>  axi->qbytes, axi->uid, axi->gid, axi->mode);
>  break; }

-- 
.:klaus h kiwi <klausk@br.ibm.com>:.