From: Aaron Conole <aconole@redhat.com>
To: i.maximets@ovn.org
Cc: netdev@vger.kernel.org, Eelco Chaudron <echaudro@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
dev@openvswitch.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [net,2/2] net: openvswitch: fix skb leak on flow key update failure during ct
Date: Mon, 27 Jul 2026 16:34:41 -0400 [thread overview]
Message-ID: <f7t1pcoxjby.fsf@redhat.com> (raw)
In-Reply-To: <20260727181851.306076-3-i.maximets@ovn.org>
Ilya Maximets <i.maximets@ovn.org> writes:
> ovs_ct_execute() always steals or frees the skb on failure while
> ovs_flow_key_update() does not. So, if it fails and we return right
> away, the skb ends up leaked.
>
> Fix that by breaking instead and letting the common error handling
> code at the bottom of the loop to free the skb properly.
>
> This is a very unlikely scenario as it requires the packet to become
> unparseable by applying a set of actions on a previously parseable skb,
> but should be fixed nevertheless.
>
> Reported by Sashiko.
>
> Fixes: ec0d043d05e6 ("openvswitch: Ensure flow is valid before executing ct")
> Cc: stable@vger.kernel.org
> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
> ---
> net/openvswitch/actions.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Aaron Conole <aconole@redhat.com>
prev parent reply other threads:[~2026-07-27 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 18:18 [PATCH net 0/2] net: openvswitch: fix skb leak on flow key update failure Ilya Maximets
2026-07-27 18:18 ` [PATCH net 1/2] net: openvswitch: fix skb leak on flow key update failure during recirculation Ilya Maximets
2026-07-27 20:34 ` [net,1/2] " Aaron Conole
2026-07-27 18:18 ` [PATCH net 2/2] net: openvswitch: fix skb leak on flow key update failure during ct Ilya Maximets
2026-07-27 20:34 ` Aaron Conole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7t1pcoxjby.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.